Skip to contentSkip to conversation

build: Revert using a symbol version map

PATCH In review Steve Dickson 1 participant 2 messages Nov 4, 2014

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 build: Revert using a symbol version map

Commit 045d2e46 cause a number of systems to be undefined during run time in rpc.idmapd.

Having this type of versioning is not necessary in this type of a library so the patch was reverted.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1159943

---
 Makefile.am  |  3 +--
 nfsidmap.map | 31 -------------------------------
 2 files changed, 1 insertion(+), 33 deletions(-)
 delete mode 100644 nfsidmap.map
Makefile.am +1 -2
index 69bbcbc..85f19c8 100644
@@ -26,9 +26,8 @@ pkglib_LTLIBRARIES = nsswitch.la static.la $(UMICH_LDAP_LIB) $(GUMS_MAPPING_LIB)
 #  		by this library.
 
 libnfsidmap_la_SOURCES = libnfsidmap.c cfg.c strlcpy.c cfg.h nfsidmap_internal.h queue.h
-libnfsidmap_la_LDFLAGS = -version-info 3:0:3 -Wl,--version-script=$(srcdir)/nfsidmap.map
+libnfsidmap_la_LDFLAGS = -version-info 3:0:3
 libnfsidmap_la_LIBADD = -ldl
-libnfsidmap_la_DEPENDENCIES = nfsidmap.map
 
 nsswitch_la_SOURCES = nss.c
 nsswitch_la_LDFLAGS = -module -avoid-version
nfsidmap.map deleted +0 -31
deleted file mode 100644
index 1e7cf7e..0000000
@@ -1,31 +0,0 @@
-V_0.26 {
-global:
-	nfs4_init_name_mapping;
-	nfs4_get_default_domain;
-	nfs4_uid_to_name;
-	nfs4_gid_to_name;
-	nfs4_uid_to_owner;
-	nfs4_gid_to_group_owner;
-	nfs4_name_to_uid;
-	nfs4_name_to_gid;
-	nfs4_owner_to_uid;
-	nfs4_owner_to_gid;
-	nfs4_group_owner_to_gid;
-	nfs4_gss_princ_to_ids;
-	nfs4_gss_princ_to_grouplist;
-	nfs4_gss_princ_to_ids_ex;
-	nfs4_gss_princ_to_grouplist_ex;
-	nfs4_set_debug;
-	idmap_verbosity;
-	idmap_log_func;
-	get_default_domain;
-	get_local_realms;
-local:
-	*;
-};
-/*
-V_0.27 {
-global:
-	...
-} V_0.26;
-*/
Signature · 1 line
1.9.3
#1 lore raw
Quoted 9 lines · Steve Dickson

Commit 045d2e46 cause a number of systems to be undefined during run time in rpc.idmapd.

Having this type of versioning is not necessary in this type of a library so the patch was reverted.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1159943

Committed...

steved.

Quoted 59 lines
---
 Makefile.am  |  3 +--
 nfsidmap.map | 31 -------------------------------
 2 files changed, 1 insertion(+), 33 deletions(-)
 delete mode 100644 nfsidmap.map
Makefile.am +1 -2
index 69bbcbc..85f19c8 100644
@@ -26,9 +26,8 @@ pkglib_LTLIBRARIES = nsswitch.la static.la $(UMICH_LDAP_LIB) $(GUMS_MAPPING_LIB)
 #  		by this library.
 
 libnfsidmap_la_SOURCES = libnfsidmap.c cfg.c strlcpy.c cfg.h nfsidmap_internal.h queue.h
-libnfsidmap_la_LDFLAGS = -version-info 3:0:3 -Wl,--version-script=$(srcdir)/nfsidmap.map
+libnfsidmap_la_LDFLAGS = -version-info 3:0:3
 libnfsidmap_la_LIBADD = -ldl
-libnfsidmap_la_DEPENDENCIES = nfsidmap.map
 
 nsswitch_la_SOURCES = nss.c
 nsswitch_la_LDFLAGS = -module -avoid-version
nfsidmap.map deleted +0 -31
deleted file mode 100644
index 1e7cf7e..0000000
@@ -1,31 +0,0 @@
-V_0.26 {
-global:
-	nfs4_init_name_mapping;
-	nfs4_get_default_domain;
-	nfs4_uid_to_name;
-	nfs4_gid_to_name;
-	nfs4_uid_to_owner;
-	nfs4_gid_to_group_owner;
-	nfs4_name_to_uid;
-	nfs4_name_to_gid;
-	nfs4_owner_to_uid;
-	nfs4_owner_to_gid;
-	nfs4_group_owner_to_gid;
-	nfs4_gss_princ_to_ids;
-	nfs4_gss_princ_to_grouplist;
-	nfs4_gss_princ_to_ids_ex;
-	nfs4_gss_princ_to_grouplist_ex;
-	nfs4_set_debug;
-	idmap_verbosity;
-	idmap_log_func;
-	get_default_domain;
-	get_local_realms;
-local:
-	*;
-};
-/*
-V_0.27 {
-global:
-	...
-} V_0.26;
-*/