Skip to contentSkip to conversation

hwmon: (pcf8591) Unused attribute group pcf8591_attr_group_opt

DISCUSSION Guenter Roeck 1 participant 1 message May 15, 2021 1 message not in the archive Hardware monitoring

lore
Share & tools
lore

Guenter Roeck

author maintainer
#1 lore raw
In reply to a message not in the archive
Quoted 3 lines · Evgeny Novikov

Driver drivers/hwmon/pcf8591.ko declares and removes attribute group pcf8591_attr_group_opt, but it does not create it ever. Is it better to remove it completely or to do something else?

Do nothing. Look closely at the file instead to see how the attributes are created, and realize that the group is only used to simplify attribute removal.

Yes, the code is a bit odd and unusual, but it is WAI.

Guenter