Skip to contentSkip to conversation

rtsx_usb_ms: Use msleep_interruptible() in polling loop

PATCH Superseded Ben Hutchings 1 participant 1 message Nov 6, 2014 Sony memorystick

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rtsx_usb_ms: Use msleep_interruptible() in polling loop

rtsx_usb_ms creates a task that mostly sleeps, but tasks in uninterruptible sleep still contribute to the load average (for bug-compatibility with Unix). A load average of ~1 on a system that should be idle is somewhat alarming.

Change the sleep to be interruptible, but still ignore signals.

A better fix might be to replace this loop with a delayed work item.

References: https://bugs.debian.org/765717

---
Re-sent without the typo in linux-kernel address.

Ben.

 drivers/memstick/host/rtsx_usb_ms.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/memstick/host/rtsx_usb_ms.c +2 -1
index a7282b7..7356780 100644
@@ -706,7 +706,8 @@ poll_again:
 		if (host->eject)
 			break;
 
-		msleep(1000);
+		if (msleep_interruptible(1000))
+			flush_signals(current);
 	}
 
 	complete(&host->detect_ms_exit);
Signature · 2 lines
Ben Hutchings
Beware of programmers who carry screwdrivers. - Leonard Brandwein