Skip to contentSkip to conversation

lib/halfmd4: make build optional

PATCH In review Aristeu Rozanski 4 participants 5 messages Nov 6, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lib/halfmd4: make build optional

From: Aristeu Rozanski <[email protected]>

halfmd4 currently is built unconditionally:

	text    data     bss     dec     hex filename
	 801     176       8     985     3d9 lib/halfmd4.o
	 801     176       8     985     3d9 (TOTALS)

and it's used by ext3 and ext4. This patch is useful for situations in which memory footprint is a concern and those filesystems aren't used.

Cc Jan Kara <[email protected]>
Cc Andrew Morton <[email protected]>
Cc Andreas Dilger <[email protected]>
Cc Paul Gortmaker <[email protected]>
Cc Josh Triplett <[email protected]>
---
 fs/ext3/Kconfig | 1 +
 fs/ext4/Kconfig | 1 +
 lib/Kconfig     | 7 +++++++
 lib/Makefile    | 3 ++-
 4 files changed, 11 insertions(+), 1 deletion(-)
fs/ext3/Kconfig +1 -0
index e8c6ba0..a6ab4e8 100644
@@ -1,6 +1,7 @@
 config EXT3_FS
 	tristate "Ext3 journalling file system support"
 	select JBD
+	select HALF_MD4
 	help
 	  This is the journalling version of the Second extended file system
 	  (often called ext3), the de facto standard Linux file system
fs/ext4/Kconfig +1 -0
index efea5d5..cbb56ee 100644
@@ -4,6 +4,7 @@ config EXT4_FS
 	select CRC16
 	select CRYPTO
 	select CRYPTO_CRC32C
+	select HALF_MD4
 	help
 	  This is the next generation of the ext3 filesystem.
 
lib/Kconfig +7 -0
index 675920b..108196c 100644
@@ -180,6 +180,13 @@ config CRC8
 	  when they need to do cyclic redundancy check according CRC8
 	  algorithm. Module will be called crc8.
 
+config HALF_MD4
+	bool "Half MD4 transform"
+	default y
+	help
+	  This option enables a reduced (32 bit output) version of MD4
+	  transform.
+
 config AUDIT_GENERIC
 	bool
 	depends on AUDIT && !AUDIT_ARCH
lib/Makefile +2 -1
index 9c12cbc..53fd120 100644
@@ -22,7 +22,7 @@ lib-$(CONFIG_SMP) += cpumask.o
 lib-y	+= kobject.o klist.o
 obj-y	+= lockref.o
 
-obj-y += bcd.o div64.o sort.o parser.o halfmd4.o debug_locks.o random32.o \
+obj-y += bcd.o div64.o sort.o parser.o debug_locks.o random32.o \
 	 bust_spinlocks.o hexdump.o kasprintf.o bitmap.o scatterlist.o \
 	 gcd.o lcm.o list_sort.o uuid.o iovec.o clz_ctz.o \
 	 bsearch.o find_last_bit.o find_next_bit.o llist.o memweight.o kfifo.o \
@@ -74,6 +74,7 @@ obj-$(CONFIG_CRC7)	+= crc7.o
 obj-$(CONFIG_LIBCRC32C)	+= libcrc32c.o
 obj-$(CONFIG_CRC8)	+= crc8.o
 obj-$(CONFIG_GENERIC_ALLOCATOR) += genalloc.o
+obj-$(CONFIG_HALF_MD4) += halfmd4.o
 
 obj-$(CONFIG_ZLIB_INFLATE) += zlib_inflate/
 obj-$(CONFIG_ZLIB_DEFLATE) += zlib_deflate/
Signature · 1 line
1.8.3.1
#1 lore raw
Quoted 10 lines · Aristeu Rozanski

From: Aristeu Rozanski <[email protected]>

halfmd4 currently is built unconditionally:

	text    data     bss     dec     hex filename
	 801     176       8     985     3d9 lib/halfmd4.o
	 801     176       8     985     3d9 (TOTALS)

and it's used by ext3 and ext4. This patch is useful for situations in which memory footprint is a concern and those filesystems aren't used.

[]

lib/Kconfig

Quoted 1 line
lib/Kconfig +0 -0

[]

lib/Kconfig config CRC8 · line 185

Quoted 3 lines
lib/Kconfig +3 -0
+config HALF_MD4
+	bool "Half MD4 transform"
+	default y

why not default n ? (and in the other patch)

#2 lore raw
Quoted 1 line · Joe Perches

why not default n ? (and in the other patch)

As I see, stuff in lib/ can be available by default unless you specifically ask to disable it. It doesn't really matter in these patches since most of the time the options will be selected indirectly anyway.

Signature · 1 line
Aristeu
#3 lore raw
In reply to Aristeu Rozanski

lib/Kconfig config CRC8 · line 189

Quoted 7 lines · Aristeu Rozanski
lib/Kconfig +7 -0
+config HALF_MD4
+	bool "Half MD4 transform"
+	default y
+	help
+	  This option enables a reduced (32 bit output) version of MD4
+	  transform.
+

i'd suggest just def_bool n, and not have this prompt the user at all... it only provides a single export_symbol, so a user doesn't really need to care.

regards, Kyle

#4 lore raw
In reply to Aristeu Rozanski
Quoted 11 lines · Aristeu Rozanski

From: Aristeu Rozanski <[email protected]>

halfmd4 currently is built unconditionally:

	text    data     bss     dec     hex filename
	 801     176       8     985     3d9 lib/halfmd4.o
	 801     176       8     985     3d9 (TOTALS)

and it's used by ext3 and ext4. This patch is useful for situations in which memory footprint is a concern and those filesystems aren't used.

Quoted 6 lines
Cc Jan Kara <[email protected]>
Cc Andrew Morton <[email protected]>
Cc Andreas Dilger <[email protected]>
Cc Paul Gortmaker <[email protected]>
Cc Josh Triplett <[email protected]>

I already have a patch for this in the tiny tree, branch tiny/no-halfmd4, and it uses an internal hidden Kconfig symbol.

- Josh Triplett

Quoted 72 lines
 fs/ext3/Kconfig | 1 +
 fs/ext4/Kconfig | 1 +
 lib/Kconfig     | 7 +++++++
 lib/Makefile    | 3 ++-
 4 files changed, 11 insertions(+), 1 deletion(-)
fs/ext3/Kconfig +1 -0
index e8c6ba0..a6ab4e8 100644
@@ -1,6 +1,7 @@
 config EXT3_FS
 	tristate "Ext3 journalling file system support"
 	select JBD
+	select HALF_MD4
 	help
 	  This is the journalling version of the Second extended file system
 	  (often called ext3), the de facto standard Linux file system
fs/ext4/Kconfig +1 -0
index efea5d5..cbb56ee 100644
@@ -4,6 +4,7 @@ config EXT4_FS
 	select CRC16
 	select CRYPTO
 	select CRYPTO_CRC32C
+	select HALF_MD4
 	help
 	  This is the next generation of the ext3 filesystem.
 
lib/Kconfig +7 -0
index 675920b..108196c 100644
@@ -180,6 +180,13 @@ config CRC8
 	  when they need to do cyclic redundancy check according CRC8
 	  algorithm. Module will be called crc8.
 
+config HALF_MD4
+	bool "Half MD4 transform"
+	default y
+	help
+	  This option enables a reduced (32 bit output) version of MD4
+	  transform.
+
 config AUDIT_GENERIC
 	bool
 	depends on AUDIT && !AUDIT_ARCH
lib/Makefile +2 -1
index 9c12cbc..53fd120 100644
@@ -22,7 +22,7 @@ lib-$(CONFIG_SMP) += cpumask.o
 lib-y	+= kobject.o klist.o
 obj-y	+= lockref.o
 
-obj-y += bcd.o div64.o sort.o parser.o halfmd4.o debug_locks.o random32.o \
+obj-y += bcd.o div64.o sort.o parser.o debug_locks.o random32.o \
 	 bust_spinlocks.o hexdump.o kasprintf.o bitmap.o scatterlist.o \
 	 gcd.o lcm.o list_sort.o uuid.o iovec.o clz_ctz.o \
 	 bsearch.o find_last_bit.o find_next_bit.o llist.o memweight.o kfifo.o \
@@ -74,6 +74,7 @@ obj-$(CONFIG_CRC7)	+= crc7.o
 obj-$(CONFIG_LIBCRC32C)	+= libcrc32c.o
 obj-$(CONFIG_CRC8)	+= crc8.o
 obj-$(CONFIG_GENERIC_ALLOCATOR) += genalloc.o
+obj-$(CONFIG_HALF_MD4) += halfmd4.o
 
 obj-$(CONFIG_ZLIB_INFLATE) += zlib_inflate/
 obj-$(CONFIG_ZLIB_DEFLATE) += zlib_deflate/
Signature · 1 line
1.8.3.1