i2c-imx: Use the preferred form for passing a size of a struct
PATCH 1/2 i2c-imx: Use the preferred form for passing a size of a struct
From: Fabio Estevam <[email protected]>
According to Documentation/CodingStyle - Chapter 14:
"The preferred form for passing a size of a struct is the following:
p = kmalloc(sizeof(*p), ...);
The alternative form where struct name is spelled out hurts readability and introduces an opportunity for a bug when the pointer variable type is changed but the corresponding sizeof that is passed to a memory allocator is not."
So do it as recommeded.
--- drivers/i2c/busses/i2c-imx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/i2c/busses/i2c-imx.c +1 -2
@@ -673,8 +673,7 @@ static int i2c_imx_probe(struct platform_device *pdev)if (IS_ERR (base))return PTR_ERR (base); - i2c_imx =devm_kzalloc (&pdev->dev,sizeof (struct imx_i2c_struct ), -GFP_KERNEL ); + i2c_imx =devm_kzalloc (&pdev->dev,sizeof (*i2c_imx),GFP_KERNEL );if (!i2c_imx)return -ENOMEM ;
Signature · 1 line
1.9.1
A message that is not in the archive (sent off-list or not yet received): 1415328275-13228-1-git-send-email-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
PATCH 2/2 i2c-mxs: Use the preferred form for passing a size of a struct
From: Fabio Estevam <[email protected]>
According to Documentation/CodingStyle - Chapter 14:
"The preferred form for passing a size of a struct is the following:
p = kmalloc(sizeof(*p), ...);
The alternative form where struct name is spelled out hurts readability and introduces an opportunity for a bug when the pointer variable type is changed but the corresponding sizeof that is passed to a memory allocator is not."
So do it as recommeded.
--- drivers/i2c/busses/i2c-mxs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/i2c/busses/i2c-mxs.c +1 -1
@@ -811,7 +811,7 @@ static int mxs_i2c_probe(struct platform_device *pdev)struct resource *res;int err, irq; - i2c =devm_kzalloc (dev,sizeof (struct mxs_i2c_dev ),GFP_KERNEL ); + i2c =devm_kzalloc (dev,sizeof (*i2c),GFP_KERNEL );if (!i2c)return -ENOMEM ;
Signature · 1 line
1.9.1
Quoted 8 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
According to
Documentation/CodingStyle- Chapter 14:"The preferred form for passing a size of a struct is the following:
p = kmalloc(sizeof(*p), ...);
Quoted 7 lines
The alternative form where struct name is spelled out hurts readability and introduces an opportunity for a bug when the pointer variable type is changed but the corresponding sizeof that is passed to a memory allocator is not."
So do it as recommeded.
Signed-off-by Fabio Estevam <[email protected]>
Squashed the two and applied to for-next, thanks!