gcc: Fix intermittent failures during configure

PATCH In review Mark Hatle 2 participants 3 messages Nov 7, 2014 – Nov 8, 2014

lore

Share & tools

lore

Mark Hatle

author

2014-11-07 19:22 UTC #0 lore raw

PATCH 1/1 gcc: Fix intermittent failures during configure

If configure or any of the components it uses from the shared work directory change, do_configure may fail.

An existing do_preconfigure was created to handle these conditions, but a 'sed' operation was missed, and a call to gnu-configize was also missed.

Signed-off-by Mark Hatle <[email protected]>

---
 meta/recipes-devtools/gcc/gcc-common.inc         | 2 ++
 meta/recipes-devtools/gcc/gcc-cross-canadian.inc | 1 -
 meta/recipes-devtools/gcc/gcc-cross.inc          | 4 ----
 3 files changed, 2 insertions(+), 5 deletions(-)

meta/recipes-devtools/gcc/gcc-common.inc +2 -0

index 0bf26b5..9d41f65 100644
@@ -86,6 +86,8 @@ python do_preconfigure () {
     subprocess.check_output(cmd, stderr=subprocess.STDOUT, shell=True)
     # See 0044-gengtypes.patch, we need to regenerate this file
     bb.utils.remove(d.expand("${S}/gcc/gengtype-lex.c"))
+    cmd = d.expand("sed -i 's/BUILD_INFO=info/BUILD_INFO=/' ${S}/gcc/configure")
+    subprocess.check_output(cmd, stderr=subprocess.STDOUT, shell=True)
 }
 addtask do_preconfigure after do_patch before do_configure
 do_preconfigure[depends] += "gnu-config-native:do_populate_sysroot autoconf-native:do_populate_sysroot"

meta/recipes-devtools/gcc/gcc-cross-canadian.inc +0 -1

index 0b1f37b..ba001a9 100644
@@ -55,7 +55,6 @@ do_configure () {
 	export CPPFLAGS_FOR_TARGET="${TARGET_CPPFLAGS}"
 	export CXXFLAGS_FOR_TARGET="${TARGET_CXXFLAGS}"
 	export LDFLAGS_FOR_TARGET="${TARGET_LDFLAGS}"
-	(cd ${S} && gnu-configize) || die "failure running gnu-configize"
 	oe_runconf
 }

meta/recipes-devtools/gcc/gcc-cross.inc +0 -4

index f04a049..ce6860b 100644
@@ -41,10 +41,6 @@ def get_optimization(d):
 
 SELECTED_OPTIMIZATION := "${@get_optimization(d)}"
 
-do_configure_prepend () {
-	sed -i 's/BUILD_INFO=info/BUILD_INFO=/' ${S}/gcc/configure
-}
-
 do_compile () {
 	export CC="${BUILD_CC}"
 	export AR_FOR_TARGET="${TARGET_SYS}-ar"

Signature · 1 line

1.9.3

Burton, Ross

2014-11-08 00:18 UTC #1 lore raw

Hi Mark,

Quoted 7 lines · Mark Hatle

If configure or any of the components it uses from the shared work directory
change, do_configure may fail.
An existing do_preconfigure was created to handle these conditions, but a 'sed' operation was missed, and a call to gnu-configize was also missed.

This doesn't apply to master, can you rebase?

Cheers,
Ross

Mark Hatle

author

2014-11-08 02:09 UTC #2 lore raw

Quoted 5 lines · Ross

Hi Mark,
On 7 November 2014 19:21, Mark Hatle <[email protected] <mailto:[email protected]>> wrote:

Quoted 8 lines

If configure or any of the components it uses from the shared work directory change, do_configure may fail.
An existing do_preconfigure was created to handle these conditions, but a 'sed' operation was missed, and a call to gnu-configize was also missed.
This doesn't apply to master, can you rebase?

This was sent from oe-core master, previous commit:

dd93b3a950d063f4e3020362c636006f51fb5782

I have no idea why it wouldn't apply.

On the off chance the mailer ate it:

git.yoctoproject.org/poky-contrib mhatle/oe-core

--Mark

Quoted 2 lines

Cheers,
Ross