mx53loco: Change 'fdt_file' dynamically
PATCH 1/1 mx53loco: Change 'fdt_file' dynamically
From: Fabio Estevam <[email protected]>
Since kernel 3.15 there are two dtb's for the imx53-qsb board:
imx53-qsb.dtb - For the boards with DA9053 PMIC
imx53-qsrb.dtb - For the boards with MC34708 PMIC
Change the 'fdt_file' dynamically, so that the correct dtb can be used depending on the board variant.
--- board/freescale/mx53loco/mx53loco.c | 4 ++++ include/configs/mx53loco.h | 1 - 2 files changed, 4 insertions(+), 1 deletion(-)
board/freescale/mx53loco/mx53loco.c +4 -0
@@ -242,6 +242,8 @@ static int power_init(void)if (!p)return -ENODEV ; +setenv ("fdt_file" ,"imx53-qsb.dtb" ); +/* Set VDDA to 1.25V */ val =DA9052_BUCKCORE_BCOREEN |DA_BUCKCORE_VBCORE_1_250V ; ret =pmic_reg_write (p,DA9053_BUCKCORE_REG , val);
@@ -283,6 +285,8 @@ static int power_init(void)if (!p)return -ENODEV ; +setenv ("fdt_file" ,"imx53-qsrb.dtb" ); +/* Set VDDGP to 1.25V for 1GHz on SW1 */ pmic_reg_read (p,REG_SW_0 , &val); val = (val & ~SWx_VOLT_MASK_MC34708) | SWx_1_250V_MC34708;
include/configs/mx53loco.h +0 -1
@@ -107,7 +107,6 @@#define CONFIG_EXTRA_ENV_SETTINGS \ "script=boot.scr\0" \ "image=zImage\0" \ - "fdt_file=imx53-qsb.dtb\0" \ "fdt_addr=0x71000000\0" \ "boot_fdt=try\0" \ "ip_dyn=yes\0" \
Signature · 1 line
1.9.1
PATCH 1/1 mx53loco: Change 'fdt_file' dynamically
Quoted 11 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
Since kernel 3.15 there are two dtb's for the imx53-qsb board:
imx53-qsb.dtb - For the boards with DA9053 PMIC
imx53-qsrb.dtb - For the boards with MC34708 PMICChange the '
fdt_file' dynamically, so that the correct dtb can be used depending on the board variant.Signed-off-by Fabio Estevam <[email protected]>
Signature · 3 lines
Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
PATCH 1/1 mx53loco: Change 'fdt_file' dynamically
In reply to Fabio EstevamHi Fabio,
Quoted 21 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
Since kernel 3.15 there are two dtb's for the imx53-qsb board:
imx53-qsb.dtb - For the boards with DA9053 PMIC
imx53-qsrb.dtb - For the boards with MC34708 PMICChange the '
fdt_file' dynamically, so that the correct dtb can be used depending on the board variant.Signed-off-by Fabio Estevam <[email protected]>--- board/freescale/mx53loco/mx53loco.c | 4 ++++ include/configs/mx53loco.h | 1 - 2 files changed, 4 insertions(+), 1 deletion(-)board/freescale/mx53loco/mx53loco.c +0
-0
board/freescale/mx53loco/mx53loco.c static int power_init(void) · line 246
Quoted 5 lines
board/freescale/mx53loco/mx53loco.c +2
-0@@ -242,6 +242,8 @@ static int power_init(void)if (!p)return -ENODEV ; +setenv ("fdt_file" ,"imx53-qsb.dtb" ); +
Generally, I do not find a good idea to overwrite the environment in code. A user (I mean, a developer) becomes crazy if the environment he has previously set with "setenv" and "saveenv" has no worth, because some part of code has overwritten. Let's think to a developer working with kernel and not with U-Boot, and he has several DTB, depending on what he want to do.
Anyway, I understand that this helps for a ready-to-use board. I won't NACK the patch, and you as maintainer of the board are in the best position to decide, but I want only to ask you what do you think in such as a case before applying.
Thanks,
Stefano
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH 1/1 mx53loco: Change 'fdt_file' dynamically
Hi Stefano,
Quoted 6 lines · Stefano Babic
Generally, I do not find a good idea to overwrite the environment in code. A user (I mean, a developer) becomes crazy if the environment he has previously set with "setenv" and "saveenv" has no worth, because some part of code has overwritten. Let's think to a developer working with kernel and not with U-Boot, and he has several DTB, depending on what he want to do.
You bring a good point and I also agree that in general we should avoid 'setenv' inside the code.
Quoted 4 lines
Anyway, I understand that this helps for a ready-to-use board. I won't NACK the patch, and you as maintainer of the board are in the best position to decide, but I want only to ask you what do you think in such as a case before applying.
Yes, the idea here was that U-boot could retrieve the correct dtb automatically for the two board revisions and provide a better user experience.
Thanks,
Fabio Estevam
PATCH 1/1 mx53loco: Change 'fdt_file' dynamically
In reply to Fabio EstevamQuoted 4 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
Since kernel 3.15 there are two dtb's for the imx53-qsb board:
Quoted 8 lines
imx53-qsb.dtb - For the boards with DA9053 PMIC
imx53-qsrb.dtb - For the boards with MC34708 PMICChange the '
fdt_file' dynamically, so that the correct dtb can be used depending on the board variant.Signed-off-by Fabio Estevam <[email protected]>---
Applied to u-boot-imx, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================