drm/i915: remove the unnecessary block around display.hpd_irq_setup
Subsystems (2)
PATCH 1/1 drm/i915: remove the unnecessary block around display.hpd_irq_setup
The block was added for spin_lock_irqsave flags, but since the locking was converted to spin_lock_irq variant, the block is no longer needed.
--- drivers/gpu/drm/i915/i915_drv.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-)
drivers/gpu/drm/i915/i915_drv.c +4 -6
@@ -703,12 +703,10 @@ static int i915_drm_resume(struct drm_device *dev)intel_modeset_init_hw (dev); - { -spin_lock_irq (&dev_priv->irq_lock); -if (dev_priv->display.hpd_irq_setup) - dev_priv->display.hpd_irq_setup (dev); -spin_unlock_irq (&dev_priv->irq_lock); - } +spin_lock_irq (&dev_priv->irq_lock); +if (dev_priv->display.hpd_irq_setup) + dev_priv->display.hpd_irq_setup (dev); +spin_unlock_irq (&dev_priv->irq_lock);intel_dp_mst_resume (dev);drm_modeset_lock_all (dev);
Signature · 6 lines
2.1.1 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Daniel Vetter
AppliedQuoted 4 lines · Jani Nikula
The block was added for
spin_lock_irqsaveflags, but since the locking was converted tospin_lock_irqvariant, the block is no longer needed.Signed-off-by Jani Nikula <[email protected]>
Queued for -next, thanks for the patch.
-Daniel
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH] drm/i915: remove the unnecessary block around
In reply to Jani Nikula-------------------------------------Summary-------------------------------------
Platform: baseline_drm_intel_nightly_pass_rate->patch_applied_pass_rate
BYT: pass/total=291/291->290/291
PNV: pass/total=356/356->356/356
ILK: pass/total=372/372->371/372
IVB: pass/total=545/546->545/546
SNB: pass/total=380/380->378/380
HSW: pass/total=579/579->579/579
BDW: pass/total=434/435->434/435
-------------------------------------Detailed-------------------------------------test_platform: test_suite, test_case, result_with_drm_intel_nightly(count, machine_id...)...->result_with_patch_applied(count, machine_id)...
BYT: Intel_gpu_tools, igt_kms_setmode_invalid-clone-single-crtc, TIMEOUT(6, M36M31)PASS(1, M31) -> TIMEOUT(1, M36)PASS(3, M36)
ILK: Intel_gpu_tools, igt_kms_setmode_invalid-clone-single-crtc, FAIL(2, M26)DMESG_FAIL(1, M26)TIMEOUT(6, M37M6)PASS(1, M26) -> TIMEOUT(1, M6)PASS(3, M6)
IVB: Intel_gpu_tools, igt_gem_bad_reloc_negative-reloc, NSPT(3, M21M34)PASS(4, M34M21) -> NSPT(1, M21)PASS(3, M21)
IVB: Intel_gpu_tools, igt_kms_setmode_invalid-clone-single-crtc, TIMEOUT(6, M34M21)PASS(1, M21) -> TIMEOUT(1, M21)PASS(3, M21)
SNB: Intel_gpu_tools, igt_kms_mmio_vs_cs_flip_setcrtc_vs_cs_flip, PASS(4, M35M22) -> DMESG_WARN(1, M22)PASS(3, M22)
SNB: Intel_gpu_tools, igt_kms_setmode_invalid-clone-single-crtc, TIMEOUT(6, M35M22)PASS(1, M35) -> TIMEOUT(1, M22)PASS(3, M22)
BDW: Intel_gpu_tools, igt_gem_reset_stats_ban-bsd, DMESG_WARN(1, M28)PASS(6, M42M30) -> PASS(4, M30)
BDW: Intel_gpu_tools, igt_kms_setmode_invalid-clone-single-crtc, TIMEOUT(6, M42M30)PASS(1, M28) -> TIMEOUT(1, M30)PASS(3, M30)
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH] drm/i915: remove the unnecessary block around
Quoted 12 lines · On Wed, Nov 12, 2014 at 12:03:26PM -0800, [email protected] wrote:
-------------------------------------Summary-------------------------------------
Platform:baseline_drm_intel_nightly_pass_rate->patch_applied_pass_rate
BYT: pass/total=291/291->290/291
PNV: pass/total=356/356->356/356
ILK: pass/total=372/372->371/372
IVB: pass/total=545/546->545/546
SNB: pass/total=380/380->378/380
HSW: pass/total=579/579->579/579
BDW: pass/total=434/435->434/435
-------------------------------------Detailed-------------------------------------test_platform:test_suite,test_case,result_with_drm_intel_nightly(count, machine_id...)...->result_with_patch_applied(count,machine_id)...
Quoted 8 lines
BYT:
Intel_gpu_tools, igt_kms_setmode_invalid-clone-single-crtc,TIMEOUT(6, M36M31)PASS(1, M31)->TIMEOUT(1, M36)PASS(3, M36)
ILK:Intel_gpu_tools, igt_kms_setmode_invalid-clone-single-crtc,FAIL(2, M26)DMESG_FAIL(1, M26)TIMEOUT(6, M37M6)PASS(1, M26)->TIMEOUT(1, M6)PASS(3, M6)
IVB:Intel_gpu_tools, igt_gem_bad_reloc_negative-reloc,NSPT(3, M21M34)PASS(4, M34M21)->NSPT(1, M21)PASS(3, M21)
IVB:Intel_gpu_tools, igt_kms_setmode_invalid-clone-single-crtc,TIMEOUT(6, M34M21)PASS(1, M21)->TIMEOUT(1, M21)PASS(3, M21)
SNB:Intel_gpu_tools,igt_kms_mmio_vs_cs_flip_setcrtc_vs_cs_flip,PASS(4, M35M22)->DMESG_WARN(1, M22)PASS(3, M22)
SNB:Intel_gpu_tools, igt_kms_setmode_invalid-clone-single-crtc,TIMEOUT(6, M35M22)PASS(1, M35)->TIMEOUT(1, M22)PASS(3, M22)
BDW:Intel_gpu_tools, igt_gem_reset_stats_ban-bsd,DMESG_WARN(1, M28)PASS(6, M42M30)->PASS(4, M30)
BDW:Intel_gpu_tools, igt_kms_setmode_invalid-clone-single-crtc,TIMEOUT(6, M42M30)PASS(1, M28)->TIMEOUT(1, M30)PASS(3, M30)
Damien already raised this in another patch, but this one here is another case where the patch only changes whitespace really, but somehow PRTS detects lots of changes. All tests really look funky and I have no idea what exaclty might cause these test instabilities.
-Daniel
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx