Skip to contentSkip to conversation

cronie: Upgrade to 1.4.12

PATCH In review Alejandro Hernandez 2 participants 2 messages Nov 12, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cronie: Upgrade to 1.4.12

---
 meta/recipes-extended/cronie/cronie_1.4.11.bb | 85 ---------------------------
 meta/recipes-extended/cronie/cronie_1.4.12.bb | 84 ++++++++++++++++++++++++++
 2 files changed, 84 insertions(+), 85 deletions(-)
 delete mode 100644 meta/recipes-extended/cronie/cronie_1.4.11.bb
 create mode 100644 meta/recipes-extended/cronie/cronie_1.4.12.bb
meta/recipes-extended/cronie/cronie_1.4.11.bb deleted +0 -85
deleted file mode 100644
index 02234f6..0000000
@@ -1,85 +0,0 @@
-SUMMARY = "Cron daemon for executing programs at set times"
-DESCRIPTION = "Cronie contains the standard UNIX daemon crond that runs \
-specified programs at scheduled times and related tools. It is based on the \
-original cron and has security and configuration enhancements like the \
-ability to use pam and SELinux."
-HOMEPAGE = "https://fedorahosted.org/cronie/"
-BUGTRACKER = "[email protected]"
-
-# Internet Systems Consortium License
-LICENSE = "ISC & BSD"
-LIC_FILES_CHKSUM = "file://COPYING;md5=963ea0772a2adbdcd607a9b2ec320c11 \
-                    file://src/cron.c;endline=20;md5=b425c334265026177128353a142633b4 \
-                    file://src/popen.c;beginline=3;endline=31;md5=edd50742d8def712e9472dba353668a9"
-
-SECTION = "utils"
-
-
-SRC_URI = "https://fedorahosted.org/releases/c/r/cronie/cronie-${PV}.tar.gz \
-           file://fix-out-of-tree-build.patch \
-           file://crond.init \
-           file://crontab \
-           file://crond.service \
-           ${@bb.utils.contains('DISTRO_FEATURES', 'pam', '${PAM_SRC_URI}', '', d)}"
-
-PAM_SRC_URI = "file://crond_pam_config.patch"
-PAM_DEPS = "libpam libpam-runtime pam-plugin-access pam-plugin-loginuid"
-
-SRC_URI[md5sum] = "2ba645cf54de17f138ef70312843862f"
-SRC_URI[sha256sum] = "fd08084cedddbb42499f80ddb7f2158195c3555c2ff40ee11d4ece2f9864d7be"
-
-inherit autotools update-rc.d useradd systemd
-
-
-PACKAGECONFIG ?= "${@bb.utils.contains('DISTRO_FEATURES', 'pam', 'pam', '', d)}"
-
-PACKAGECONFIG[audit] = "--with-audit,--without-audit,audit,"
-PACKAGECONFIG[pam] = "--with-pam,--without-pam,libpam,${PAM_DEPS}"
-
-
-INITSCRIPT_NAME = "crond"
-INITSCRIPT_PARAMS = "start 90 2 3 4 5 . stop 60 0 1 6 ."
-
-USERADD_PACKAGES = "${PN}"
-GROUPADD_PARAM_${PN} = "--system crontab"
-
-SYSTEMD_SERVICE_${PN} = "crond.service"
-
-do_install_append () {
-	install -d ${D}${sysconfdir}/sysconfig/
-	install -d ${D}${sysconfdir}/init.d/
-	install -m 0644 ${S}/crond.sysconfig ${D}${sysconfdir}/sysconfig/crond
-	install -m 0755 ${WORKDIR}/crond.init ${D}${sysconfdir}/init.d/crond
-
-	# install systemd unit files
-	install -d ${D}${systemd_unitdir}/system
-	install -m 0644 ${WORKDIR}/crond.service ${D}${systemd_unitdir}/system
-	sed -i -e 's,@BASE_BINDIR@,${base_bindir},g' \
-	       -e 's,@SBINDIR@,${sbindir},g' \
-	       ${D}${systemd_unitdir}/system/crond.service
-
-	# below are necessary for a complete cron environment
-	install -d ${D}${localstatedir}/spool/cron
-	install -m 0755 ${WORKDIR}/crontab ${D}${sysconfdir}/
-	mkdir -p ${D}${sysconfdir}/cron.d
-	mkdir -p ${D}${sysconfdir}/cron.hourly
-	mkdir -p ${D}${sysconfdir}/cron.daily
-	mkdir -p ${D}${sysconfdir}/cron.weekly
-	mkdir -p ${D}${sysconfdir}/cron.monthly
-	touch ${D}${sysconfdir}/cron.deny
-	
-	# below setting is necessary to allow normal user using crontab
-
-	# setgid for crontab binary
-	chown root:crontab ${D}${bindir}/crontab
-	chmod 2755 ${D}${bindir}/crontab
-
-	# allow 'crontab' group write to /var/spool/cron
-	chown root:crontab ${D}${localstatedir}/spool/cron
-	chmod 770 ${D}${localstatedir}/spool/cron
-
-	chmod 600 ${D}${sysconfdir}/crontab
-}
-
-FILES_${PN} += "${sysconfdir}/cron*"
-
meta/recipes-extended/cronie/cronie_1.4.12.bb new file +84 -0

84 lines not on this page · raw message

Signature · 1 line
1.9.1
#1 lore raw
Quoted 7 lines · Alejandro Hernandez
---
 meta/recipes-extended/cronie/cronie_1.4.11.bb | 85
---------------------------
 meta/recipes-extended/cronie/cronie_1.4.12.bb | 84

++++++++++++++++++++++++++

Please pass -M to git-send-email if you're sending patches without using create-pull-request so that the rename is spotted and the diff is much easier to read. I applied and re-generated the diff:

--- a/meta/recipes-extended/cronie/cronie_1.4.11.bb

Review BUGTRACKER = "[email protected]" · line 12

Quoted 8 lines

+++ b/meta/recipes-extended/cronie/cronie_1.4.12.bb

(quoted diff) +1 -1
@@ -8,7 +8,7 @@ BUGTRACKER = "[email protected]"
 # Internet Systems Consortium License
 LICENSE = "ISC & BSD"
-LIC_FILES_CHKSUM = "file://COPYING;md5=963ea0772a2adbdcd607a9b2ec320c11 \
+LIC_FILES_CHKSUM = "file://COPYING;md5=dd2a592170760e1386c769e1043b3722 \
 
 file://src/cron.c;endline=20;md5=b425c334265026177128353a142633b4 \

Always say why the license checksum was change in the commit message. Often it's just copyright dates changing or reformatting, but we need to know that it's not that the license terms were changed.

Review BUGTRACKER = "[email protected]"

Quoted 4 lines
(quoted diff) +0 -1
 SRC_URI = "
 https://fedorahosted.org/releases/c/r/cronie/cronie-${PV}.tar.gz \
-           file://fix-out-of-tree-build.patch \

If a patch is removed explain why (upstream merged it in this case, I hope), and remember to remove the file in the commit.

Ross