drm/i915: Fix comments about CHV snoop behaviour
Subsystems (2)
PATCH 1/1 drm/i915: Fix comments about CHV snoop behaviour
From: Ville Syrjälä <[email protected]>
Replace the misinformed notes about CHV snoop behaviour with something that's hopefully closer to reality.
--- drivers/gpu/drm/i915/i915_gem_gtt.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/i915_gem_gtt.c +11 -3
@@ -1953,9 +1953,17 @@ static void chv_setup_private_ppat(struct drm_i915_private *dev_priv)* Only the snoop bit has meaning for CHV, the rest is * ignored. * -* Note that the harware enforces snooping for all page -* table accesses. The snoop bit is actually ignored for -* PDEs. +* The hardware will never snoop for certain types of accesses: +* - CPU GTT (GMADR->GGTT->no snoop->memory) +* - PPGTT page tables +* - some other special cycles +* +* As with BDW, we also need to consider the following for GT accesses: +* "For GGTT, there is NO pat_sel[2:0] from the entry, +* so RTL will always use the value corresponding to +* pat_sel = 000". +* Which means we must set the snoop bit in PAT entry 0 +* in order to keep the global status page working. */ pat =GEN8_PPAT (0 ,CHV_PPAT_SNOOP ) | GEN8_PPAT(1, 0) |
Signature · 6 lines
2.0.4 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Daniel Vetter
AppliedQuoted 6 lines · On Fri, Nov 14, 2014 at 09:02:44PM +0200, [email protected] wrote:
From: Ville Syrjälä <[email protected]>
Replace the misinformed notes about CHV snoop behaviour with something that's hopefully closer to reality.
Signed-off-by Ville Syrjälä <[email protected]>
Queued for -next, thanks for the patch.
-Daniel
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
-------------------------------------Summary-------------------------------------
Platform: baseline_drm_intel_nightly_pass_rate->patch_applied_pass_rate
BYT: pass/total=290/291->290/291
PNV: pass/total=352/356->356/356
ILK: pass/total=371/372->371/372
IVB: pass/total=545/546->544/546
SNB: pass/total=424/425->424/425
HSW: pass/total=579/579->579/579
BDW: pass/total=434/435->434/435
-------------------------------------Detailed-------------------------------------test_platform: test_suite, test_case, result_with_drm_intel_nightly(count, machine_id...)...->result_with_patch_applied(count, machine_id)...
PNV: Intel_gpu_tools, igt_gen3_mixed_blits, DMESG_WARN(1, M23) -> PASS(4, M23)
PNV: Intel_gpu_tools, igt_gen3_render_mixed_blits, CRASH(1, M23) -> PASS(1, M23)
PNV: Intel_gpu_tools, igt_gen3_render_tiledx_blits, CRASH(1, M23) -> PASS(1, M23)
PNV: Intel_gpu_tools, igt_gen3_render_tiledy_blits, CRASH(1, M23) -> PASS(1, M23)
IVB: Intel_gpu_tools, igt_kms_cursor_crc_cursor-128x128-random, PASS(1, M4) -> DMESG_WARN(1, M21)PASS(3, M21)
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 16 lines · On Sat, Nov 15, 2014 at 01:22:46AM -0800, [email protected] wrote:
-------------------------------------Summary-------------------------------------
Platform:baseline_drm_intel_nightly_pass_rate->patch_applied_pass_rate
BYT: pass/total=290/291->290/291
PNV: pass/total=352/356->356/356
ILK: pass/total=371/372->371/372
IVB: pass/total=545/546->544/546
SNB: pass/total=424/425->424/425
HSW: pass/total=579/579->579/579
BDW: pass/total=434/435->434/435
-------------------------------------Detailed-------------------------------------test_platform:test_suite,test_case,result_with_drm_intel_nightly(count, machine_id...)...->result_with_patch_applied(count,machine_id)...
PNV:Intel_gpu_tools,igt_gen3_mixed_blits,DMESG_WARN(1, M23)->PASS(4, M23)
PNV:Intel_gpu_tools,igt_gen3_render_mixed_blits,CRASH(1, M23)->PASS(1, M23)
PNV:Intel_gpu_tools,igt_gen3_render_tiledx_blits,CRASH(1, M23)->PASS(1, M23)
PNV:Intel_gpu_tools,igt_gen3_render_tiledy_blits,CRASH(1, M23)->PASS(1, M23)
These tests on pnv seem to be unstable and flip-flop between crash, dmesg warn and pass. Is the machine dying perhaps or should we have some additional filtering in -nightly results?
-Daniel
Quoted 5 lines
IVB:
Intel_gpu_tools, igt_kms_cursor_crc_cursor-128x128-random,PASS(1, M4)->DMESG_WARN(1, M21)PASS(3, M21)
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx