Skip to contentSkip to conversation

drivers: staging: lustre: lnet: api-nc.c: Fix Style Warnings Remove an unecessary return statement in a void function. Remove an unecessary space between a function name and the parentheses.

PATCH In review Thomas Wood 3 participants 5 messages Nov 17, 2014 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers: staging: lustre: lnet: api-nc.c: Fix Style Warnings Remove an unecessary return statement in a void function. Remove an unecessary space between a function name and the parentheses.

---
I hope this hasn't been duplicated...

 drivers/staging/lustre/lnet/lnet/api-ni.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/lustre/lnet/lnet/api-ni.c +1 -2
index 5e6e4e2..faceb95 100644
@@ -277,7 +277,7 @@ lnet_find_lnd_by_type(int type)
 	struct list_head	 *tmp;
 
 	/* holding lnd mutex */
-	list_for_each (tmp, &the_lnet.ln_lnds) {
+	list_for_each(tmp, &the_lnet.ln_lnds) {
 		lnd = list_entry(tmp, lnd_t, lnd_list);
 
 		if ((int)lnd->lnd_type == type)
@@ -1645,7 +1645,6 @@ lnet_destroy_ping_info(void)
 		    offsetof(lnet_ping_info_t,
 			     pi_ni[the_lnet.ln_ping_info->pi_nnis]));
 	the_lnet.ln_ping_info = NULL;
-	return;
 }
 
 int
Signature · 1 line
1.7.10.4
#1 lore raw

You have to leave a blank line after the subject or everything gets put into the subject.

regards,
dan carpenter

#2 lore raw

PATCH 1/1 drivers: staging: lustre: lnet: api-nc.c: Fix Style Warnings

Fixed Subject line containing the entire patch description.

Quoted 1 line

8----------------------------------------------------------------------------8<

Remove an unecessary return statement in a void function. Remove an unecessary space between a function name and the parentheses.

---
 drivers/staging/lustre/lnet/lnet/api-ni.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/lustre/lnet/lnet/api-ni.c +1 -2
index 5e6e4e2..faceb95 100644
@@ -277,7 +277,7 @@ lnet_find_lnd_by_type(int type)
 	struct list_head	 *tmp;
 
 	/* holding lnd mutex */
-	list_for_each (tmp, &the_lnet.ln_lnds) {
+	list_for_each(tmp, &the_lnet.ln_lnds) {
 		lnd = list_entry(tmp, lnd_t, lnd_list);
 
 		if ((int)lnd->lnd_type == type)
@@ -1645,7 +1645,6 @@ lnet_destroy_ping_info(void)
 		    offsetof(lnet_ping_info_t,
 			     pi_ni[the_lnet.ln_ping_info->pi_nnis]));
 	the_lnet.ln_ping_info = NULL;
-	return;
 }
 
 int
Signature · 1 line
1.7.10.4
#3 lore raw

Re: [PATCH] drivers: staging: lustre: lnet: api-nc.c: Fix Style Warnings

Quoted 2 lines · Thomas Wood

Fixed Subject line containing the entire patch description.

Quoted 1 line

8----------------------------------------------------------------------------8<

Ick, what is that here? Please put that below the --- line, otherwise I have to hand-edit the patch in order to apply this :(

Please try again.

thanks,

greg k-h

#4 lore raw

PATCH v3 1/1 drivers: staging: lustre: lnet: api-nc.c: Fix Style Warnings

Remove an unecessary return statement in a void function. Remove an unecessary space between a function name and the parentheses.

---
Fixed the subject line containing the entire description. Removed an attempt at scissor lines.

 drivers/staging/lustre/lnet/lnet/api-ni.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/lustre/lnet/lnet/api-ni.c +1 -2
index 5e6e4e2..faceb95 100644
@@ -277,7 +277,7 @@ lnet_find_lnd_by_type(int type)
 	struct list_head	 *tmp;
 
 	/* holding lnd mutex */
-	list_for_each (tmp, &the_lnet.ln_lnds) {
+	list_for_each(tmp, &the_lnet.ln_lnds) {
 		lnd = list_entry(tmp, lnd_t, lnd_list);
 
 		if ((int)lnd->lnd_type == type)
@@ -1645,7 +1645,6 @@ lnet_destroy_ping_info(void)
 		    offsetof(lnet_ping_info_t,
 			     pi_ni[the_lnet.ln_ping_info->pi_nnis]));
 	the_lnet.ln_ping_info = NULL;
-	return;
 }
 
 int
Signature · 1 line
1.7.10.4