Skip to contentSkip to conversation

mmc: mxs-mmc: Register the irq with the device name

PATCH Applied Fabio Estevam 2 participants 2 messages Nov 18, 2014 – Nov 19, 2014

Subsystems (2)
Arm i.MX and Layerscape MMC, SD and SDIO
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 mmc: mxs-mmc: Register the irq with the device name

From: Fabio Estevam <[email protected]>

Instead of registering the irq name with the driver's name, it's better to pass the device name so that we have a more explicit indication as to what mmc instance the irq is related:

$ cat /proc/interrupts 
           CPU0       
...
 26:          6         -  96  80010000.ssp
Signed-off-by Fabio Estevam <[email protected]>
---
 drivers/mmc/host/mxs-mmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/mxs-mmc.c +1 -1
index cd74e51..339059a 100644
@@ -660,7 +660,7 @@ static int mxs_mmc_probe(struct platform_device *pdev)
 	platform_set_drvdata(pdev, mmc);
 
 	ret = devm_request_irq(&pdev->dev, irq_err, mxs_mmc_irq_handler, 0,
-			       DRIVER_NAME, host);
+			       dev_name(&pdev->dev), host);
 	if (ret)
 		goto out_free_dma;
Signature · 1 line
1.9.1
Applied
#1 lore raw
Quoted 6 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Instead of registering the irq name with the driver's name, it's better to pass the device name so that we have a more explicit indication as to what mmc instance the irq is related:

Quoted 6 lines
$ cat /proc/interrupts
           CPU0
...
 26:          6         -  96  80010000.ssp
Signed-off-by Fabio Estevam <[email protected]>

Thanks! Applied for next.

Kind regards
Uffe

Quoted 20 lines
---
 drivers/mmc/host/mxs-mmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/mxs-mmc.c +1 -2
index cd74e51..339059a 100644
@@ -660,7 +660,7 @@ static int mxs_mmc_probe(struct platform_device *pdev)
        platform_set_drvdata(pdev, mmc);
 
        ret = devm_request_irq(&pdev->dev, irq_err, mxs_mmc_irq_handler, 0,
-                              DRIVER_NAME, host);
+                              dev_name(&pdev->dev), host);
        if (ret)
                goto out_free_dma;
 
--

1.9.1