Skip to contentSkip to conversation

scripts/Makefile.lib: Make __dtb_dt_begin align on a 4 byte boundary

PATCH New Bin Meng 2 participants 3 messages Nov 20, 2014 Kbuild

lore
Share & tools
lore

Bin Meng

author
#0 lore raw

PATCH 1/1 scripts/Makefile.lib: Make __dtb_dt_begin align on a 4 byte boundary

With CONFIG_OF_EMBED, __dtb_dt_begin must be aligned on a 4 byte boundary otherwise fdtdec_prepare_fdt() will fail.

---
 scripts/Makefile.lib | 1 +
 1 file changed, 1 insertion(+)
scripts/Makefile.lib +1 -0
index 9d1383a..aead250 100644
@@ -260,6 +260,7 @@ quiet_cmd_dt_S_dtb= DTB     $@
 cmd_dt_S_dtb=						\
 (							\
 	echo '.section .dtb.init.rodata,"a"';		\
+	echo '.p2align 2';				\
 	echo '.global __dtb_$(*F)_begin';		\
 	echo '__dtb_$(*F)_begin:';			\
 	echo '.incbin "$<" ';				\
Signature · 1 line
1.8.2.1
#1 lore raw

PATCH 1/1 scripts/Makefile.lib: Make __dtb_dt_begin align on a 4 byte boundary

Hi Bin,

I think this issue is covered by Simon's patch:
http://patchwork.ozlabs.org/patch/411062/

Quoted 27 lines · On Thu, 20 Nov 2014 17:45:06 +0800 Bin Meng <[email protected]> wrote:

With CONFIG_OF_EMBED, __dtb_dt_begin must be aligned on a 4 byte boundary otherwise fdtdec_prepare_fdt() will fail.

---
 scripts/Makefile.lib | 1 +
 1 file changed, 1 insertion(+)
scripts/Makefile.lib +1 -0
index 9d1383a..aead250 100644
@@ -260,6 +260,7 @@ quiet_cmd_dt_S_dtb= DTB     $@
 cmd_dt_S_dtb=						\
 (							\
 	echo '.section .dtb.init.rodata,"a"';		\
+	echo '.p2align 2';				\
 	echo '.global __dtb_$(*F)_begin';		\
 	echo '__dtb_$(*F)_begin:';			\
 	echo '.incbin "$<" ';				\
Signature · 6 lines
1.8.2.1

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
author
#2 lore raw

PATCH 1/1 scripts/Makefile.lib: Make __dtb_dt_begin align on a 4 byte boundary

Hi Masahiro,

Quoted 5 lines · Masahiro Yamada

Hi Bin,

I think this issue is covered by Simon's patch:
http://patchwork.ozlabs.org/patch/411062/

Thanks for the info. I did not notice that patch before.

Regards,
Bin