Skip to contentSkip to conversation

perf symbols: Consider the syms_ss in dso__load_sym

PATCH New Steve Capper 1 participant 1 message Nov 21, 2014 perf events

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 perf symbols: Consider the syms_ss in dso__load_sym

In dso__load_sym we only try to load the .debug_frame section from the runtime image. For distros, the debug symbols are generally in a separate file.

As a result, running perf report on arm64 can give errors such as:
"$file with build id $id not found, continuing without symbols"

Even when the debug symbols have been correctly installed (and loaded by perf).

This patch adds logic to dso__load_sym to query syms_ss for the .debug_frame section if it can't be found in the elf file pointed to by runtime_ss.

---
This patch is against 3.18-rc5.

---
 tools/perf/util/symbol-elf.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
tools/perf/util/symbol-elf.c +5 -2
index 1e23a5b..1336392 100644
@@ -830,8 +830,11 @@ int dso__load_sym(struct dso *dso, struct map *map,
 			continue;
 
 		sec = elf_getscn(runtime_ss->elf, sym.st_shndx);
-		if (!sec)
-			goto out_elf_end;
+		if (!sec) {
+			sec = elf_getscn(syms_ss->elf, sym.st_shndx);
+			if (!sec)
+				goto out_elf_end;
+		}
 
 		gelf_getshdr(sec, &shdr);
 
Signature · 1 line
1.9.3