Skip to contentSkip to conversation

Fix: Live tracing does not honor live timer after first tracefile with tracefile rotation

PATCH Jérémie Galarneau 1 participant 1 message Nov 27, 2014 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

Merged all the way to 2.4, thanks!

Jérémie

Quoted 33 lines · Mathieu Desnoyers

When we pass to the 2nd sub-file (or following sub-files) of a stream in relayd, the live timer has no visible effect from a live reader perspective, and then everything is flushed when we reach the following sub-file.

This is caused by the reset of stream->total_index_received after each tracefile rotation. It should keep on incrementing to match what is expected by check in check_index_status():

(rstream->total_index_received <= vstream->last_sent_index)

Fixes #863

---
 src/bin/lttng-relayd/main.c | 1 -
 1 file changed, 1 deletion(-)
src/bin/lttng-relayd/main.c +0 -2
index 00b8735..03ea108 100644
@@ -2333,7 +2333,6 @@ int relay_process_data(struct relay_connection *conn)
                                stream->tracefile_size, stream->tracefile_count,
                                relayd_uid, relayd_gid, stream->fd,
                                &(stream->tracefile_count_current), &stream->fd);
-               stream->total_index_received = 0;
                pthread_mutex_unlock(&stream->viewer_stream_rotation_lock);
                if (ret < 0) {
                        ERR("Rotating stream output file");
--

2.1.1

Signature · 8 lines
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com

_______________________________________________
lttng-dev mailing list
[email protected]
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev