Skip to contentSkip to conversation

Drivers:staging:speakup: Fixed checkpatch warning

PATCH NAK Athira Lekshmi C V 2 participants 2 messages Nov 26, 2014 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Drivers:staging:speakup: Fixed checkpatch warning

Fixed the checkpatch warning:
WARNING: simple_strtoul is obsolete, use kstrtoul instead

---
 drivers/staging/speakup/varhandlers.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/speakup/varhandlers.c +1 -1
index 1b0d1c0..00fd67e 100644
@@ -324,7 +324,7 @@ char *spk_s2uchar(char *start, char *dest)
 {
 	int val = 0;
 
-	val = simple_strtoul(skip_spaces(start), &start, 10);
+	val = kstrtoul(skip_spaces(start), &start, 10);
 	if (*start == ',')
 		start++;
 	*dest = (u_char)val;
Signature · 1 line
1.7.9.5
#1 lore raw
Quoted 13 lines · Athira Lekshmi C V

Fixed the checkpatch warning:
WARNING: simple_strtoul is obsolete, use kstrtoul instead

---
 drivers/staging/speakup/varhandlers.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/speakup/varhandlers.c +0 -0
index 1b0d1c0..00fd67e 100644

drivers/staging/speakup/varhandlers.c char *spk_s2uchar(char *start, char *dest) · line 330

Quoted 8 lines
drivers/staging/speakup/varhandlers.c +1 -1
@@ -324,7 +324,7 @@ char *spk_s2uchar(char *start, char *dest)
 {
        int val = 0;
 
-       val = simple_strtoul(skip_spaces(start), &start, 10);
+       val = kstrtoul(skip_spaces(start), &start, 10);
        if (*start == ',')
                start++;
        *dest = (u_char)val;

NACK.

Please test your patch or at least read the function signature kstrtoul().

Signature · 2 lines
Thanks,
//richard