Skip to contentSkip to conversation

drm/msm/hdmi: rework HDMI IRQ hanlder

PATCH In review Jilai Wang 1 participant 1 message Nov 26, 2014

Subsystems (3)
DRM drivers Arm Qualcomm mailing list DRM driver for Qualcomm display hardware
lore
Share & tools
lore

Jilai Wang

author
#0 lore raw

PATCH 3/4 drm/msm/hdmi: rework HDMI IRQ hanlder

Disable the HPD interrupt when acking it, to avoid spurious interrupt.

Change-Id Icb64d7fa813380c7ffa3047058503ebab13ff4c4
Signed-off-by Jilai Wang <[email protected]>
---
 drivers/gpu/drm/msm/hdmi/hdmi_connector.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/msm/hdmi/hdmi_connector.c +4 -4
index caa1301..c458348 100644
@@ -251,11 +251,11 @@ void hdmi_connector_irq(struct drm_connector *connector)
 			(hpd_int_status & HDMI_HPD_INT_STATUS_INT)) {
 		bool detected = !!(hpd_int_status & HDMI_HPD_INT_STATUS_CABLE_DETECTED);
 
-		DBG("status=%04x, ctrl=%04x", hpd_int_status, hpd_int_ctrl);
-
-		/* ack the irq: */
+		/* ack & disable (temporarily) HPD events: */
 		hdmi_write(hdmi, REG_HDMI_HPD_INT_CTRL,
-				hpd_int_ctrl | HDMI_HPD_INT_CTRL_INT_ACK);
+			HDMI_HPD_INT_CTRL_INT_ACK);
+
+		DBG("status=%04x, ctrl=%04x", hpd_int_status, hpd_int_ctrl);
 
 		/* detect disconnect if we are connected or visa versa: */
 		hpd_int_ctrl = HDMI_HPD_INT_CTRL_INT_EN;
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project