wd719x: remove dma_cache_sync call

PATCH New Ondrej Zary 1 participant 1 message Nov 26, 2014 SCSI

lore

Share & tools

lore

Ondrej Zary

author

2014-11-26 20:37 UTC #0 lore raw

PATCH 1/1 wd719x: remove dma_cache_sync call

dma_cache_sync() call breaks build on some architectures and

Quoted 5 lines · Arnd Bergmann

dma_cache_sync only makes sense with buffers allocated through dma_alloc_noncoherent(), which this one is not. I suspect we can just remove the call to dma_cache_sync here, in particular since the buffer is passed to the device next, and dma_map_single has already done all the necessary synchronization.

Remove dma_cache_sync call to fix build on other architectures. Driver still works fine on x86 without that.

Signed-off-by Ondrej Zary <[email protected]>

---
 drivers/scsi/wd719x.c |    2 --
 1 file changed, 2 deletions(-)

drivers/scsi/wd719x.c +0 -2

index 23bb5a3..170f228 100644
@@ -243,8 +243,6 @@ static int wd719x_queuecommand(struct Scsi_Host *sh, struct scsi_cmnd *cmd)
 	scb->sense_buf_length = SCSI_SENSE_BUFFERSIZE;
 	cmd->SCp.dma_handle = dma_map_single(&wd->pdev->dev, cmd->sense_buffer,
 			SCSI_SENSE_BUFFERSIZE, DMA_FROM_DEVICE);
-	dma_cache_sync(&wd->pdev->dev, cmd->sense_buffer,
-			SCSI_SENSE_BUFFERSIZE, DMA_FROM_DEVICE);
 	scb->sense_buf = cpu_to_le32(cmd->SCp.dma_handle);
 
 	/* request autosense */

Signature · 1 line

Ondrej Zary