Skip to contentSkip to conversation

config_fallbacks: Add a default entry for CONFIG_SYS_PBSIZE

PATCH New Fabio Estevam 2 participants 4 messages Nov 27, 2014 – Dec 1, 2014

lore
Share & tools
lore

Fabio Estevam

author
#0 lore raw

PATCH 1/2 config_fallbacks: Add a default entry for CONFIG_SYS_PBSIZE

From: Fabio Estevam <[email protected]>

Entering the maximum number of characters defined by CONFIG_SYS_CBSIZE into the console and hitting enter afterwards, causes a hang in the system because CONFIG_SYS_PBSIZE is not capable of storing the characters of the error message:
"Unknown command '' - try 'help'".

Provide a default size for CONFIG_SYS_PBSIZE so that it can store the error message and allows the error message to be printed correctly with no hang.

Signed-off-by Fabio Estevam <[email protected]>
---
 include/config_fallbacks.h | 4 ++++
 1 file changed, 4 insertions(+)
include/config_fallbacks.h +4 -0
index 7d8daa2..508db56 100644
@@ -79,6 +79,10 @@
 #define CONFIG_SYS_PROMPT	"=> "
 #endif
 
+#ifndef CONFIG_SYS_PBSIZE
+#define CONFIG_SYS_PBSIZE	(CONFIG_SYS_CBSIZE + 128)
+#endif
+
 #ifndef CONFIG_FIT_SIGNATURE
 #define CONFIG_IMAGE_FORMAT_LEGACY
 #endif
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH 2/2 mx6sabre_common: Use the default CONFIG_SYS_PBSIZE

From: Fabio Estevam <[email protected]>

Entering the maximum number of characters defined by CONFIG_SYS_CBSIZE into the console and hitting enter afterwards, causes a hang in the system because CONFIG_SYS_PBSIZE is not capable of storing the characters of the error message:
"Unknown command '' - try 'help'".

Use the default CONFIG_SYS_PBSIZE definition from config_fallbacks.h to solve this problem.

Signed-off-by Fabio Estevam <[email protected]>
---
 include/configs/mx6sabre_common.h | 3 ---
 1 file changed, 3 deletions(-)
include/configs/mx6sabre_common.h +0 -3
index 9fdd841..f0f721e 100644
@@ -220,9 +220,6 @@
 #define CONFIG_SYS_PROMPT_HUSH_PS2     "> "
 #define CONFIG_AUTO_COMPLETE
 #define CONFIG_SYS_CBSIZE              256
-
-/* Print Buffer Size */
-#define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + sizeof(CONFIG_SYS_PROMPT) + 16)
 #define CONFIG_SYS_MAXARGS             16
 #define CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE
Signature · 1 line
1.9.1
#2 lore raw

PATCH 2/2 mx6sabre_common: Use the default CONFIG_SYS_PBSIZE

Quoted 21 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Entering the maximum number of characters defined by CONFIG_SYS_CBSIZE into the console and hitting enter afterwards, causes a hang in the system because CONFIG_SYS_PBSIZE is not capable of storing the characters of the error message:
"Unknown command '' - try 'help'".

Use the default CONFIG_SYS_PBSIZE definition from config_fallbacks.h to solve this problem.

Signed-off-by Fabio Estevam <[email protected]>
---
 include/configs/mx6sabre_common.h | 3 ---
 1 file changed, 3 deletions(-)
include/configs/mx6sabre_common.h +0 -0
index 9fdd841..f0f721e 100644

include/configs/mx6sabre_common.h line 225

Quoted 9 lines
include/configs/mx6sabre_common.h +0 -3
@@ -220,9 +220,6 @@
 #define CONFIG_SYS_PROMPT_HUSH_PS2     "> "
 #define CONFIG_AUTO_COMPLETE
 #define CONFIG_SYS_CBSIZE              256
-
-/* Print Buffer Size */
-#define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + sizeof(CONFIG_SYS_PROMPT) + 16)
 #define CONFIG_SYS_MAXARGS             16
 #define CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#3 lore raw

PATCH 1/2 config_fallbacks: Add a default entry for CONFIG_SYS_PBSIZE

In reply to Fabio Estevam
Quoted 21 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Entering the maximum number of characters defined by CONFIG_SYS_CBSIZE into the console and hitting enter afterwards, causes a hang in the system because CONFIG_SYS_PBSIZE is not capable of storing the characters of the error message:
"Unknown command '' - try 'help'".

Provide a default size for CONFIG_SYS_PBSIZE so that it can store the error message and allows the error message to be printed correctly with no hang.

Signed-off-by Fabio Estevam <[email protected]>
---
 include/config_fallbacks.h | 4 ++++
 1 file changed, 4 insertions(+)
include/config_fallbacks.h +0 -0
index 7d8daa2..508db56 100644

include/config_fallbacks.h line 88

Quoted 10 lines
include/config_fallbacks.h +4 -0
@@ -79,6 +79,10 @@
 #define CONFIG_SYS_PROMPT	"=> "
 #endif
 
+#ifndef CONFIG_SYS_PBSIZE
+#define CONFIG_SYS_PBSIZE	(CONFIG_SYS_CBSIZE + 128)
+#endif
+
 #ifndef CONFIG_FIT_SIGNATURE
 #define CONFIG_IMAGE_FORMAT_LEGACY
 #endif

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================