Skip to contentSkip to conversation

Fixed type id

PATCH In review Ren Kimura 2 participants 2 messages Nov 29, 2014

Subsystems (2)
lore
Share & tools
lore

Ren Kimura

author
#0 lore raw

PATCH 1/1 Fixed type id

From: RKX1209 <[email protected]>

---
 arch/x86/mm/init_32.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/x86/mm/init_32.c +2 -2
index c8140e1..957f7f0 100644
@@ -304,14 +304,14 @@ repeat:
 #endif
 		for (; pmd_idx < PTRS_PER_PMD && pfn < end_pfn;
 		     pmd++, pmd_idx++) {
-			unsigned int addr = pfn * PAGE_SIZE + PAGE_OFFSET;
+			unsigned long addr = pfn * PAGE_SIZE + PAGE_OFFSET;
 
 			/*
 			 * Map with big pages if possible, otherwise
 			 * create normal page tables:
 			 */
 			if (use_pse) {
-				unsigned int addr2;
+				unsigned long addr2;
 				pgprot_t prot = PAGE_KERNEL_LARGE;
 				/*
 				 * first pass will use the same initial
Signature · 1 line
1.9.1
#1 lore raw
Quoted 3 lines · Ren Kimura

From: RKX1209 <[email protected]>

What issue does this fix?
On 32bit an address should fit into an integer.

Quoted 33 lines
---
 arch/x86/mm/init_32.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/x86/mm/init_32.c +2 -3
index c8140e1..957f7f0 100644
@@ -304,14 +304,14 @@ repeat:
 #endif
                for (; pmd_idx < PTRS_PER_PMD && pfn < end_pfn;
                     pmd++, pmd_idx++) {
-                       unsigned int addr = pfn * PAGE_SIZE + PAGE_OFFSET;
+                       unsigned long addr = pfn * PAGE_SIZE + PAGE_OFFSET;
 
                        /*
                         * Map with big pages if possible, otherwise
                         * create normal page tables:
                         */
                        if (use_pse) {
-                               unsigned int addr2;
+                               unsigned long addr2;
                                pgprot_t prot = PAGE_KERNEL_LARGE;
                                /*
                                 * first pass will use the same initial
--

1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Signature · 2 lines
Thanks,
//richard