staging: rt8192u: fix sparse warnings in r8192U_core.c
PATCH v2 1/1 staging: rt8192u: fix sparse warnings in r8192U_core.c
From: Fred Chou <[email protected]>
v2: alignment to match open parenthesis
Fixed the following warnings in sparse:drivers/staging/rtl8192u/r8192U_core.c:670:6: warning:
symbol 'dump_eprom' was not declared.
Should it be static?drivers/staging/rtl8192u/r8192U_core.c:1489:5: warning:
symbol 'ComputeTxTime' was not declared. Should it be static?drivers/staging/rtl8192u/r8192U_core.c:1556:14: warning:
symbol 'txqueue2outpipe' was not declared. Should it be static?drivers/staging/rtl8192u/r8192U_core.c:4876:5: warning:
symbol 'GetRxPacketShiftBytes819xUsb' was not declared. Should it be static?
--- drivers/staging/rtl8192u/r8192U_core.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)
drivers/staging/rtl8192u/r8192U_core.c +6 -4
@@ -667,7 +667,7 @@ static void tx_timeout(struct net_device *dev)/* this is only for debug */ -void dump_eprom (struct net_device *dev) +static void dump_eprom (struct net_device *dev) {int i;for (i =0 ; i <63 ; i++)
@@ -1486,7 +1486,7 @@ inline u8 rtl8192_IsWirelessBMode(u16 rate)u16 N_DBPSOfRate (u16 DataRate); -u16 ComputeTxTime (u16 FrameLength,u16 DataRate,u8 bManagementFrame, +static u16 ComputeTxTime (u16 FrameLength,u16 DataRate,u8 bManagementFrame,u8 bShortPreamble) {u16 FrameTime;
@@ -1553,7 +1553,8 @@ u16 N_DBPSOfRate(u16 DataRate)return N_DBPS ; } -unsigned int txqueue2outpipe (struct r8192_priv *priv,unsigned int tx_queue) +static unsigned int txqueue2outpipe (struct r8192_priv *priv, +unsigned int tx_queue) {if (tx_queue >=9 ) {RT_TRACE (COMP_ERR ,"%s():Unknown queue ID!!!\n" , __func__);
@@ -4873,7 +4874,8 @@ static void query_rxdesc_status(struct sk_buff *skb, } -u32 GetRxPacketShiftBytes819xUsb (struct ieee80211_rx_stats *Status,bool bIsRxAggrSubframe) +static u32 GetRxPacketShiftBytes819xUsb (struct ieee80211_rx_stats *Status, +bool bIsRxAggrSubframe) {#ifdef USB_RX_AGGREGATION_SUPPORT if (bIsRxAggrSubframe)
Signature · 1 line
1.9.1
Quoted 3 lines · Fred Chou
From: Fred Chou <[email protected]>
v2: alignment to match open parenthesis
this should not come in commit log, this should go as a comment below the ---
and this patch is not applying to next-20141201, maybe in staging-testing
Quoted 34 lines
Fixed the following warnings in sparse:
drivers/staging/rtl8192u/r8192U_core.c:670:6: warning:
symbol 'dump_eprom' was not declared.
Should it be static?drivers/staging/rtl8192u/r8192U_core.c:1489:5: warning:
symbol 'ComputeTxTime' was not declared. Should it be static?drivers/staging/rtl8192u/r8192U_core.c:1556:14: warning:
symbol 'txqueue2outpipe' was not declared. Should it be static?drivers/staging/rtl8192u/r8192U_core.c:4876:5: warning:
symbol 'GetRxPacketShiftBytes819xUsb' was not declared. Should it be static?Signed-off-by Fred Chou <[email protected]>--- drivers/staging/rtl8192u/r8192U_core.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)drivers/staging/rtl8192u/r8192U_core.c +1
-1@@ -667,7 +667,7 @@ static void tx_timeout(struct net_device *dev)/* this is only for debug */ -void dump_eprom (struct net_device *dev) +static void dump_eprom (struct net_device *dev) {int i;for (i =0 ; i <63 ; i++)
drivers/staging/rtl8192u/r8192U_core.c inline u8 rtl8192_IsWirelessBMode(u16 rate) · line 1490
Quoted 6 lines
drivers/staging/rtl8192u/r8192U_core.c +1
-1@@ -1486,7 +1486,7 @@ inline u8 rtl8192_IsWirelessBMode(u16 rate)u16 N_DBPSOfRate (u16 DataRate); -u16 ComputeTxTime (u16 FrameLength,u16 DataRate,u8 bManagementFrame, +static u16 ComputeTxTime (u16 FrameLength,u16 DataRate,u8 bManagementFrame,u8 bShortPreamble)
u missed this alignment
thanks
sudip
Quoted 30 lines
drivers/staging/rtl8192u/r8192U_core.c +4
-2{u16 FrameTime;@@ -1553,7 +1553,8 @@ u16 N_DBPSOfRate(u16 DataRate)return N_DBPS ; } -unsigned int txqueue2outpipe (struct r8192_priv *priv,unsigned int tx_queue) +static unsigned int txqueue2outpipe (struct r8192_priv *priv, +unsigned int tx_queue) {if (tx_queue >=9 ) {RT_TRACE (COMP_ERR ,"%s():Unknown queue ID!!!\n" , __func__);@@ -4873,7 +4874,8 @@ static void query_rxdesc_status(struct sk_buff *skb, } -u32 GetRxPacketShiftBytes819xUsb (struct ieee80211_rx_stats *Status,bool bIsRxAggrSubframe) +static u32 GetRxPacketShiftBytes819xUsb (struct ieee80211_rx_stats *Status, +bool bIsRxAggrSubframe) {#ifdef USB_RX_AGGREGATION_SUPPORT if (bIsRxAggrSubframe)Signature · 7 lines
1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/