tools/kwbimage.c: fix build on m68k
PATCH 1/1 tools/kwbimage.c: fix build on m68k
Compiler still complains about headersz possible uninitialized, even after last change (switch used).
CROSS_COMPILE=/opt/toolchains/m68k/gcc-4.6.3-nolibc/m68k-linux/ bin/m68k-linux- ./MAKEALL -a m68k
boards.cfg is up to date. Nothing to do.
Building M52277EVB board...
text data bss dec hex filename
118493 11756 4096 134345 20cc9 ./u-boottools/kwbimage.c: In function ?kwbimage_set_header?:tools/kwbimage.c:803:8: warning: ?headersz? may be used uninitialized in this function [-Wmaybe-uninitialized]
memcpy(ptr, image, headersz);
^--- tools/kwbimage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/kwbimage.c +1 -1
@@ -728,7 +728,7 @@ static void kwbimage_set_header(void *ptr, struct stat *sbuf, int ifd,FILE *fcfg;void *image =NULL ;int version; -size_t headersz; +size_t headersz =0 ;uint32_t checksum;int ret;int size;
Signature · 1 line
2.1.1
PATCH 1/1 tools/kwbimage.c: fix build on m68k
Hi Angelo,
Quoted 25 lines
Compiler still complains about headersz possible uninitialized, even after last change (switch used).
CROSS_COMPILE=/opt/toolchains/m68k/gcc-4.6.3-nolibc/m68k-linux/ bin/m68k-linux- ./MAKEALL -a m68k
boards.cfg is up to date. Nothing to do.
Building M52277EVB board...
text data bss dec hex filename
118493 11756 4096 134345 20cc9 ./u-boottools/kwbimage.c: In function ?kwbimage_set_header?:tools/kwbimage.c:803:8: warning: ?headersz? may be used uninitialized in this function [-Wmaybe-uninitialized]memcpy(ptr, image, headersz); ^Signed-off-by Angelo Dureghello <[email protected]>--- tools/kwbimage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/kwbimage.c +0
-0
tools/kwbimage.c static void kwbimage_set_header(void *ptr, struct · line 734
Quoted 8 lines
tools/kwbimage.c +1
-1@@ -728,7 +728,7 @@ static void kwbimage_set_header(void *ptr, struct stat *sbuf, int ifd, FILE *fcfg;void *image =NULL ;int version; -size_t headersz; +size_t headersz =0 ;uint32_t checksum;int ret;int size;
You aren't the first person who attempted to fix this.
Please read the following thread:
http://patchwork.ozlabs.org/patch/412968/
Albert has already promised to look into this issue.
Best regards,
Lukasz Majewski
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141203/5f8e92db/attachment.pgp>
PATCH 1/1 tools/kwbimage.c: fix build on m68k
Dear Lukasz,
Quoted 2 lines
Hi Angelo,
You aren't the first person who attempted to fix this.
i read the history of the fixes done on this file before posting, and seen the issue was solved using a "switch / case" approach.
I was testing yesterday the kernel.org x86 toolchain for m68k, (m68k/gcc-4.6.3-nolibc) and found this warning emitted building the master branch,so i posted the patch since is possible the warning is thrown only with this m68k toolchain.
So i don't want absolutely overlap ongoing jobs, if they are already in chargeto anyone simply ignore the patch.
Best Regards,
Angelo Dureghello