Skip to contentSkip to conversation

amdkfd: use atomic allocations within srcu callbacks

PATCH In review Sasha Levin 2 participants 2 messages Dec 3, 2014 – Dec 4, 2014

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 amdkfd: use atomic allocations within srcu callbacks

srcu callbacks are running in atomic context, we can't allocate using __GFP_WAIT.

---
 drivers/gpu/drm/amd/amdkfd/kfd_process.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdkfd/kfd_process.c +1 -1
index b4f49ac..b85eb0b 100644
@@ -196,7 +196,7 @@ static void kfd_process_destroy_delayed(struct rcu_head *rcu)
 	mmdrop(p->mm);
 
 	work = (struct kfd_process_release_work *)
-		kmalloc(sizeof(struct kfd_process_release_work), GFP_KERNEL);
+		kmalloc(sizeof(struct kfd_process_release_work), GFP_ATOMIC);
 
 	if (work) {
 		INIT_WORK((struct work_struct *) work, kfd_process_wq_release);
Signature · 1 line
2.1.0
#1 lore raw
Quoted 14 lines · Sasha Levin

srcu callbacks are running in atomic context, we can't allocate using __GFP_WAIT.

---
  drivers/gpu/drm/amd/amdkfd/kfd_process.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdkfd/kfd_process.c +0 -0
index b4f49ac..b85eb0b 100644

drivers/gpu/drm/amd/amdkfd/kfd_process.c static void kfd_process_destroy_delayed(struct rcu_head *rcu) · line 202

Quoted 8 lines
drivers/gpu/drm/amd/amdkfd/kfd_process.c +1 -1
@@ -196,7 +196,7 @@ static void kfd_process_destroy_delayed(struct rcu_head *rcu)
  	mmdrop(p->mm);
 
  	work = (struct kfd_process_release_work *)
-		kmalloc(sizeof(struct kfd_process_release_work), GFP_KERNEL);
+		kmalloc(sizeof(struct kfd_process_release_work), GFP_ATOMIC);
 
  	if (work) {
  		INIT_WORK((struct work_struct *) work, kfd_process_wq_release);

Thanks!
Applied to my -next tree.

Oded
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel