Fix: don't destroy the sockets if the snapshot was successful
A message that is not in the archive (sent off-list or not yet received): [email protected]
Merged all the way to 2.4.
Thanks!
Jérémie
Quoted 30 lines · Julien Desfossez
Missing a goto to skip the error condition that was destroying the relayd sockets even if a snapshot was successful. We want to keep them open to reuse them for the next snapshots.
Signed-off-by Julien Desfossez <[email protected]>--- src/bin/lttng-sessiond/cmd.c | 2 ++ 1 file changed, 2 insertions(+)src/bin/lttng-sessiond/cmd.c +2
-1@@ -2979,11 +2979,13 @@ static int record_kernel_snapshot(struct ltt_kernel_session *ksess, } ret =LTTNG_OK ; + goto end; error_snapshot:/* Clean up copied sockets so this output can use some other later on. */ consumer_destroy_output_sockets (output->consumer); error: +end:return ret; } --1.9.1
Signature · 8 lines
Jérémie Galarneau EfficiOS Inc. http://www.efficios.com _______________________________________________ lttng-dev mailing list [email protected] http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev