Skip to contentSkip to conversation

drm/i915: use TAIL rather than ACTHD for synchronising reads

PATCH In review Dave Gordon 3 participants 3 messages Dec 17, 2014 – Dec 18, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: use TAIL rather than ACTHD for synchronising reads

On some generations of chips, it is necessary to read an MMIO register before getting the sequence number from the status page in main memory, in order to ensure coherency; and on all generations this should be either helpful or harmless.

In general, we want this operation to be the cheapest possible, since we require only the side-effect of DMA completion and don't interpret the result of the read, and don't require any coordination with other threads, power domains, or anything else.

However, finding a suitable register may be problematic; on GEN6 chips the ACTHD register was used, but on VLV et al access to this register requires FORCEWAKE and therefore many complications involving spinlocks and polling.

So this commit introduces this synchronising operation as a distinct vfunc in uncore, so that it can be GEN- or chip-specific if needed.

For now, a sample 'universal' implementation is provided which just reads the TAIL register of the render engine, this being a register which should always be accessible on all GENs without requiring forcewake or other complications.

We then change gen6_ring_get_seqno() to use this new SYNC_READ rather than a POSTING_READ of ACTHD. Note that both older (pre-GEN6) and newer (GEN8+) devices don't currently include any posting read in their own get_seqno() implementations, so this affects only GEN6 and 7 devices.

---
 drivers/gpu/drm/i915/i915_drv.h         |    7 +++++++
 drivers/gpu/drm/i915/intel_ringbuffer.c |    2 +-
 drivers/gpu/drm/i915/intel_uncore.c     |    9 +++++++++
 3 files changed, 17 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_drv.h +7 -0
index 3047291f..9826cb6 100644
@@ -593,6 +593,9 @@ struct intel_uncore_funcs {
 				uint32_t val, bool trace);
 	void (*mmio_writeq)(struct drm_i915_private *dev_priv, off_t offset,
 				uint64_t val, bool trace);
+
+	/* Read any suitable register, for DMA synchronisation purposes only */
+	void (*sync_read)(struct drm_i915_private *dev_priv);
 };
 
 struct intel_uncore {
@@ -3161,6 +3164,8 @@ int vlv_freq_opcode(struct drm_i915_private *dev_priv, int val);
 #define I915_READ_NOTRACE(reg)		dev_priv->uncore.funcs.mmio_readl(dev_priv, (reg), false)
 #define I915_WRITE_NOTRACE(reg, val)	dev_priv->uncore.funcs.mmio_writel(dev_priv, (reg), (val), false)
 
+#define I915_SYNC_READ()	dev_priv->uncore.funcs.sync_read(dev_priv)
+
 /* Be very careful with read/write 64-bit values. On 32-bit machines, they
  * will be implemented using 2 32-bit writes in an arbitrary order with
  * an arbitrary delay between them. This can cause the hardware to
@@ -3184,6 +3189,8 @@ int vlv_freq_opcode(struct drm_i915_private *dev_priv, int val);
 #define POSTING_READ(reg)	(void)I915_READ_NOTRACE(reg)
 #define POSTING_READ16(reg)	(void)I915_READ16_NOTRACE(reg)
 
+#define SYNC_READ()		I915_SYNC_READ()
+
 /* "Broadcast RGB" property */
 #define INTEL_BROADCAST_RGB_AUTO 0
 #define INTEL_BROADCAST_RGB_FULL 1
drivers/gpu/drm/i915/intel_ringbuffer.c +1 -1
index 12a36f0..74bffce 100644
@@ -1217,7 +1217,7 @@ gen6_ring_get_seqno(struct intel_engine_cs *ring, bool lazy_coherency)
 	 * ACTHD) before reading the status page. */
 	if (!lazy_coherency) {
 		struct drm_i915_private *dev_priv = ring->dev->dev_private;
-		POSTING_READ(RING_ACTHD(ring->mmio_base));
+		SYNC_READ();
 	}
 
 	return intel_read_status_page(ring, I915_GEM_HWS_INDEX);
drivers/gpu/drm/i915/intel_uncore.c +9 -0
index e9561de..8fc40c4 100644
@@ -737,6 +737,14 @@ hsw_unclaimed_reg_detect(struct drm_i915_private *dev_priv)
 	}
 }
 
+static void
+gen4_sync_read(struct drm_i915_private *dev_priv)
+{
+	/* No HEADER, no FOOTER, just the raw read */
+	(void)__raw_i915_read32(dev_priv,
+				RING_TAIL(dev_priv->ring[RCS].mmio_base));
+}
+
 #define REG_READ_HEADER(x) \
 	unsigned long irqflags; \
 	u##x val = 0; \
@@ -1139,6 +1147,7 @@ do { \
 	dev_priv->uncore.funcs.mmio_readw = x##_read16; \
 	dev_priv->uncore.funcs.mmio_readl = x##_read32; \
 	dev_priv->uncore.funcs.mmio_readq = x##_read64; \
+	dev_priv->uncore.funcs.sync_read = gen4_sync_read; \
 } while (0)
 
 void intel_uncore_init(struct drm_device *dev)
Signature · 6 lines
1.7.9.5

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw
Quoted 15 lines · Dave Gordon

On some generations of chips, it is necessary to read an MMIO register before getting the sequence number from the status page in main memory, in order to ensure coherency; and on all generations this should be either helpful or harmless.

In general, we want this operation to be the cheapest possible, since we require only the side-effect of DMA completion and don't interpret the result of the read, and don't require any coordination with other threads, power domains, or anything else.

However, finding a suitable register may be problematic; on GEN6 chips the ACTHD register was used, but on VLV et al access to this register requires FORCEWAKE and therefore many complications involving spinlocks and polling.

Quoted 7 lines

So this commit introduces this synchronising operation as a distinct vfunc in uncore, so that it can be GEN- or chip-specific if needed.

For now, a sample 'universal' implementation is provided which just reads the TAIL register of the render engine, this being a register which should always be accessible on all GENs without requiring forcewake or other complications.

TAIL requires forcewake. Don't make this an uncore function, it is an implementation detail of the engine.
-Chris

Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Tested-by on v1 1/1
#2 lore raw
In reply to Dave Gordon

-------------------------------------Summary-------------------------------------
Platform Delta drm-intel-nightly Series Applied
PNV 364/364 364/364
ILK +1 364/366 365/366

SNB                                  448/450              448/450
IVB                                  497/498              497/498
BYT                                  289/289              289/289
HSW                 -2              563/564              561/564
BDW                 -1              416/417              415/417
-------------------------------------Detailed-------------------------------------
Platform  Test                                drm-intel-nightly          Series Applied
 ILK  igt_kms_flip_bcs-flip-vs-modeset-interruptible      DMESG_WARN(1, M26)PASS(2, M37M26)      PASS(1, M37)
*HSW  igt_gem_concurrent_blit_gpu-rcs-overwrite-source-forked      PASS(2, M40)      NO_RESULT(1, M40)
*HSW  igt_gem_concurrent_blit_gpuX-rcs-early-read-forked      PASS(2, M40)      NO_RESULT(1, M40)
*BDW  igt_gem_multi_bsd_sync_loop      PASS(2, M28M30)      DMESG_WARN(1, M30)

Note: You need to pay more attention to line start with '*'
_______________________________________________
Intel-gfx mailing list [email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx