iio: ti-adc128s052: Add DT binding documentation
Subsystems (2)
PATCH 1/1 iio: ti-adc128s052: Add DT binding documentation
Adding binding documentation for Texas Instruments' ADC128S052 ADC chip.
--- .../devicetree/bindings/iio/adc/ti-adc128s052.txt | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt
Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt new file +18 -0
@@ -0,0 +1,18 @@ +* Texas Instruments' ADC128S052 ADC chip + +Required properties: + - compatible: Should be "ti,adc128s052" + - reg: spi chip select number for the device + - vref-supply: The regulator supply ADC reference voltage. + +Recommended properties: +- spi-max-frequency: Definition as per + Documentation/devicetree/bindings/spi/spi-bus.txt + +Example: +adc@0 { + compatible = "ti,adc128s052"; + reg = <0>; + vref-supply = <&vdd_supply>; + spi-max-frequency = <1000000>; +};
Signature · 1 line
1.9.1
Quoted 3 lines · Angelo Compagnucci
Adding binding documentation for Texas Instruments' ADC128S052 ADC chip.
Signed-off-by Angelo Compagnucci <[email protected]>
Looks good to me, but you might want to send this to the devicetree list and the devicetree bindings maintainers.
[...]
Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt line 16
Quoted 5 lines
Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt new file +5
-0+Example: +adc@0 { + compatible = "ti,adc128s052"; + reg = <0>; + vref-supply = <&vdd_supply>;
strange indention here
Quoted 3 lines
Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt new file +2
-0+ spi-max-frequency = <1000000>; +};
Hi Lars-Peter,
2014-12-18 17:18 GMT+01:00 Lars-Peter Clausen <[email protected]>:
Quoted 9 lines · Angelo Compagnucci
Quoted 4 lines
Adding binding documentation for Texas Instruments' ADC128S052 ADC chip.
Signed-off-by Angelo Compagnucci <[email protected]>Looks good to me, but you might want to send this to the devicetree list and the devicetree bindings maintainers.
Ouch! Resending to the right ml, thank you for your support!
Quoted 17 lines
[...]
Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt line 16
Quoted 6 lines
Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt new file +5
-0+Example: +adc@0 { + compatible = "ti,adc128s052"; + reg = <0>; + vref-supply = <&vdd_supply>;strange indention here
Quoted 3 lines
Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt new file +2
-0+ spi-max-frequency = <1000000>; +};
Signature · 1 line
Profile: http://it.linkedin.com/in/compagnucciangelo
Jonathan Cameron
maintainerQuoted 7 lines · Angelo Compagnucci
Hi Lars-Peter,
2014-12-18 17:18 GMT+01:00 Lars-Peter Clausen <[email protected]>:
Quoted 4 lines · Angelo Compagnucci
Quoted 3 lines
Adding binding documentation for Texas Instruments' ADC128S052 ADC chip.
Quoted 7 lines
Quoted 5 lines
Quoted 1 line
Signed-off-by Angelo Compagnucci <[email protected]>Looks good to me, but you might want to send this to the devicetree list and the devicetree bindings maintainers.
Ouch! Resending to the right ml, thank you for your support!
Do keep linux-iio in the loop as well as it'll probably go through my tree ultimately and I don't read the device-tree list directly :) Nature of these patches is that they want to go to the maintainers, reviewers and lists for both iio and devicetree.
Jonathan
Quoted 21 lines
Quoted 18 lines
[...]
Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt line 16
Quoted 6 lines
Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt new file +5
-0+Example: +adc@0 { + compatible = "ti,adc128s052"; + reg = <0>; + vref-supply = <&vdd_supply>;strange indention here
Quoted 3 lines
Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt new file +2
-0+ spi-max-frequency = <1000000>; +};
Angelo Compagnucci schrieb am 17.12.2014 um 18:59:
Quoted 1 line
Adding binding documentation for Texas Instruments' ADC128S052 ADC chip.
Hi,
some thoughts inline.
Quoted 13 lines
Signed-off-by Angelo Compagnucci <[email protected]>--- .../devicetree/bindings/iio/adc/ti-adc128s052.txt | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txtDocumentation/devicetree/bindings/iio/adc/ti-adc128s052.txt new file +0
-0
Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt line 5
Quoted 5 lines
Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt new file +5
-0@@ -0,0 +1,18 @@ +* Texas Instruments' ADC128S052 ADC chip + +Required properties: + - compatible: Should be "ti,adc128s052" + - reg: spi chip select number for the device
Use upper case for SPI?
Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt line 6
Quoted 1 line
Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt new file +1
-0+ - vref-supply: The regulator supply ADC reference voltage.
Maybe: The regulator supplying ADC reference voltage.
Quoted 13 lines
Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt new file +12
-0+ +Recommended properties: +- spi-max-frequency: Definition as per + Documentation/devicetree/bindings/spi/spi-bus.txt + +Example: +adc@0 { + compatible = "ti,adc128s052"; + reg = <0>; + vref-supply = <&vdd_supply>; + spi-max-frequency = <1000000>; +};