Skip to contentSkip to conversation

Staging: gdm724x: fix space before comma coding style issue in gdm_mux.c

PATCH In review Robert Nachlinger 2 participants 4 messages Dec 18, 2014 – Dec 20, 2014 1 message not in the archive Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: gdm724x: fix space before comma coding style issue in gdm_mux.c

This is a patch to the gdm_mux.c file that fixes a space before comma coding style issue found by the checkpatch.pl tool.

---
 drivers/staging/gdm724x/gdm_mux.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/gdm724x/gdm_mux.c +1 -1
index b5b063a..d1ab996 100644
@@ -220,7 +220,7 @@ static int up_to_host(struct mux_rx *r)
 static void do_rx(struct work_struct *work)
 {
 	struct mux_dev *mux_dev =
-		container_of(work, struct mux_dev , work_rx.work);
+		container_of(work, struct mux_dev, work_rx.work);
 	struct mux_rx *r;
 	struct rx_cxt *rx = (struct rx_cxt *)&mux_dev->rx;
 	unsigned long flags;
Signature · 1 line
2.2.0
maintainer
#1 lore raw
Quoted 1 line · Robert Nachlinger

This is a patch to the gdm_mux.c file that fixes a space before comma coding style issue found by the checkpatch.pl tool.

Please line-wrap your changelog text, there's no reason to have lines this long, right?

greg k-h

maintainer
#2 lore raw
In reply to Robert Nachlinger
Quoted 1 line · Robert Nachlinger

This is a patch to the gdm_mux.c file that fixes a space before comma coding style issue found by the checkpatch.pl tool.

Can you fix up your line to be line-wrapped at 72 columns so I don't have to do it by hand?

thanks,

greg k-h

A message that is not in the archive (sent off-list or not yet received): CABdSh179apawgBKm9=2vBaxVBPTemz4SPhDcgf_2kwk7rsn2oA@mail.gmail.com

maintainer
#4 lore raw
Quoted 9 lines · Robert N

I already sent you the patch line-wrapped at column 69, so it says:

Quoted 2 lines

This is a patch to the gdm_mux.c file that fixes a space before comma coding style issue found by the checkpatch.pl tool.

Do i have to wrap it exactly at column 72? That would break a word:

Quoted 2 lines

This is a patch to the gdm_mux.c file that fixes a space before comma co ding style issue found by the checkpatch.pl tool.

Of course not, use a "sane" editor that wraps at a word boundry please.

thanks,

greg k-h