Skip to contentSkip to conversation

kernelsrc.bbclass: Ensure fetch/unpack/patch tasks don't run

PATCH In review Richard Purdie 2 participants 2 messages Dec 19, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kernelsrc.bbclass: Ensure fetch/unpack/patch tasks don't run

In particular this removes a race condition where a ${S}/patches directory could be created by do_unpack. This confuses kern-tools.

meta/classes/kernelsrc.bbclass +3 -0
index 11f04e9..4208eff 100644
@@ -1,5 +1,8 @@
 S = "${STAGING_KERNEL_DIR}"
+do_fetch[noexec] = "1"
 do_unpack[depends] += "virtual/kernel:do_patch"
+do_unpack[noexec] = "1"
+do_patch[noexec] = "1"
 do_package[depends] += "virtual/kernel:do_populate_sysroot"
 KERNEL_VERSION = "${@get_kernelversion_file("${S}")}"
 
#1 lore raw
Quoted 2 lines · Richard Purdie

In particular this removes a race condition where a ${S}/patches directory could be created by do_unpack. This confuses kern-tools.

Looks good here. This will keep the dreaded 'patches' directory from popping up and mucking up the existing detection of meta data.

On a related note, I'll see about making things more robust on the detection end as well.

Cheers,

Bruce

Quoted 18 lines
meta/classes/kernelsrc.bbclass +3 -0
index 11f04e9..4208eff 100644
@@ -1,5 +1,8 @@
  S = "${STAGING_KERNEL_DIR}"
+do_fetch[noexec] = "1"
  do_unpack[depends] += "virtual/kernel:do_patch"
+do_unpack[noexec] = "1"
+do_patch[noexec] = "1"
  do_package[depends] += "virtual/kernel:do_populate_sysroot"
  KERNEL_VERSION = "${@get_kernelversion_file("${S}")}"