Skip to contentSkip to conversation

Staging: clocking-wizard: Added a blank line after declaration

PATCH In review Mohammad Jamal 3 participants 3 messages Dec 21, 2014 – Jan 18, 2015 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: clocking-wizard: Added a blank line after declaration

Fix the coding style issue by adding blank line after declaration

---
 .../clocking-wizard/clk-xlnx-clock-wizard.c        |    1 +
 1 file changed, 1 insertion(+)
drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c +1 -0
index 471d087..ea8d561 100644
@@ -239,6 +239,7 @@ static int clk_wzrd_probe(struct platform_device *pdev)
 	/* register div per output */
 	for (i = WZRD_NUM_OUTPUTS - 1; i >= 0 ; i--) {
 		const char *clkout_name;
+
 		if (of_property_read_string_index(np, "clock-output-names", i,
 						  &clkout_name)) {
 			dev_err(&pdev->dev,
Signature · 1 line
1.7.9.5
Acked-by on v1 1/1
#1 lore raw

Hi Mohammad,

Quoted 12 lines · Mohammad Jamal

Fix the coding style issue by adding blank line after declaration

---
 .../clocking-wizard/clk-xlnx-clock-wizard.c        |    1 +
 1 file changed, 1 insertion(+)
drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c +0 -0
index 471d087..ea8d561 100644

drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c static int clk_wzrd_probe(struct platform_device *pdev) · line 245

Quoted 7 lines
drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c +1 -0
@@ -239,6 +239,7 @@ static int clk_wzrd_probe(struct platform_device *pdev)
 	/* register div per output */
 	for (i = WZRD_NUM_OUTPUTS - 1; i >= 0 ; i--) {
 		const char *clkout_name;
+
 		if (of_property_read_string_index(np, "clock-output-names", i,
 						  &clkout_name)) {
 			dev_err(&pdev->dev,

I think the same patch had already been sent to the list by somebody else. Not sure whether Greg picked it up yet.
Either way, feel free to add my

Sören

maintainer
#2 lore raw
Quoted 26 lines · Sören Brinkmann

Hi Mohammad,

Quoted 12 lines · Mohammad Jamal

Fix the coding style issue by adding blank line after declaration

---
 .../clocking-wizard/clk-xlnx-clock-wizard.c        |    1 +
 1 file changed, 1 insertion(+)
drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c +0 -0
index 471d087..ea8d561 100644

drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c static int clk_wzrd_probe(struct platform_device *pdev) · line 245

Quoted 7 lines
drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c +1 -0
@@ -239,6 +239,7 @@ static int clk_wzrd_probe(struct platform_device *pdev)
 	/* register div per output */
 	for (i = WZRD_NUM_OUTPUTS - 1; i >= 0 ; i--) {
 		const char *clkout_name;
+
 		if (of_property_read_string_index(np, "clock-output-names", i,
 						  &clkout_name)) {
 			dev_err(&pdev->dev,

I think the same patch had already been sent to the list by somebody else. Not sure whether Greg picked it up yet.
Either way, feel free to add my

Quoted 1 line

I now have, so this one will not apply :(