Skip to contentSkip to conversation

staging: speakup: Split the comment to fit the length

PATCH In review Panir.Nyan 2 participants 4 messages Dec 24, 2014 Staging

lore
Share & tools
lore

Panir.Nyan

author
#0 lore raw

PATCH 1/2 staging: speakup: Split the comment to fit the length

Split the comment to fit the length.

---
 drivers/staging/speakup/synth.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/speakup/synth.c +3 -3
index f3aa423..01eddab 100644
@@ -30,9 +30,9 @@ struct speakup_info_t speakup_info = {
 	 * must be taken at each kernel->speakup transition and released at
 	 * each corresponding speakup->kernel transition.
 	 *
-	 * The progression thread only interferes with the speakup machinery through
-	 * the synth buffer, so only needs to take the lock while tinkering with
-	 * the buffer.
+	 * The progression thread only interferes with the speakup machinery
+	 * through the synth buffer, so only needs to take the lock
+	 * while tinkering with the buffer.
 	 *
 	 * We use spin_lock/trylock_irqsave and spin_unlock_irqrestore with this
 	 * spinlock because speakup needs to disable the keyboard IRQ.

--
1.7.10.4

author
#1 lore raw

PATCH 2/2 staging: speakup: Combine the consecutive string

Combine the consecutive string

---
 drivers/staging/speakup/kobjects.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/speakup/kobjects.c +1 -1
index b12c76d..3708bc1 100644
@@ -566,7 +566,7 @@ ssize_t spk_var_show(struct kobject *kobj, struct kobj_attribute *attr,
 				if (ch >= ' ' && ch < '~')
 					*cp1++ = ch;
 				else
-					cp1 += sprintf(cp1, "\\""x%02x", ch);
+					cp1 += sprintf(cp1, "\\x%02x", ch);
 			}
 			*cp1++ = '"';
 			*cp1++ = '\n';

--
1.7.10.4

Acked-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] staging: speakup: Combine the consecutive string

Quoted 3 lines · Panir.Nyan, le Wed 24 Dec 2014 04:07:32 +0000, a écrit :

Combine the consecutive string

Quoted 20 lines
---
 drivers/staging/speakup/kobjects.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/speakup/kobjects.c +1 -2
index b12c76d..3708bc1 100644
@@ -566,7 +566,7 @@ ssize_t spk_var_show(struct kobject *kobj, struct kobj_attribute *attr,
 				if (ch >= ' ' && ch < '~')
 					*cp1++ = ch;
 				else
-					cp1 += sprintf(cp1, "\\""x%02x", ch);
+					cp1 += sprintf(cp1, "\\x%02x", ch);
 			}
 			*cp1++ = '"';
 			*cp1++ = '\n';
--

1.7.10.4

Signature · 4 lines
Samuel
"...Unix, MS-DOS, and Windows NT (also known as the Good, the Bad, and
the Ugly)."
(By Matt Welsh)
Acked-by on v1 1/2
#3 lore raw
In reply to Panir.Nyan
Quoted 3 lines · Panir.Nyan, le Wed 24 Dec 2014 04:07:31 +0000, a écrit :

Split the comment to fit the length.

Quoted 24 lines
---
 drivers/staging/speakup/synth.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/speakup/synth.c +3 -4
index f3aa423..01eddab 100644
@@ -30,9 +30,9 @@ struct speakup_info_t speakup_info = {
 	 * must be taken at each kernel->speakup transition and released at
 	 * each corresponding speakup->kernel transition.
 	 *
-	 * The progression thread only interferes with the speakup machinery through
-	 * the synth buffer, so only needs to take the lock while tinkering with
-	 * the buffer.
+	 * The progression thread only interferes with the speakup machinery
+	 * through the synth buffer, so only needs to take the lock
+	 * while tinkering with the buffer.
 	 *
 	 * We use spin_lock/trylock_irqsave and spin_unlock_irqrestore with this
 	 * spinlock because speakup needs to disable the keyboard IRQ.
--

1.7.10.4

Signature · 5 lines
Samuel
Linux, c'est simple : ça s'adresse à une machine qui est parfois un peu
maraboutée mais qui d'habitude n'a pas d'états d'âme. Sur Usenet y'a
plein d'humains et de primates, et ça devient vraiment gore par moment.
-+- TP in : Guide du linuxien pervers - "Le linuxien a-t-il une âme ?" -+-