Skip to contentSkip to conversation

amdkfd: actually allocate longs for the pasid bitmask

PATCH In review Sasha Levin 2 participants 2 messages Dec 28, 2014 – Dec 29, 2014

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 amdkfd: actually allocate longs for the pasid bitmask

Commit "amdkfd: use sizeof(long) granularity for the pasid bitmask" calculated the number of longs it will need, but ended up allocating that number of bytes rather than longs.

Fix that silly error and allocate the amount of data really required.

---
 drivers/gpu/drm/amd/amdkfd/kfd_pasid.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdkfd/kfd_pasid.c +1 -1
index 71699ad..4c25ef5 100644
@@ -32,7 +32,7 @@ int kfd_pasid_init(void)
 {
 	pasid_limit = max_num_of_processes;
 
-	pasid_bitmap = kzalloc(BITS_TO_LONGS(pasid_limit), GFP_KERNEL);
+	pasid_bitmap = kcalloc(BITS_TO_LONGS(pasid_limit), sizeof(long), GFP_KERNEL);
 	if (!pasid_bitmap)
 		return -ENOMEM;
 
Signature · 1 line
1.7.10.4
#1 lore raw
Quoted 17 lines · Sasha Levin

Commit "amdkfd: use sizeof(long) granularity for the pasid bitmask" calculated the number of longs it will need, but ended up allocating that number of bytes rather than longs.

Fix that silly error and allocate the amount of data really required.

---
  drivers/gpu/drm/amd/amdkfd/kfd_pasid.c |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdkfd/kfd_pasid.c +0 -0
index 71699ad..4c25ef5 100644

drivers/gpu/drm/amd/amdkfd/kfd_pasid.c int kfd_pasid_init(void) · line 38

Quoted 8 lines
drivers/gpu/drm/amd/amdkfd/kfd_pasid.c +1 -1
@@ -32,7 +32,7 @@ int kfd_pasid_init(void)
  {
  	pasid_limit = max_num_of_processes;
 
-	pasid_bitmap = kzalloc(BITS_TO_LONGS(pasid_limit), GFP_KERNEL);
+	pasid_bitmap = kcalloc(BITS_TO_LONGS(pasid_limit), sizeof(long), GFP_KERNEL);
  	if (!pasid_bitmap)
  		return -ENOMEM;
 

Thanks!
Applied to my amdkfd-fixes tree.

Oded
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel