ASoC: fsl_ssi: Make error message concise
Subsystems (3)
Fabio Estevam
reviewerPATCH 1/5 ASoC: fsl_ssi: Make error message concise
From: Fabio Estevam <[email protected]>
Currently the error message uses 'np->full_name' which leads to a very verbose log as:
fsl-ssi-dai 202c000.ssi: no irq for node /soc/aips-bus@02000000/spba-bus@02000000/ssi@0202c000
We can have a concise log by using pdev->name instead:
fsl-ssi-dai 202c000.ssi: no irq for node 202c000.ssi
--- sound/soc/fsl/fsl_ssi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/fsl/fsl_ssi.c +1 -1
@@ -1363,7 +1363,7 @@ static int fsl_ssi_probe(struct platform_device *pdev) ssi_private->irq =platform_get_irq (pdev,0 );if (!ssi_private->irq) { -dev_err (&pdev->dev,"no irq for node %s\n" , np->full_name); +dev_err (&pdev->dev,"no irq for node %s\n" , pdev->name);return -ENXIO ; }
Signature · 1 line
1.9.1
Fabio Estevam
reviewerPATCH 2/5 ASoC: fsl_asrc: Make error message concise
From: Fabio Estevam <[email protected]>
Currently the error message uses 'np->full_name' which leads to a very verbose log that contains the full path of the node.
We can have a concise log by using pdev->name instead.
--- sound/soc/fsl/fsl_asrc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/fsl/fsl_asrc.c +1 -1
@@ -836,7 +836,7 @@ static int fsl_asrc_probe(struct platform_device *pdev) irq =platform_get_irq (pdev,0 );if (irq <0 ) { -dev_err (&pdev->dev,"no irq for node %s\n" , np->full_name); +dev_err (&pdev->dev,"no irq for node %s\n" , pdev->name);return irq; }
Signature · 1 line
1.9.1
Fabio Estevam
reviewerPATCH 3/5 ASoC: fsl_sai: Make error message concise
In reply to Fabio EstevamFrom: Fabio Estevam <[email protected]>
Currently the error message uses 'np->full_name' which leads to a very verbose log that contains the full path of the node.
We can have a concise log by using pdev->name instead.
--- sound/soc/fsl/fsl_sai.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/fsl/fsl_sai.c +1 -1
@@ -612,7 +612,7 @@ static int fsl_sai_probe(struct platform_device *pdev) irq =platform_get_irq (pdev,0 );if (irq <0 ) { -dev_err (&pdev->dev,"no irq for node %s\n" , np->full_name); +dev_err (&pdev->dev,"no irq for node %s\n" , pdev->name);return irq; }
Signature · 1 line
1.9.1
Fabio Estevam
reviewerPATCH 4/5 ASoC: fsl_esai: Make error message concise
In reply to Fabio EstevamFrom: Fabio Estevam <[email protected]>
Currently the error message uses 'np->full_name' which leads to a very verbose log that contains the full path of the node.
We can have a concise log by using pdev->name instead.
--- sound/soc/fsl/fsl_esai.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/fsl/fsl_esai.c +1 -1
@@ -774,7 +774,7 @@ static int fsl_esai_probe(struct platform_device *pdev) irq =platform_get_irq (pdev,0 );if (irq <0 ) { -dev_err (&pdev->dev,"no irq for node %s\n" , np->full_name); +dev_err (&pdev->dev,"no irq for node %s\n" , pdev->name);return irq; }
Signature · 1 line
1.9.1
Fabio Estevam
reviewerPATCH 5/5 ASoC: fsl_spdif: Make error message concise
In reply to Fabio EstevamFrom: Fabio Estevam <[email protected]>
Currently the error message uses 'np->full_name' which leads to a very verbose log that contains the full path of the node.
We can have a concise log by using pdev->name instead.
--- sound/soc/fsl/fsl_spdif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/fsl/fsl_spdif.c +1 -1
@@ -1189,7 +1189,7 @@ static int fsl_spdif_probe(struct platform_device *pdev) irq =platform_get_irq (pdev,0 );if (irq <0 ) { -dev_err (&pdev->dev,"no irq for node %s\n" , np->full_name); +dev_err (&pdev->dev,"no irq for node %s\n" , pdev->name);return irq; }
Signature · 1 line
1.9.1
Quoted 5 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
Currently the error message uses '
np->full_name' which leads to a very verbose log as:
Quoted 7 lines
fsl-ssi-dai 202c000.ssi: no irq for node /soc/aips-bus@02000000/spba-bus@02000000/ssi@0202c000
We can have a concise log by using
pdev->nameinstead:fsl-ssi-dai 202c000.ssi: no irq for node 202c000.ssi
Signed-off-by Fabio Estevam <[email protected]>
For all these 5 patches,
Thank you
Nicolin
Quoted 20 lines
--- sound/soc/fsl/fsl_ssi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)sound/soc/fsl/fsl_ssi.c +1
-1@@ -1363,7 +1363,7 @@ static int fsl_ssi_probe(struct platform_device *pdev) ssi_private->irq =platform_get_irq (pdev,0 );if (!ssi_private->irq) { -dev_err (&pdev->dev,"no irq for node %s\n" , np->full_name); +dev_err (&pdev->dev,"no irq for node %s\n" , pdev->name);return -ENXIO ; }Signature · 1 line
1.9.1
Quoted 4 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
Currently the error message uses '
np->full_name' which leads to a very verbose log as:
Applied all, thanks.