Skip to contentSkip to conversation

ast: Add error when trying to use dash in sh function names

PATCH New Richard Purdie 1 participant 1 message Jan 8, 2015

lore
Share & tools
lore

Richard Purdie

author
#0 lore raw

PATCH 1/1 ast: Add error when trying to use dash in sh function names

A dash character is illegal in function names in sh (but not bash). Since our shell tasks run under sh and the shell parser is sh based, EXPORT_FUNCTIONS won't work with class names containing a dash.

We can't change sh, we can ensure the user is warned about the problem straight away though.

[YOCTO #7006]

Signed-off-by Richard Purdie <[email protected]>
bitbake/lib/bb/parse/ast.py +2 -0
index af42a0c..879c9d2 100644
@@ -226,6 +226,8 @@ class ExportFuncsNode(AstNode):
             if data.getVarFlag(calledfunc, "python"):
                 data.setVar(func, "    bb.build.exec_func('" + calledfunc + "', d)\n")
             else:
+                if "-" in self.classname:
+                   bb.fatal("The classname %s contains a dash character and is calling an sh function %s using EXPORT_FUNCTIONS. Since a dash is illegal in sh function names, this cannot work, please rename the class or don't use EXPORT_FUNCTIONS." % (self.classname, calledfunc))
                 data.setVar(func, "    " + calledfunc + "\n")
             data.setVarFlag(func, 'export_func', '1')