Skip to contentSkip to conversation

ia64: use current->state helpers

PATCH Davidlohr Bueso 1 participant 2 messages Jan 15, 2015 – Jan 19, 2015 ptrace support

lore
Share & tools
lore
#0 lore raw

Call __set_current_state() instead of assigning the new state directly. These interfaces also aid CONFIG_DEBUG_ATOMIC_SLEEP environments, keeping track of who changed the state.

---
Completely untested.

 arch/ia64/kernel/mca.c    | 2 +-
 arch/ia64/kernel/ptrace.c | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
arch/ia64/kernel/mca.c +1 -1
index 8bfd36a..9797d01 100644
@@ -1821,7 +1821,7 @@ format_mca_init_stack(void *mca_data, unsigned long offset,
 	ti->task = p;
 	ti->cpu = cpu;
 	p->stack = ti;
-	p->state = TASK_UNINTERRUPTIBLE;
+	__set_task_state(p, TASK_UNINTERRUPTIBLE);
 	cpu_set(cpu, p->cpus_allowed);
 	INIT_LIST_HEAD(&p->tasks);
 	p->parent = p->real_parent = p->group_leader = p;
arch/ia64/kernel/ptrace.c +2 -2
index 6f54d51..67bb42c 100644
@@ -643,7 +643,7 @@ ptrace_attach_sync_user_rbs (struct task_struct *child)
 		    !test_and_set_tsk_thread_flag(child, TIF_RESTORE_RSE)) {
 			set_notify_resume(child);
 
-			child->state = TASK_TRACED;
+			__set_task_state(child, TASK_TRACED);
 			stopped = 1;
 		}
 		spin_unlock_irq(&child->sighand->siglock);
@@ -665,7 +665,7 @@ ptrace_attach_sync_user_rbs (struct task_struct *child)
 		spin_lock_irq(&child->sighand->siglock);
 		if (child->state = TASK_TRACED &&
 		    (child->signal->flags & SIGNAL_STOP_STOPPED)) {
-			child->state = TASK_STOPPED;
+			__set_task_state(child, TASK_STOPPED);
 		}
 		spin_unlock_irq(&child->sighand->siglock);
 	}
Signature · 1 line
2.1.2
#1 lore raw
Quoted 3 lines · Davidlohr Bueso

Call __set_current_state() instead of assigning the new state directly. These interfaces also aid CONFIG_DEBUG_ATOMIC_SLEEP environments, keeping track of who changed the state.

ping?