Skip to contentSkip to conversation

mm/vmscan: fix highidx argument type

PATCH In review Michael S. Tsirkin 3 participants 5 messages Jan 15, 2015 – Jan 16, 2015

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mm/vmscan: fix highidx argument type

for_each_zone_zonelist_nodemask wants an enum zone_type argument, but is passed gfp_t:

mm/vmscan.c:2658:9: expected int enum zone_type [signed] highest_zoneidx
mm/vmscan.c:2658:9: got restricted gfp_t [usertype] gfp_mask
mm/vmscan.c:2658:9: warning: incorrect type in argument 2 (different base types)
mm/vmscan.c:2658:9: expected int enum zone_type [signed] highest_zoneidx
mm/vmscan.c:2658:9: got restricted gfp_t [usertype] gfp_mask

convert argument to the correct type.

---

In case this was already fixed, pls ignore - seems to still be there in latest master.

 mm/vmscan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mm/vmscan.c +1 -1
index ab2505c..dcd90c8 100644
@@ -2656,7 +2656,7 @@ static bool throttle_direct_reclaim(gfp_t gfp_mask, struct zonelist *zonelist,
 	 * should make reasonable progress.
 	 */
 	for_each_zone_zonelist_nodemask(zone, z, zonelist,
-					gfp_mask, nodemask) {
+					gfp_zone(gfp_mask), nodemask) {
 		if (zone_idx(zone) > ZONE_NORMAL)
 			continue;
 
Signature · 1 line
MST
maintainer
#1 lore raw
Quoted 8 lines · On Fri, 16 Jan 2015 00:18:12 +0200 "Michael S. Tsirkin" <[email protected]> wrote:

for_each_zone_zonelist_nodemask wants an enum zone_type argument, but is passed gfp_t:

mm/vmscan.c:2658:9: expected int enum zone_type [signed] highest_zoneidx
mm/vmscan.c:2658:9: got restricted gfp_t [usertype] gfp_mask
mm/vmscan.c:2658:9: warning: incorrect type in argument 2 (different base types)
mm/vmscan.c:2658:9: expected int enum zone_type [signed] highest_zoneidx
mm/vmscan.c:2658:9: got restricted gfp_t [usertype] gfp_mask

Which tool emitted these warnings?

Quoted 7 lines

convert argument to the correct type.

...

mm/vmscan.c static bool throttle_direct_reclaim(gfp_t gfp_mask, struct zonelist *zonelist, · line 2661

Quoted 7 lines
mm/vmscan.c +1 -1
@@ -2656,7 +2656,7 @@ static bool throttle_direct_reclaim(gfp_t gfp_mask, struct zonelist *zonelist,
 	 * should make reasonable progress.
 	 */
 	for_each_zone_zonelist_nodemask(zone, z, zonelist,
-					gfp_mask, nodemask) {
+					gfp_zone(gfp_mask), nodemask) {
 		if (zone_idx(zone) > ZONE_NORMAL)
 			continue;

hm, I wonder what the runtime effects are.

The throttle_direct_reclaim() comment isn't really accurate, is it? "Throttle direct reclaimers if backing storage is backed by the network". The code is applicable to all types of backing, but was added to address problems which are mainly observed with network backing?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

#2 lore raw
Quoted 5 lines · Andrew Morton
Quoted 3 lines · On Fri, 16 Jan 2015 00:18:12 +0200 "Michael S. Tsirkin" <[email protected]> wrote:

for_each_zone_zonelist_nodemask wants an enum zone_type argument, but is passed gfp_t:

Quoted 7 lines
Quoted 5 lines

mm/vmscan.c:2658:9: expected int enum zone_type [signed] highest_zoneidx
mm/vmscan.c:2658:9: got restricted gfp_t [usertype] gfp_mask
mm/vmscan.c:2658:9: warning: incorrect type in argument 2 (different base types)
mm/vmscan.c:2658:9: expected int enum zone_type [signed] highest_zoneidx
mm/vmscan.c:2658:9: got restricted gfp_t [usertype] gfp_mask

Which tool emitted these warnings?

Oh, sorry.
It's sparce.

Quoted 17 lines
Quoted 7 lines

convert argument to the correct type.

...

mm/vmscan.c static bool throttle_direct_reclaim(gfp_t gfp_mask, struct zonelist *zonelist, · line 2661

Quoted 7 lines
mm/vmscan.c +1 -1
@@ -2656,7 +2656,7 @@ static bool throttle_direct_reclaim(gfp_t gfp_mask, struct zonelist *zonelist,
 	 * should make reasonable progress.
 	 */
 	for_each_zone_zonelist_nodemask(zone, z, zonelist,
-					gfp_mask, nodemask) {
+					gfp_zone(gfp_mask), nodemask) {
 		if (zone_idx(zone) > ZONE_NORMAL)
 			continue;

hm, I wonder what the runtime effects are.

Quoted 5 lines

The throttle_direct_reclaim() comment isn't really accurate, is it? "Throttle direct reclaimers if backing storage is backed by the network". The code is applicable to all types of backing, but was added to address problems which are mainly observed with network backing?

As far as I can tell, yes. It would seem that it can cause deadlocks in theory. Cc stable on the grounds that it's obvious?

Signature · 1 line
MST
#3 lore raw
Quoted 12 lines · Michael S. Tsirkin
Quoted 11 lines · Andrew Morton
Quoted 8 lines · On Fri, 16 Jan 2015 00:18:12 +0200 "Michael S. Tsirkin" <[email protected]> wrote:

for_each_zone_zonelist_nodemask wants an enum zone_type argument, but is passed gfp_t:

mm/vmscan.c:2658:9: expected int enum zone_type [signed] highest_zoneidx
mm/vmscan.c:2658:9: got restricted gfp_t [usertype] gfp_mask
mm/vmscan.c:2658:9: warning: incorrect type in argument 2 (different base types)
mm/vmscan.c:2658:9: expected int enum zone_type [signed] highest_zoneidx
mm/vmscan.c:2658:9: got restricted gfp_t [usertype] gfp_mask

Quoted 21 lines
Quoted 1 line

Which tool emitted these warnings?

Oh, sorry.
It's sparce.

Quoted 16 lines
Quoted 7 lines

convert argument to the correct type.

...

mm/vmscan.c static bool throttle_direct_reclaim(gfp_t gfp_mask, struct zonelist *zonelist, · line 2661

Quoted 7 lines
mm/vmscan.c +1 -1
@@ -2656,7 +2656,7 @@ static bool throttle_direct_reclaim(gfp_t gfp_mask, struct zonelist *zonelist,
 	 * should make reasonable progress.
 	 */
 	for_each_zone_zonelist_nodemask(zone, z, zonelist,
-					gfp_mask, nodemask) {
+					gfp_zone(gfp_mask), nodemask) {
 		if (zone_idx(zone) > ZONE_NORMAL)
 			continue;

hm, I wonder what the runtime effects are.

So this was introduced by 675becce15f "mm: vmscan: do not throttle based on pfmemalloc reserves if node has no ZONE_NORMAL" in 3.15. AFAICS gfp_mask >= gfp_zone(gfp_mask), so the high_zoneidx will be higher than it should, and next_zones_zonelist() won't filter the higher-than-wanted zones as it should.

I guess the runtime effects is that allocations for zone_type < NORMAL, i.e. DMA32 or DMA, can now wrongly choose a numa node without such zones, for checking pfmemalloc reserves and throttling. Which means the throttling can be ineffective, or it could also throttle without actually needing to, if the wrong zone has lower reserves? Mel?

Quoted 5 lines
Quoted 5 lines

The throttle_direct_reclaim() comment isn't really accurate, is it? "Throttle direct reclaimers if backing storage is backed by the network". The code is applicable to all types of backing, but was added to address problems which are mainly observed with network backing?

I guess. I also don't see any code restricting this just for network.

Quoted 4 lines

As far as I can tell, yes. It would seem that it can cause deadlocks in theory. Cc stable on the grounds that it's obvious?

I don't think this mistake can introduce deadlocks on its own, but it also won't prevent any problems that the throttling was suppsoed to prevent.
I agree it should go stable.

BTW, I wonder if the whole code couldn't be much simpler by capping high_zoneidx by ZONE_NORMAL before traversing the zonelist, like this:

int high_zoneidx = min(gfp_zone(gfp_mask), ZONE_NORMAL);

first_zones_zonelist(zonelist, high_zoneidx, NULL, &zone); pgdat = zone->zone_pgdat;

if (!pgdat || pfmemalloc_watermark_ok(pgdat))

	goto out;

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

#4 lore raw
Quoted 6 lines · Vlastimil Babka

BTW, I wonder if the whole code couldn't be much simpler by capping high_zoneidx by ZONE_NORMAL before traversing the zonelist, like this:

int high_zoneidx = min(gfp_zone(gfp_mask), ZONE_NORMAL);

first_zones_zonelist(zonelist, high_zoneidx, NULL, &zone);

Erm, s/NULL/nodemask/ here. I copy/pasted this from before 675becce15f32, where it didn't actually use the nodemask parameter of throttle_direct_reclaim(), Wonder why, looks like another bug to me, that the commit has silently fixed.

Quoted 12 lines

pgdat = zone->zone_pgdat;

if (!pgdat || pfmemalloc_watermark_ok(pgdat))

	goto out;

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>