s390: Dump check for CONFIG_ZFCPDUMP
PATCH 1/1 s390: Dump check for CONFIG_ZFCPDUMP
Commit 725908110a1f ("s390: add SMT support") added a check for CONFIG_ZFCPDUMP. But the Kconfig symbol ZFCPDUMP was removed in v3.16 through commit bf28a5970de3 ("s390/dump: Remove CONFIG_ZFCPDUMP"). So this check will always evaluate to false. No one noticed probably because the code also checks for CONFIG_CRASH_DUMP which "also enables s390 zfcpdump".
Dump the unneeded check.
---
This trivial issue popped up in next-20150116. If s390 commits can still be altered after they've hit linux-next this might just as well be folded into commit 725908110a1f ("s390: add SMT support").
Entirely untested!
arch/s390/kernel/smp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/s390/kernel/smp.c +1 -1
@@ -762,7 +762,7 @@ static void __init smp_detect_cpus(void)panic ("Could not find boot CPU type" ); } -#if defined(CONFIG_ZFCPDUMP ) || defined(CONFIG_CRASH_DUMP ) +#if defined(CONFIG_CRASH_DUMP )/* Collect CPU state of previous system */ smp_store_cpu_states (info);#endif
Signature · 1 line
1.9.3
Heiko Carstens
AppliedQuoted 10 lines · Paul Bolle
Commit
725908110a1f("s390: add SMT support") added a check forCONFIG_ZFCPDUMP. But theKconfigsymbol ZFCPDUMP was removed in v3.16 through commitbf28a5970de3("s390/dump: RemoveCONFIG_ZFCPDUMP"). So this check will always evaluate to false. No one noticed probably because the code also checks forCONFIG_CRASH_DUMPwhich "also enables s390 zfcpdump".Dump the unneeded check.
Signed-off-by Paul Bolle <[email protected]>
Applied, thanks.