Skip to contentSkip to conversation

x86: Fix various code format issues in start16.S

PATCH New Bin Meng 2 participants 3 messages Jan 20, 2015 – Jan 23, 2015 x86

lore
Share & tools
lore

Bin Meng

author
#0 lore raw

PATCH 1/1 x86: Fix various code format issues in start16.S

Various minor code format issues are fixed in start16.S:
- U-boot -> U-Boot
- 32bit -> 32-bit
- Use TAB instead of SPACE to indent
- Move the indention location of the GDT comment block

Signed-off-by Bin Meng <[email protected]>

---

 arch/x86/cpu/start16.S | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)
arch/x86/cpu/start16.S +10 -10
index 9550502..826e2b4 100644
@@ -1,5 +1,5 @@
 /*
- *  U-boot - x86 Startup Code
+ *  U-Boot - x86 Startup Code
  *
  * (C) Copyright 2008-2011
  * Graeme Russ, <[email protected]>

@@ -28,7 +28,7 @@ start16:
 	movl	$GD_FLG_COLD_BOOT, %ebx
 
 	xorl	%eax, %eax
-	movl	%eax, %cr3    /* Invalidate TLB */
+	movl	%eax, %cr3	/* Invalidate TLB */
 
 	/* Turn off cache (this might require a 486-class CPU) */
 	movl	%cr0, %eax

@@ -49,7 +49,7 @@ o32 cs	lgdt	gdt_ptr
 	jmp	ff
 ff:
 
-	/* Finally restore BIST and jump to the 32bit initialization code */
+	/* Finally restore BIST and jump to the 32-bit initialization code */
 	movw	$code32start, %ax
 	movw	%ax, %bp
 	movl	%ecx, %eax

@@ -64,17 +64,17 @@ idt_ptr:
 	.word	0		/* limit */
 	.long	0		/* base */
 
-/*
- * The following Global Descriptor Table is just enough to get us into
- * 'Flat Protected Mode' - It will be discarded as soon as the final
- * GDT is setup in a safe location in RAM
- */
+	/*
+	 * The following Global Descriptor Table is just enough to get us into
+	 * 'Flat Protected Mode' - It will be discarded as soon as the final
+	 * GDT is setup in a safe location in RAM
+	 */
 gdt_ptr:
 	.word	0x1f		/* limit (31 bytes = 4 GDT entries - 1) */
 	.long	BOOT_SEG + gdt	/* base */
 
-/* Some CPUs are picky about GDT alignment... */
-.align 16
+	/* Some CPUs are picky about GDT alignment... */
+	.align	16
 gdt:
 	/*
 	 * The GDT table ...
Signature · 1 line
1.8.2.1
#1 lore raw

PATCH 1/1 x86: Fix various code format issues in start16.S

Quoted 11 lines · Bin Meng

Various minor code format issues are fixed in start16.S:
- U-boot -> U-Boot
- 32bit -> 32-bit
- Use TAB instead of SPACE to indent
- Move the indention location of the GDT comment block

Signed-off-by Bin Meng <[email protected]>

---

 arch/x86/cpu/start16.S | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)
Acked-by Simon Glass <[email protected]>
#2 lore raw

PATCH 1/1 x86: Fix various code format issues in start16.S

Quoted 8 lines · Simon Glass
Quoted 6 lines · Bin Meng

Various minor code format issues are fixed in start16.S:
- U-boot -> U-Boot
- 32bit -> 32-bit
- Use TAB instead of SPACE to indent
- Move the indention location of the GDT comment block

Quoted 7 lines
Quoted 5 lines
Signed-off-by Bin Meng <[email protected]>

---

 arch/x86/cpu/start16.S | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)
Acked-by Simon Glass <[email protected]>

Applied to u-boot-x86, thanks!