Skip to contentSkip to conversation

drm/tegra: Fix copypasta in host1x_reloc_copy_from_user

PATCH In review David Ung 2 participants 2 messages Jan 21, 2015 – Jan 23, 2015 1 message not in the archive

Subsystems (3)
lore
Share & tools
lore

David Ung

author
#0 lore raw

PATCH 1/1 drm/tegra: Fix copypasta in host1x_reloc_copy_from_user

Fix copypasta bug for function host1x_reloc_copy_from_user.

---
 drivers/gpu/drm/tegra/drm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/tegra/drm.c +1 -1
index d4f8275..d8c9fb7 100644
@@ -190,7 +190,7 @@ static int host1x_reloc_copy_from_user(struct host1x_reloc *dest,
 	if (err < 0)
 		return err;
 
-	err = get_user(dest->target.offset, &src->cmdbuf.offset);
+	err = get_user(dest->target.offset, &src->target.offset);
 	if (err < 0)
 		return err;
 
Signature · 1 line
1.8.1.5
#2 lore raw
In reply to a message not in the archive
Quoted 6 lines · David Ung

Fix copypasta bug for function host1x_reloc_copy_from_user.

---
 drivers/gpu/drm/tegra/drm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

I've applied this with a reworded commit message and added a proper
Fixes: tag. It should also go to stable because the offending commit was merged in v3.17. Yay for not having automated test procedures that could have easily caught this...

Thierry