Skip to contentSkip to conversation

libxl: add one machine property to support IGD GFX passthrough

RFC PATCH Superseded Tiejun Chen 6 participants 39 messages Jan 21, 2015 – Feb 2, 2015

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 libxl: add one machine property to support IGD GFX passthrough

When we're working to support IGD GFX passthrough with qemu upstream, instead of "-gfx_passthru" we'd like to make that a machine option, "-machine xxx,gfx_passthru=on". This need to bring several changes on tool side.

---
 tools/libxl/libxl_dm.c | 19 +++++++++++++++++--
 1 file changed, 17 insertions(+), 2 deletions(-)
tools/libxl/libxl_dm.c +17 -2
index c2b0487..2b59d2c 100644
@@ -318,7 +318,10 @@ static char ** libxl__build_device_model_args_old(libxl__gc *gc,
             flexarray_vappend(dm_args, "-net", "none", NULL);
         }
         if (libxl_defbool_val(b_info->u.hvm.gfx_passthru)) {
-            flexarray_append(dm_args, "-gfx_passthru");
+            if (b_info->device_model_version !=
+                LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN) {
+                flexarray_append(dm_args, "-gfx_passthru");
+            }
         }
     } else {
         if (!sdl && !vnc)
@@ -702,7 +705,10 @@ static char ** libxl__build_device_model_args_new(libxl__gc *gc,
             flexarray_append(dm_args, "none");
         }
         if (libxl_defbool_val(b_info->u.hvm.gfx_passthru)) {
-            flexarray_append(dm_args, "-gfx_passthru");
+            if (b_info->device_model_version !=
+                LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN) {
+                flexarray_append(dm_args, "-gfx_passthru");
+            }
         }
     } else {
         if (!sdl && !vnc) {
@@ -748,6 +754,15 @@ static char ** libxl__build_device_model_args_new(libxl__gc *gc,
                                             machinearg, max_ram_below_4g);
             }
         }
+
+        if (b_info->device_model_version ==
+            LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN) {
+            if (libxl_defbool_val(b_info->u.hvm.gfx_passthru)) {
+                machinearg = libxl__sprintf(gc, "%s,gfx_passthru=on",
+                                            machinearg);
+            }
+        }
+
         flexarray_append(dm_args, machinearg);
         for (i = 0; b_info->extra_hvm && b_info->extra_hvm[i] != NULL; i++)
             flexarray_append(dm_args, b_info->extra_hvm[i]);
Signature · 1 line
1.9.1
#1 lore raw

CCed Stefano.

Thanks
Tiejun

Quoted 55 lines · Tiejun Chen

When we're working to support IGD GFX passthrough with qemu upstream, instead of "-gfx_passthru" we'd like to make that a machine option, "-machine xxx,gfx_passthru=on". This need to bring several changes on tool side.

---
  tools/libxl/libxl_dm.c | 19 +++++++++++++++++--
  1 file changed, 17 insertions(+), 2 deletions(-)
tools/libxl/libxl_dm.c +17 -2
index c2b0487..2b59d2c 100644
@@ -318,7 +318,10 @@ static char ** libxl__build_device_model_args_old(libxl__gc *gc,
              flexarray_vappend(dm_args, "-net", "none", NULL);
          }
          if (libxl_defbool_val(b_info->u.hvm.gfx_passthru)) {
-            flexarray_append(dm_args, "-gfx_passthru");
+            if (b_info->device_model_version !=
+                LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN) {
+                flexarray_append(dm_args, "-gfx_passthru");
+            }
          }
      } else {
          if (!sdl && !vnc)
@@ -702,7 +705,10 @@ static char ** libxl__build_device_model_args_new(libxl__gc *gc,
              flexarray_append(dm_args, "none");
          }
          if (libxl_defbool_val(b_info->u.hvm.gfx_passthru)) {
-            flexarray_append(dm_args, "-gfx_passthru");
+            if (b_info->device_model_version !=
+                LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN) {
+                flexarray_append(dm_args, "-gfx_passthru");
+            }
          }
      } else {
          if (!sdl && !vnc) {
@@ -748,6 +754,15 @@ static char ** libxl__build_device_model_args_new(libxl__gc *gc,
                                              machinearg, max_ram_below_4g);
              }
          }
+
+        if (b_info->device_model_version ==
+            LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN) {
+            if (libxl_defbool_val(b_info->u.hvm.gfx_passthru)) {
+                machinearg = libxl__sprintf(gc, "%s,gfx_passthru=on",
+                                            machinearg);
+            }
+        }
+
          flexarray_append(dm_args, machinearg);
          for (i = 0; b_info->extra_hvm && b_info->extra_hvm[i] != NULL; i++)
              flexarray_append(dm_args, b_info->extra_hvm[i]);
#2 lore raw
In reply to Tiejun Chen

CCed Stefano.

Thanks
Tiejun

Quoted 55 lines · Tiejun Chen

When we're working to support IGD GFX passthrough with qemu upstream, instead of "-gfx_passthru" we'd like to make that a machine option, "-machine xxx,gfx_passthru=on". This need to bring several changes on tool side.

---
  tools/libxl/libxl_dm.c | 19 +++++++++++++++++--
  1 file changed, 17 insertions(+), 2 deletions(-)
tools/libxl/libxl_dm.c +17 -2
index c2b0487..2b59d2c 100644
@@ -318,7 +318,10 @@ static char ** libxl__build_device_model_args_old(libxl__gc *gc,
              flexarray_vappend(dm_args, "-net", "none", NULL);
          }
          if (libxl_defbool_val(b_info->u.hvm.gfx_passthru)) {
-            flexarray_append(dm_args, "-gfx_passthru");
+            if (b_info->device_model_version !=
+                LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN) {
+                flexarray_append(dm_args, "-gfx_passthru");
+            }
          }
      } else {
          if (!sdl && !vnc)
@@ -702,7 +705,10 @@ static char ** libxl__build_device_model_args_new(libxl__gc *gc,
              flexarray_append(dm_args, "none");
          }
          if (libxl_defbool_val(b_info->u.hvm.gfx_passthru)) {
-            flexarray_append(dm_args, "-gfx_passthru");
+            if (b_info->device_model_version !=
+                LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN) {
+                flexarray_append(dm_args, "-gfx_passthru");
+            }
          }
      } else {
          if (!sdl && !vnc) {
@@ -748,6 +754,15 @@ static char ** libxl__build_device_model_args_new(libxl__gc *gc,
                                              machinearg, max_ram_below_4g);
              }
          }
+
+        if (b_info->device_model_version ==
+            LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN) {
+            if (libxl_defbool_val(b_info->u.hvm.gfx_passthru)) {
+                machinearg = libxl__sprintf(gc, "%s,gfx_passthru=on",
+                                            machinearg);
+            }
+        }
+
          flexarray_append(dm_args, machinearg);
          for (i = 0; b_info->extra_hvm && b_info->extra_hvm[i] != NULL; i++)
              flexarray_append(dm_args, b_info->extra_hvm[i]);
#3 lore raw
In reply to Tiejun Chen

Tiejun Chen writes ("[RFC][PATCH 1/1] libxl: add one machine property to support IGD GFX passthrough"):

Quoted 4 lines

When we're working to support IGD GFX passthrough with qemu upstream, instead of "-gfx_passthru" we'd like to make that a machine option, "-machine xxx,gfx_passthru=on". This need to bring several changes on tool side.

Has the corresponding patch to qemu-upstream been accepted yet ?

I'd like to see a confirmation from the qemu side that this is going into their tree and that the command-line option syntax has been agreed.

Thanks,
Ian.

#4 lore raw
In reply to Tiejun Chen

Tiejun Chen writes ("[RFC][PATCH 1/1] libxl: add one machine property to support IGD GFX passthrough"):

Quoted 4 lines

When we're working to support IGD GFX passthrough with qemu upstream, instead of "-gfx_passthru" we'd like to make that a machine option, "-machine xxx,gfx_passthru=on". This need to bring several changes on tool side.

Has the corresponding patch to qemu-upstream been accepted yet ?

I'd like to see a confirmation from the qemu side that this is going into their tree and that the command-line option syntax has been agreed.

Thanks,
Ian.

#5 lore raw
Quoted 11 lines · Ian Jackson

Tiejun Chen writes ("[RFC][PATCH 1/1] libxl: add one machine property to support IGD GFX passthrough"):

Quoted 4 lines

When we're working to support IGD GFX passthrough with qemu upstream, instead of "-gfx_passthru" we'd like to make that a machine option, "-machine xxx,gfx_passthru=on". This need to bring several changes on tool side.

Has the corresponding patch to qemu-upstream been accepted yet ?

I'd like to see a confirmation from the qemu side that this is going into their tree and that the command-line option syntax has been agreed.

Do we need to detect old vs. new qemu to know when this option is valid?

Ian.

#6 lore raw
In reply to Ian Jackson
Quoted 11 lines · Ian Jackson

Tiejun Chen writes ("[RFC][PATCH 1/1] libxl: add one machine property to support IGD GFX passthrough"):

Quoted 4 lines

When we're working to support IGD GFX passthrough with qemu upstream, instead of "-gfx_passthru" we'd like to make that a machine option, "-machine xxx,gfx_passthru=on". This need to bring several changes on tool side.

Has the corresponding patch to qemu-upstream been accepted yet ?

I'd like to see a confirmation from the qemu side that this is going into their tree and that the command-line option syntax has been agreed.

Do we need to detect old vs. new qemu to know when this option is valid?

Ian.

#9 lore raw
In reply to Ian Jackson
Quoted 11 lines · Ian Jackson

Tiejun Chen writes ("[RFC][PATCH 1/1] libxl: add one machine property to support IGD GFX passthrough"):

Quoted 4 lines

When we're working to support IGD GFX passthrough with qemu upstream, instead of "-gfx_passthru" we'd like to make that a machine option, "-machine xxx,gfx_passthru=on". This need to bring several changes on tool side.

Has the corresponding patch to qemu-upstream been accepted yet ?

I'd like to see a confirmation from the qemu side that this is going into their tree and that the command-line option syntax has been agreed.

Suggested at patch review, not merged (guess thats why it is tagged 'rfc', to get both qemu+xen on the same page).

While being at it: Should we name this 'igd-passthru' instead of 'gfx-passthru'? The hostbridge / isabridge quirks needed are actually specific to igd and are not needed for -- say -- nvidia gfx cards.

cheers,
Gerd

#10 lore raw
In reply to Ian Jackson
Quoted 11 lines · Ian Jackson

Tiejun Chen writes ("[RFC][PATCH 1/1] libxl: add one machine property to support IGD GFX passthrough"):

Quoted 4 lines

When we're working to support IGD GFX passthrough with qemu upstream, instead of "-gfx_passthru" we'd like to make that a machine option, "-machine xxx,gfx_passthru=on". This need to bring several changes on tool side.

Has the corresponding patch to qemu-upstream been accepted yet ?

I'd like to see a confirmation from the qemu side that this is going into their tree and that the command-line option syntax has been agreed.

Suggested at patch review, not merged (guess thats why it is tagged 'rfc', to get both qemu+xen on the same page).

While being at it: Should we name this 'igd-passthru' instead of 'gfx-passthru'? The hostbridge / isabridge quirks needed are actually specific to igd and are not needed for -- say -- nvidia gfx cards.

cheers,
Gerd

#11 lore raw
Quoted 7 lines · Gerd Hoffmann
Quoted 6 lines · Ian Jackson

Tiejun Chen writes ("[RFC][PATCH 1/1] libxl: add one machine property to support IGD GFX passthrough"):

Quoted 4 lines

When we're working to support IGD GFX passthrough with qemu upstream, instead of "-gfx_passthru" we'd like to make that a machine option, "-machine xxx,gfx_passthru=on". This need to bring several changes on tool side.

Quoted 8 lines
Quoted 5 lines

Has the corresponding patch to qemu-upstream been accepted yet ?

I'd like to see a confirmation from the qemu side that this is going into their tree and that the command-line option syntax has been agreed.

Suggested at patch review, not merged (guess thats why it is tagged 'rfc', to get both qemu+xen on the same page).

Yeah, this is exactly what I intended to do here :)

Quoted 5 lines

While being at it: Should we name this 'igd-passthru' instead of 'gfx-passthru'? The hostbridge / isabridge quirks needed are actually specific to igd and are not needed for -- say -- nvidia gfx cards.

At this point I just concern here if we still use 'gfx_passthrou', at least it may look like a backward compatibility with older versions of qemu in Xen side, qemu-xen-traditional. But I'd like to follow your final option.

Thanks
Tiejun

#12 lore raw
In reply to Gerd Hoffmann
Quoted 7 lines · Gerd Hoffmann
Quoted 6 lines · Ian Jackson

Tiejun Chen writes ("[RFC][PATCH 1/1] libxl: add one machine property to support IGD GFX passthrough"):

Quoted 4 lines

When we're working to support IGD GFX passthrough with qemu upstream, instead of "-gfx_passthru" we'd like to make that a machine option, "-machine xxx,gfx_passthru=on". This need to bring several changes on tool side.

Quoted 8 lines
Quoted 5 lines

Has the corresponding patch to qemu-upstream been accepted yet ?

I'd like to see a confirmation from the qemu side that this is going into their tree and that the command-line option syntax has been agreed.

Suggested at patch review, not merged (guess thats why it is tagged 'rfc', to get both qemu+xen on the same page).

Yeah, this is exactly what I intended to do here :)

Quoted 5 lines

While being at it: Should we name this 'igd-passthru' instead of 'gfx-passthru'? The hostbridge / isabridge quirks needed are actually specific to igd and are not needed for -- say -- nvidia gfx cards.

At this point I just concern here if we still use 'gfx_passthrou', at least it may look like a backward compatibility with older versions of qemu in Xen side, qemu-xen-traditional. But I'd like to follow your final option.

Thanks
Tiejun

#7 lore raw
In reply to Ian Campbell
Quoted 7 lines · Ian Campbell
Quoted 6 lines · Ian Jackson

Tiejun Chen writes ("[RFC][PATCH 1/1] libxl: add one machine property to support IGD GFX passthrough"):

Quoted 4 lines

When we're working to support IGD GFX passthrough with qemu upstream, instead of "-gfx_passthru" we'd like to make that a machine option, "-machine xxx,gfx_passthru=on". This need to bring several changes on tool side.

Quoted 7 lines
Quoted 5 lines

Has the corresponding patch to qemu-upstream been accepted yet ?

I'd like to see a confirmation from the qemu side that this is going into their tree and that the command-line option syntax has been agreed.

Do we need to detect old vs. new qemu to know when this option is valid?

Do you mean we should introduce these two options into qemu upstream at the same time? Here I just keep that new option, and that old is gone.

Thanks
Tiejun

#8 lore raw
In reply to Ian Campbell
Quoted 7 lines · Ian Campbell
Quoted 6 lines · Ian Jackson

Tiejun Chen writes ("[RFC][PATCH 1/1] libxl: add one machine property to support IGD GFX passthrough"):

Quoted 4 lines

When we're working to support IGD GFX passthrough with qemu upstream, instead of "-gfx_passthru" we'd like to make that a machine option, "-machine xxx,gfx_passthru=on". This need to bring several changes on tool side.

Quoted 7 lines
Quoted 5 lines

Has the corresponding patch to qemu-upstream been accepted yet ?

I'd like to see a confirmation from the qemu side that this is going into their tree and that the command-line option syntax has been agreed.

Do we need to detect old vs. new qemu to know when this option is valid?

Do you mean we should introduce these two options into qemu upstream at the same time? Here I just keep that new option, and that old is gone.

Thanks
Tiejun

#13 lore raw
In reply to Chen, Tiejun
Quoted 26 lines · Tiejun
Quoted 8 lines · Gerd Hoffmann
Quoted 7 lines · Ian Jackson

Tiejun Chen writes ("[RFC][PATCH 1/1] libxl: add one machine property to support IGD GFX passthrough"):

Quoted 4 lines

When we're working to support IGD GFX passthrough with qemu upstream, instead of "-gfx_passthru" we'd like to make that a machine option, "-machine xxx,gfx_passthru=on". This need to bring several changes on tool side.

Quoted 8 lines
Quoted 5 lines

Has the corresponding patch to qemu-upstream been accepted yet ?

I'd like to see a confirmation from the qemu side that this is going into their tree and that the command-line option syntax has been agreed.

Suggested at patch review, not merged (guess thats why it is tagged 'rfc', to get both qemu+xen on the same page).

Yeah, this is exactly what I intended to do here :)

Quoted 5 lines

While being at it: Should we name this 'igd-passthru' instead of 'gfx-passthru'? The hostbridge / isabridge quirks needed are actually specific to igd and are not needed for -- say -- nvidia gfx cards.

Quoted 5 lines

At this point I just concern here if we still use 'gfx_passthrou', at least it may look like a backward compatibility with older versions of qemu in Xen side, qemu-xen-traditional. But I'd like to follow your final option.

Any feedback to this option I should follow here?

Thanks
Tiejun

#14 lore raw
In reply to Chen, Tiejun
Quoted 26 lines · Tiejun
Quoted 8 lines · Gerd Hoffmann
Quoted 7 lines · Ian Jackson

Tiejun Chen writes ("[RFC][PATCH 1/1] libxl: add one machine property to support IGD GFX passthrough"):

Quoted 4 lines

When we're working to support IGD GFX passthrough with qemu upstream, instead of "-gfx_passthru" we'd like to make that a machine option, "-machine xxx,gfx_passthru=on". This need to bring several changes on tool side.

Quoted 8 lines
Quoted 5 lines

Has the corresponding patch to qemu-upstream been accepted yet ?

I'd like to see a confirmation from the qemu side that this is going into their tree and that the command-line option syntax has been agreed.

Suggested at patch review, not merged (guess thats why it is tagged 'rfc', to get both qemu+xen on the same page).

Yeah, this is exactly what I intended to do here :)

Quoted 5 lines

While being at it: Should we name this 'igd-passthru' instead of 'gfx-passthru'? The hostbridge / isabridge quirks needed are actually specific to igd and are not needed for -- say -- nvidia gfx cards.

Quoted 5 lines

At this point I just concern here if we still use 'gfx_passthrou', at least it may look like a backward compatibility with older versions of qemu in Xen side, qemu-xen-traditional. But I'd like to follow your final option.

Any feedback to this option I should follow here?

Thanks
Tiejun

#15 lore raw
Quoted 27 lines · Tiejun
Quoted 26 lines · Tiejun
Quoted 8 lines · Gerd Hoffmann
Quoted 7 lines · Ian Jackson

Tiejun Chen writes ("[RFC][PATCH 1/1] libxl: add one machine property to support IGD GFX passthrough"):

Quoted 4 lines

When we're working to support IGD GFX passthrough with qemu upstream, instead of "-gfx_passthru" we'd like to make that a machine option, "-machine xxx,gfx_passthru=on". This need to bring several changes on tool side.

Quoted 8 lines
Quoted 5 lines

Has the corresponding patch to qemu-upstream been accepted yet ?

I'd like to see a confirmation from the qemu side that this is going into their tree and that the command-line option syntax has been agreed.

Suggested at patch review, not merged (guess thats why it is tagged 'rfc', to get both qemu+xen on the same page).

Yeah, this is exactly what I intended to do here :)

Quoted 5 lines

While being at it: Should we name this 'igd-passthru' instead of 'gfx-passthru'? The hostbridge / isabridge quirks needed are actually specific to igd and are not needed for -- say -- nvidia gfx cards.

Quoted 8 lines
Quoted 5 lines

At this point I just concern here if we still use 'gfx_passthrou', at least it may look like a backward compatibility with older versions of qemu in Xen side, qemu-xen-traditional. But I'd like to follow your final option.

Any feedback to this option I should follow here?

Ping...

Thanks
Tiejun

#16 lore raw
In reply to Chen, Tiejun
Quoted 27 lines · Tiejun
Quoted 26 lines · Tiejun
Quoted 8 lines · Gerd Hoffmann
Quoted 7 lines · Ian Jackson

Tiejun Chen writes ("[RFC][PATCH 1/1] libxl: add one machine property to support IGD GFX passthrough"):

Quoted 4 lines

When we're working to support IGD GFX passthrough with qemu upstream, instead of "-gfx_passthru" we'd like to make that a machine option, "-machine xxx,gfx_passthru=on". This need to bring several changes on tool side.

Quoted 8 lines
Quoted 5 lines

Has the corresponding patch to qemu-upstream been accepted yet ?

I'd like to see a confirmation from the qemu side that this is going into their tree and that the command-line option syntax has been agreed.

Suggested at patch review, not merged (guess thats why it is tagged 'rfc', to get both qemu+xen on the same page).

Yeah, this is exactly what I intended to do here :)

Quoted 5 lines

While being at it: Should we name this 'igd-passthru' instead of 'gfx-passthru'? The hostbridge / isabridge quirks needed are actually specific to igd and are not needed for -- say -- nvidia gfx cards.

Quoted 8 lines
Quoted 5 lines

At this point I just concern here if we still use 'gfx_passthrou', at least it may look like a backward compatibility with older versions of qemu in Xen side, qemu-xen-traditional. But I'd like to follow your final option.

Any feedback to this option I should follow here?

Ping...

Thanks
Tiejun

#17 lore raw

Chen, Tiejun writes ("Re: [Qemu-devel] [RFC][PATCH 1/1] libxl: add one machine property to support IGD GFX passthrough"):

Quoted 6 lines · Tiejun
Quoted 5 lines · Tiejun
Quoted 4 lines

At this point I just concern here if we still use 'gfx_passthrou', at least it may look like a backward compatibility with older versions of qemu in Xen side, qemu-xen-traditional. But I'd like to follow your final option.

...

Quoted 3 lines
Quoted 1 line

Any feedback to this option I should follow here?

Ping...

I think this is a question that qemu upstream should answer.

Thanks,
Ian.

#18 lore raw
In reply to Chen, Tiejun

Chen, Tiejun writes ("Re: [Qemu-devel] [RFC][PATCH 1/1] libxl: add one machine property to support IGD GFX passthrough"):

Quoted 6 lines · Tiejun
Quoted 5 lines · Tiejun
Quoted 4 lines

At this point I just concern here if we still use 'gfx_passthrou', at least it may look like a backward compatibility with older versions of qemu in Xen side, qemu-xen-traditional. But I'd like to follow your final option.

...

Quoted 3 lines
Quoted 1 line

Any feedback to this option I should follow here?

Ping...

I think this is a question that qemu upstream should answer.

Thanks,
Ian.

#19 lore raw
Quoted 7 lines · Ian Jackson

Chen, Tiejun writes ("Re: [Qemu-devel] [RFC][PATCH 1/1] libxl: add one machine property to support IGD GFX passthrough"):

Quoted 6 lines · Tiejun
Quoted 5 lines · Tiejun
Quoted 4 lines

At this point I just concern here if we still use 'gfx_passthrou', at least it may look like a backward compatibility with older versions of qemu in Xen side, qemu-xen-traditional. But I'd like to follow your final option.

Quoted 7 lines

...

Quoted 3 lines
Quoted 1 line

Any feedback to this option I should follow here?

Ping...

I think this is a question that qemu upstream should answer.

Actually this is just commented by Gerd in qemu upstream. So now looks in Xen side you guys don't have any objection to use 'igd-passthru' as well. If yes, I'm fine to adopt this.

Thanks
Tiejun

#20 lore raw
In reply to Ian Jackson
Quoted 7 lines · Ian Jackson

Chen, Tiejun writes ("Re: [Qemu-devel] [RFC][PATCH 1/1] libxl: add one machine property to support IGD GFX passthrough"):

Quoted 6 lines · Tiejun
Quoted 5 lines · Tiejun
Quoted 4 lines

At this point I just concern here if we still use 'gfx_passthrou', at least it may look like a backward compatibility with older versions of qemu in Xen side, qemu-xen-traditional. But I'd like to follow your final option.

Quoted 7 lines

...

Quoted 3 lines
Quoted 1 line

Any feedback to this option I should follow here?

Ping...

I think this is a question that qemu upstream should answer.

Actually this is just commented by Gerd in qemu upstream. So now looks in Xen side you guys don't have any objection to use 'igd-passthru' as well. If yes, I'm fine to adopt this.

Thanks
Tiejun

#21 lore raw
Quoted 11 lines · Tiejun
Quoted 10 lines · Ian Jackson

Chen, Tiejun writes ("Re: [Qemu-devel] [RFC][PATCH 1/1] libxl: add one machine property to support IGD GFX passthrough"):

Quoted 6 lines · Tiejun
Quoted 5 lines · Tiejun
Quoted 4 lines

At this point I just concern here if we still use 'gfx_passthrou', at least it may look like a backward compatibility with older versions of qemu in Xen side, qemu-xen-traditional. But I'd like to follow your final option.

...

Quoted 2 lines
Quoted 1 line

Any feedback to this option I should follow here?

Quoted 9 lines
Quoted 4 lines
Quoted 1 line

Ping...

I think this is a question that qemu upstream should answer.

Actually this is just commented by Gerd in qemu upstream. So now looks in Xen side you guys don't have any objection to use 'igd-passthru' as well. If yes, I'm fine to adopt this.

Yes, we would like to stay in line with upstream.

Just remember to handle old option in libxl if your old option is already released by some older version of QEMUs.

Wei.

Quoted 3 lines

Thanks
Tiejun

#22 lore raw
In reply to Chen, Tiejun
Quoted 11 lines · Tiejun
Quoted 10 lines · Ian Jackson

Chen, Tiejun writes ("Re: [Qemu-devel] [RFC][PATCH 1/1] libxl: add one machine property to support IGD GFX passthrough"):

Quoted 6 lines · Tiejun
Quoted 5 lines · Tiejun
Quoted 4 lines

At this point I just concern here if we still use 'gfx_passthrou', at least it may look like a backward compatibility with older versions of qemu in Xen side, qemu-xen-traditional. But I'd like to follow your final option.

...

Quoted 2 lines
Quoted 1 line

Any feedback to this option I should follow here?

Quoted 9 lines
Quoted 4 lines
Quoted 1 line

Ping...

I think this is a question that qemu upstream should answer.

Actually this is just commented by Gerd in qemu upstream. So now looks in Xen side you guys don't have any objection to use 'igd-passthru' as well. If yes, I'm fine to adopt this.

Yes, we would like to stay in line with upstream.

Just remember to handle old option in libxl if your old option is already released by some older version of QEMUs.

Wei.

Quoted 3 lines

Thanks
Tiejun

#23 lore raw
Quoted 17 lines · Wei Liu
Quoted 16 lines · Tiejun
Quoted 14 lines · Ian Jackson

Chen, Tiejun writes ("Re: [Qemu-devel] [RFC][PATCH 1/1] libxl: add one machine property to support IGD GFX passthrough"):

Quoted 6 lines · Tiejun
Quoted 5 lines · Tiejun
Quoted 4 lines

At this point I just concern here if we still use 'gfx_passthrou', at least it may look like a backward compatibility with older versions of qemu in Xen side, qemu-xen-traditional. But I'd like to follow your final option.

...

Quoted 3 lines
Quoted 1 line

Any feedback to this option I should follow here?

Ping...

I think this is a question that qemu upstream should answer.

Quoted 6 lines
Quoted 4 lines

Actually this is just commented by Gerd in qemu upstream. So now looks in Xen side you guys don't have any objection to use 'igd-passthru' as well. If yes, I'm fine to adopt this.

Yes, we would like to stay in line with upstream.

Wei,

Thanks for your response.

Quoted 3 lines

Just remember to handle old option in libxl if your old option is already released by some older version of QEMUs.

I just drop that old option, -gfx_passthru, if we're under qemu upstream circumstance, like this,

tools/libxl/libxl_dm.c +8 -2
@@ -318,7 +318,10 @@ static char ** libxl__build_device_model_args_old(libxl__gc *gc,
             flexarray_vappend(dm_args, "-net", "none", NULL);
         }
         if (libxl_defbool_val(b_info->u.hvm.gfx_passthru)) {
-            flexarray_append(dm_args, "-gfx_passthru");
+            if (b_info->device_model_version !=
+                LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN) {
+                flexarray_append(dm_args, "-gfx_passthru");
+            }
         }
     } else {
         if (!sdl && !vnc)
@@ -702,7 +705,10 @@ static char ** libxl__build_device_model_args_new(libxl__gc *gc,
             flexarray_append(dm_args, "none");
         }
         if (libxl_defbool_val(b_info->u.hvm.gfx_passthru)) {
-            flexarray_append(dm_args, "-gfx_passthru");
+            if (b_info->device_model_version !=
+                LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN) {
+                flexarray_append(dm_args, "-gfx_passthru");
+            }
         }
     } else {
         if (!sdl && !vnc) {

Is this good enough?

Thanks
Tiejun

#24 lore raw
In reply to Wei Liu
Quoted 17 lines · Wei Liu
Quoted 16 lines · Tiejun
Quoted 14 lines · Ian Jackson

Chen, Tiejun writes ("Re: [Qemu-devel] [RFC][PATCH 1/1] libxl: add one machine property to support IGD GFX passthrough"):

Quoted 6 lines · Tiejun
Quoted 5 lines · Tiejun
Quoted 4 lines

At this point I just concern here if we still use 'gfx_passthrou', at least it may look like a backward compatibility with older versions of qemu in Xen side, qemu-xen-traditional. But I'd like to follow your final option.

...

Quoted 3 lines
Quoted 1 line

Any feedback to this option I should follow here?

Ping...

I think this is a question that qemu upstream should answer.

Quoted 6 lines
Quoted 4 lines

Actually this is just commented by Gerd in qemu upstream. So now looks in Xen side you guys don't have any objection to use 'igd-passthru' as well. If yes, I'm fine to adopt this.

Yes, we would like to stay in line with upstream.

Wei,

Thanks for your response.

Quoted 3 lines

Just remember to handle old option in libxl if your old option is already released by some older version of QEMUs.

I just drop that old option, -gfx_passthru, if we're under qemu upstream circumstance, like this,

tools/libxl/libxl_dm.c +8 -2
@@ -318,7 +318,10 @@ static char ** libxl__build_device_model_args_old(libxl__gc *gc,
             flexarray_vappend(dm_args, "-net", "none", NULL);
         }
         if (libxl_defbool_val(b_info->u.hvm.gfx_passthru)) {
-            flexarray_append(dm_args, "-gfx_passthru");
+            if (b_info->device_model_version !=
+                LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN) {
+                flexarray_append(dm_args, "-gfx_passthru");
+            }
         }
     } else {
         if (!sdl && !vnc)
@@ -702,7 +705,10 @@ static char ** libxl__build_device_model_args_new(libxl__gc *gc,
             flexarray_append(dm_args, "none");
         }
         if (libxl_defbool_val(b_info->u.hvm.gfx_passthru)) {
-            flexarray_append(dm_args, "-gfx_passthru");
+            if (b_info->device_model_version !=
+                LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN) {
+                flexarray_append(dm_args, "-gfx_passthru");
+            }
         }
     } else {
         if (!sdl && !vnc) {

Is this good enough?

Thanks
Tiejun

#25 lore raw
Quoted 27 lines · Tiejun
Quoted 17 lines · Wei Liu
Quoted 16 lines · Tiejun
Quoted 14 lines · Ian Jackson

Chen, Tiejun writes ("Re: [Qemu-devel] [RFC][PATCH 1/1] libxl: add one machine property to support IGD GFX passthrough"):

Quoted 6 lines · Tiejun
Quoted 5 lines · Tiejun
Quoted 4 lines

At this point I just concern here if we still use 'gfx_passthrou', at least it may look like a backward compatibility with older versions of qemu in Xen side, qemu-xen-traditional. But I'd like to follow your final option.

...

Quoted 3 lines
Quoted 1 line

Any feedback to this option I should follow here?

Ping...

I think this is a question that qemu upstream should answer.

Quoted 6 lines
Quoted 4 lines

Actually this is just commented by Gerd in qemu upstream. So now looks in Xen side you guys don't have any objection to use 'igd-passthru' as well. If yes, I'm fine to adopt this.

Yes, we would like to stay in line with upstream.

Wei,

Quoted 9 lines

Thanks for your response.

Quoted 3 lines

Just remember to handle old option in libxl if your old option is already released by some older version of QEMUs.

I just drop that old option, -gfx_passthru, if we're under qemu upstream circumstance, like this,

The question is, is there any version of qemu upstream that has been released that has the old option (-gfx-passthru)?

This gives us a situation that we need to support both the old (-gfx-passthru) and new (-igd-passthru) options. Presumably we (libxl) would need to fork a qemu process to determine which option it has and pass the right one.

Or you can try to keep both old and new option at the same time but deprecate the old one. Then in a few qemu release cycles later (or probably one year or two?) you can finally remove the old one. The point is that to give downstream (in this case, Xen) time to cope with the change.

tools/libxl/libxl_dm.c static char ** · line 325

Quoted 12 lines
tools/libxl/libxl_dm.c +4 -1
@@ -318,7 +318,10 @@ static char **
 libxl__build_device_model_args_old(libxl__gc *gc,
             flexarray_vappend(dm_args, "-net", "none", NULL);
         }
         if (libxl_defbool_val(b_info->u.hvm.gfx_passthru)) {
-            flexarray_append(dm_args, "-gfx_passthru");
+            if (b_info->device_model_version !=
+                LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN) {
+                flexarray_append(dm_args, "-gfx_passthru");
+            }

I don't think this is right if upstream qemu also supports gfx-passthru.

However, you're modifying libxl__build_device_model_args_old, it strongly suggests that it only affects qemu-trad. That means you don't even need this patch...

Wei.

Quoted 21 lines
tools/libxl/libxl_dm.c +0 -0
         }
     } else {
         if (!sdl && !vnc)
tools/libxl/libxl_dm.c +4 -1
@@ -702,7 +705,10 @@ static char **
 libxl__build_device_model_args_new(libxl__gc *gc,
             flexarray_append(dm_args, "none");
         }
         if (libxl_defbool_val(b_info->u.hvm.gfx_passthru)) {
-            flexarray_append(dm_args, "-gfx_passthru");
+            if (b_info->device_model_version !=
+                LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN) {
+                flexarray_append(dm_args, "-gfx_passthru");
+            }
         }
     } else {
         if (!sdl && !vnc) {

Is this good enough?

Thanks
Tiejun

#26 lore raw
In reply to Chen, Tiejun
Quoted 27 lines · Tiejun
Quoted 17 lines · Wei Liu
Quoted 16 lines · Tiejun
Quoted 14 lines · Ian Jackson

Chen, Tiejun writes ("Re: [Qemu-devel] [RFC][PATCH 1/1] libxl: add one machine property to support IGD GFX passthrough"):

Quoted 6 lines · Tiejun
Quoted 5 lines · Tiejun
Quoted 4 lines

At this point I just concern here if we still use 'gfx_passthrou', at least it may look like a backward compatibility with older versions of qemu in Xen side, qemu-xen-traditional. But I'd like to follow your final option.

...

Quoted 3 lines
Quoted 1 line

Any feedback to this option I should follow here?

Ping...

I think this is a question that qemu upstream should answer.

Quoted 6 lines
Quoted 4 lines

Actually this is just commented by Gerd in qemu upstream. So now looks in Xen side you guys don't have any objection to use 'igd-passthru' as well. If yes, I'm fine to adopt this.

Yes, we would like to stay in line with upstream.

Wei,

Quoted 9 lines

Thanks for your response.

Quoted 3 lines

Just remember to handle old option in libxl if your old option is already released by some older version of QEMUs.

I just drop that old option, -gfx_passthru, if we're under qemu upstream circumstance, like this,

The question is, is there any version of qemu upstream that has been released that has the old option (-gfx-passthru)?

This gives us a situation that we need to support both the old (-gfx-passthru) and new (-igd-passthru) options. Presumably we (libxl) would need to fork a qemu process to determine which option it has and pass the right one.

Or you can try to keep both old and new option at the same time but deprecate the old one. Then in a few qemu release cycles later (or probably one year or two?) you can finally remove the old one. The point is that to give downstream (in this case, Xen) time to cope with the change.

tools/libxl/libxl_dm.c static char ** · line 325

Quoted 12 lines
tools/libxl/libxl_dm.c +4 -1
@@ -318,7 +318,10 @@ static char **
 libxl__build_device_model_args_old(libxl__gc *gc,
             flexarray_vappend(dm_args, "-net", "none", NULL);
         }
         if (libxl_defbool_val(b_info->u.hvm.gfx_passthru)) {
-            flexarray_append(dm_args, "-gfx_passthru");
+            if (b_info->device_model_version !=
+                LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN) {
+                flexarray_append(dm_args, "-gfx_passthru");
+            }

I don't think this is right if upstream qemu also supports gfx-passthru.

However, you're modifying libxl__build_device_model_args_old, it strongly suggests that it only affects qemu-trad. That means you don't even need this patch...

Wei.

Quoted 21 lines
tools/libxl/libxl_dm.c +0 -0
         }
     } else {
         if (!sdl && !vnc)
tools/libxl/libxl_dm.c +4 -1
@@ -702,7 +705,10 @@ static char **
 libxl__build_device_model_args_new(libxl__gc *gc,
             flexarray_append(dm_args, "none");
         }
         if (libxl_defbool_val(b_info->u.hvm.gfx_passthru)) {
-            flexarray_append(dm_args, "-gfx_passthru");
+            if (b_info->device_model_version !=
+                LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN) {
+                flexarray_append(dm_args, "-gfx_passthru");
+            }
         }
     } else {
         if (!sdl && !vnc) {

Is this good enough?

Thanks
Tiejun

#27 lore raw
Quoted 34 lines · Wei Liu
Quoted 33 lines · Tiejun
Quoted 17 lines · Wei Liu
Quoted 16 lines · Tiejun
Quoted 14 lines · Ian Jackson

Chen, Tiejun writes ("Re: [Qemu-devel] [RFC][PATCH 1/1] libxl: add one machine property to support IGD GFX passthrough"):

Quoted 6 lines · Tiejun
Quoted 5 lines · Tiejun
Quoted 4 lines

At this point I just concern here if we still use 'gfx_passthrou', at least it may look like a backward compatibility with older versions of qemu in Xen side, qemu-xen-traditional. But I'd like to follow your final option.

...

Quoted 3 lines
Quoted 1 line

Any feedback to this option I should follow here?

Ping...

I think this is a question that qemu upstream should answer.

Quoted 6 lines
Quoted 4 lines

Actually this is just commented by Gerd in qemu upstream. So now looks in Xen side you guys don't have any objection to use 'igd-passthru' as well. If yes, I'm fine to adopt this.

Yes, we would like to stay in line with upstream.

Wei,

Thanks for your response.

Quoted 3 lines

Just remember to handle old option in libxl if your old option is already released by some older version of QEMUs.

Quoted 6 lines
Quoted 3 lines

I just drop that old option, -gfx_passthru, if we're under qemu upstream circumstance, like this,

The question is, is there any version of qemu upstream that has been released that has the old option (-gfx-passthru)?

No. Just now we're starting to support IGD passthrough in qemu upstream.

Quoted 7 lines

This gives us a situation that we need to support both the old (-gfx-passthru) and new (-igd-passthru) options. Presumably we (libxl) would need to fork a qemu process to determine which option it has and pass the right one.

Or you can try to keep both old and new option at the same time but

Yeah, actually I also have considered to keep both two options at the same time. Its really friendly to any qemu version.

Quoted 1 line

deprecate the old one. Then in a few qemu release cycles later (or

This should be like 'accel=kvm' versus 'enable-kvm' in qemu upstream. They're coexisted now but just the former is a modern option.

Quoted 3 lines

probably one year or two?) you can finally remove the old one. The point is that to give downstream (in this case, Xen) time to cope with the change.

Here I'm fine to this way.

So Gerd,

What about this?

Quoted 16 lines

tools/libxl/libxl_dm.c static char ** · line 325

Quoted 13 lines
tools/libxl/libxl_dm.c +4 -1
@@ -318,7 +318,10 @@ static char **
 libxl__build_device_model_args_old(libxl__gc *gc,
              flexarray_vappend(dm_args, "-net", "none", NULL);
          }
          if (libxl_defbool_val(b_info->u.hvm.gfx_passthru)) {
-            flexarray_append(dm_args, "-gfx_passthru");
+            if (b_info->device_model_version !=
+                LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN) {
+                flexarray_append(dm_args, "-gfx_passthru");
+            }

I don't think this is right if upstream qemu also supports gfx-passthru.

Quoted 3 lines

However, you're modifying libxl__build_device_model_args_old, it strongly suggests that it only affects qemu-trad. That means you don't even need this patch...

You're right and thanks.

Thanks
Tiejun

Quoted 25 lines

Wei.

Quoted 21 lines
tools/libxl/libxl_dm.c +0 -0
          }
      } else {
          if (!sdl && !vnc)
tools/libxl/libxl_dm.c +4 -1
@@ -702,7 +705,10 @@ static char **
 libxl__build_device_model_args_new(libxl__gc *gc,
              flexarray_append(dm_args, "none");
          }
          if (libxl_defbool_val(b_info->u.hvm.gfx_passthru)) {
-            flexarray_append(dm_args, "-gfx_passthru");
+            if (b_info->device_model_version !=
+                LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN) {
+                flexarray_append(dm_args, "-gfx_passthru");
+            }
          }
      } else {
          if (!sdl && !vnc) {

Is this good enough?

Thanks
Tiejun

#28 lore raw
In reply to Wei Liu
Quoted 34 lines · Wei Liu
Quoted 33 lines · Tiejun
Quoted 17 lines · Wei Liu
Quoted 16 lines · Tiejun
Quoted 14 lines · Ian Jackson

Chen, Tiejun writes ("Re: [Qemu-devel] [RFC][PATCH 1/1] libxl: add one machine property to support IGD GFX passthrough"):

Quoted 6 lines · Tiejun
Quoted 5 lines · Tiejun
Quoted 4 lines

At this point I just concern here if we still use 'gfx_passthrou', at least it may look like a backward compatibility with older versions of qemu in Xen side, qemu-xen-traditional. But I'd like to follow your final option.

...

Quoted 3 lines
Quoted 1 line

Any feedback to this option I should follow here?

Ping...

I think this is a question that qemu upstream should answer.

Quoted 6 lines
Quoted 4 lines

Actually this is just commented by Gerd in qemu upstream. So now looks in Xen side you guys don't have any objection to use 'igd-passthru' as well. If yes, I'm fine to adopt this.

Yes, we would like to stay in line with upstream.

Wei,

Thanks for your response.

Quoted 3 lines

Just remember to handle old option in libxl if your old option is already released by some older version of QEMUs.

Quoted 6 lines
Quoted 3 lines

I just drop that old option, -gfx_passthru, if we're under qemu upstream circumstance, like this,

The question is, is there any version of qemu upstream that has been released that has the old option (-gfx-passthru)?

No. Just now we're starting to support IGD passthrough in qemu upstream.

Quoted 7 lines

This gives us a situation that we need to support both the old (-gfx-passthru) and new (-igd-passthru) options. Presumably we (libxl) would need to fork a qemu process to determine which option it has and pass the right one.

Or you can try to keep both old and new option at the same time but

Yeah, actually I also have considered to keep both two options at the same time. Its really friendly to any qemu version.

Quoted 1 line

deprecate the old one. Then in a few qemu release cycles later (or

This should be like 'accel=kvm' versus 'enable-kvm' in qemu upstream. They're coexisted now but just the former is a modern option.

Quoted 3 lines

probably one year or two?) you can finally remove the old one. The point is that to give downstream (in this case, Xen) time to cope with the change.

Here I'm fine to this way.

So Gerd,

What about this?

Quoted 16 lines

tools/libxl/libxl_dm.c static char ** · line 325

Quoted 13 lines
tools/libxl/libxl_dm.c +4 -1
@@ -318,7 +318,10 @@ static char **
 libxl__build_device_model_args_old(libxl__gc *gc,
              flexarray_vappend(dm_args, "-net", "none", NULL);
          }
          if (libxl_defbool_val(b_info->u.hvm.gfx_passthru)) {
-            flexarray_append(dm_args, "-gfx_passthru");
+            if (b_info->device_model_version !=
+                LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN) {
+                flexarray_append(dm_args, "-gfx_passthru");
+            }

I don't think this is right if upstream qemu also supports gfx-passthru.

Quoted 3 lines

However, you're modifying libxl__build_device_model_args_old, it strongly suggests that it only affects qemu-trad. That means you don't even need this patch...

You're right and thanks.

Thanks
Tiejun

Quoted 25 lines

Wei.

Quoted 21 lines
tools/libxl/libxl_dm.c +0 -0
          }
      } else {
          if (!sdl && !vnc)
tools/libxl/libxl_dm.c +4 -1
@@ -702,7 +705,10 @@ static char **
 libxl__build_device_model_args_new(libxl__gc *gc,
              flexarray_append(dm_args, "none");
          }
          if (libxl_defbool_val(b_info->u.hvm.gfx_passthru)) {
-            flexarray_append(dm_args, "-gfx_passthru");
+            if (b_info->device_model_version !=
+                LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN) {
+                flexarray_append(dm_args, "-gfx_passthru");
+            }
          }
      } else {
          if (!sdl && !vnc) {

Is this good enough?

Thanks
Tiejun

#29 lore raw

On Fri, Jan 30, 2015 at 08:56:48AM +0800, Chen, Tiejun wrote:
[...]

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 3 lines

Just remember to handle old option in libxl if your old option is already released by some older version of QEMUs.

Quoted 9 lines
Quoted 6 lines
Quoted 3 lines

I just drop that old option, -gfx_passthru, if we're under qemu upstream circumstance, like this,

The question is, is there any version of qemu upstream that has been released that has the old option (-gfx-passthru)?

No. Just now we're starting to support IGD passthrough in qemu upstream.

Right, as of QEMU 2.2.0 there's no support of IGD passthrough in QMEU upstream.

Quoted 16 lines
Quoted 7 lines

This gives us a situation that we need to support both the old (-gfx-passthru) and new (-igd-passthru) options. Presumably we (libxl) would need to fork a qemu process to determine which option it has and pass the right one.

Or you can try to keep both old and new option at the same time but

Yeah, actually I also have considered to keep both two options at the same time. Its really friendly to any qemu version.

Quoted 1 line

deprecate the old one. Then in a few qemu release cycles later (or

This should be like 'accel=kvm' versus 'enable-kvm' in qemu upstream. They're coexisted now but just the former is a modern option.

Quoted 8 lines
Quoted 3 lines

probably one year or two?) you can finally remove the old one. The point is that to give downstream (in this case, Xen) time to cope with the change.

Here I'm fine to this way.

So Gerd,

So you don't actually need to ask Gerd this question because there is no old option to keep in qemu upstream.

Libxl (or any sensible toolstack) will just do the right thing to either pass -igd-passthru (or whatever you guys agree upon) to qemu upstream or pass -gfx-passthru to qemu traditional. :-)

Wei.

Quoted 2 lines

What about this?

#30 lore raw
In reply to Chen, Tiejun

On Fri, Jan 30, 2015 at 08:56:48AM +0800, Chen, Tiejun wrote:
[...]

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 3 lines

Just remember to handle old option in libxl if your old option is already released by some older version of QEMUs.

Quoted 9 lines
Quoted 6 lines
Quoted 3 lines

I just drop that old option, -gfx_passthru, if we're under qemu upstream circumstance, like this,

The question is, is there any version of qemu upstream that has been released that has the old option (-gfx-passthru)?

No. Just now we're starting to support IGD passthrough in qemu upstream.

Right, as of QEMU 2.2.0 there's no support of IGD passthrough in QMEU upstream.

Quoted 16 lines
Quoted 7 lines

This gives us a situation that we need to support both the old (-gfx-passthru) and new (-igd-passthru) options. Presumably we (libxl) would need to fork a qemu process to determine which option it has and pass the right one.

Or you can try to keep both old and new option at the same time but

Yeah, actually I also have considered to keep both two options at the same time. Its really friendly to any qemu version.

Quoted 1 line

deprecate the old one. Then in a few qemu release cycles later (or

This should be like 'accel=kvm' versus 'enable-kvm' in qemu upstream. They're coexisted now but just the former is a modern option.

Quoted 8 lines
Quoted 3 lines

probably one year or two?) you can finally remove the old one. The point is that to give downstream (in this case, Xen) time to cope with the change.

Here I'm fine to this way.

So Gerd,

So you don't actually need to ask Gerd this question because there is no old option to keep in qemu upstream.

Libxl (or any sensible toolstack) will just do the right thing to either pass -igd-passthru (or whatever you guys agree upon) to qemu upstream or pass -gfx-passthru to qemu traditional. :-)

Wei.

Quoted 2 lines

What about this?

#31 lore raw
Quoted 22 lines

-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Wei Liu
Sent: Friday, January 30, 2015 8:26 PM
To: Chen, Tiejun
Cc: Wei Liu; [email protected]; [email protected]; Ian Jackson; [email protected]; [email protected]; Gerd Hoffmann
Subject: Re: [Xen-devel] [Qemu-devel] [RFC][PATCH 1/1] libxl: add one machine property to support IGD GFX passthrough

On Fri, Jan 30, 2015 at 08:56:48AM +0800, Chen, Tiejun wrote:
[...]

Quoted 8 lines
Quoted 8 lines
Quoted 7 lines
Quoted 3 lines

Just remember to handle old option in libxl if your old option is already released by some older version of QEMUs.

I just drop that old option, -gfx_passthru, if we're under qemu upstream circumstance, like this,

Quoted 9 lines
Quoted 5 lines
Quoted 2 lines

The question is, is there any version of qemu upstream that has been released that has the old option (-gfx-passthru)?

No. Just now we're starting to support IGD passthrough in qemu upstream.

Right, as of QEMU 2.2.0 there's no support of IGD passthrough in QMEU upstream.

Just a question:
Now what features do vt-d support? Thanks.

-Quan

Quoted 43 lines
Quoted 16 lines
Quoted 7 lines

This gives us a situation that we need to support both the old (-gfx-passthru) and new (-igd-passthru) options. Presumably we (libxl) would need to fork a qemu process to determine which option it has and pass the right one.

Or you can try to keep both old and new option at the same time but

Yeah, actually I also have considered to keep both two options at the same time. Its really friendly to any qemu version.

Quoted 1 line

deprecate the old one. Then in a few qemu release cycles later (or

This should be like 'accel=kvm' versus 'enable-kvm' in qemu upstream. They're coexisted now but just the former is a modern option.

Quoted 8 lines
Quoted 3 lines

probably one year or two?) you can finally remove the old one. The point is that to give downstream (in this case, Xen) time to cope with the change.

Here I'm fine to this way.

So Gerd,

So you don't actually need to ask Gerd this question because there is no old option to keep in qemu upstream.

Libxl (or any sensible toolstack) will just do the right thing to either pass

(quoted diff) +0 -2
-igd-passthru (or whatever you guys agree upon) to qemu upstream or pass
-gfx-passthru to qemu traditional. :-)

Wei.

Quoted 2 lines

What about this?

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xen.org/xen-devel

#32 lore raw
In reply to Wei Liu
Quoted 22 lines

-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Wei Liu
Sent: Friday, January 30, 2015 8:26 PM
To: Chen, Tiejun
Cc: Wei Liu; [email protected]; [email protected]; Ian Jackson; [email protected]; [email protected]; Gerd Hoffmann
Subject: Re: [Xen-devel] [Qemu-devel] [RFC][PATCH 1/1] libxl: add one machine property to support IGD GFX passthrough

On Fri, Jan 30, 2015 at 08:56:48AM +0800, Chen, Tiejun wrote:
[...]

Quoted 8 lines
Quoted 8 lines
Quoted 7 lines
Quoted 3 lines

Just remember to handle old option in libxl if your old option is already released by some older version of QEMUs.

I just drop that old option, -gfx_passthru, if we're under qemu upstream circumstance, like this,

Quoted 9 lines
Quoted 5 lines
Quoted 2 lines

The question is, is there any version of qemu upstream that has been released that has the old option (-gfx-passthru)?

No. Just now we're starting to support IGD passthrough in qemu upstream.

Right, as of QEMU 2.2.0 there's no support of IGD passthrough in QMEU upstream.

Just a question:
Now what features do vt-d support? Thanks.

-Quan

Quoted 43 lines
Quoted 16 lines
Quoted 7 lines

This gives us a situation that we need to support both the old (-gfx-passthru) and new (-igd-passthru) options. Presumably we (libxl) would need to fork a qemu process to determine which option it has and pass the right one.

Or you can try to keep both old and new option at the same time but

Yeah, actually I also have considered to keep both two options at the same time. Its really friendly to any qemu version.

Quoted 1 line

deprecate the old one. Then in a few qemu release cycles later (or

This should be like 'accel=kvm' versus 'enable-kvm' in qemu upstream. They're coexisted now but just the former is a modern option.

Quoted 8 lines
Quoted 3 lines

probably one year or two?) you can finally remove the old one. The point is that to give downstream (in this case, Xen) time to cope with the change.

Here I'm fine to this way.

So Gerd,

So you don't actually need to ask Gerd this question because there is no old option to keep in qemu upstream.

Libxl (or any sensible toolstack) will just do the right thing to either pass

(quoted diff) +0 -2
-igd-passthru (or whatever you guys agree upon) to qemu upstream or pass
-gfx-passthru to qemu traditional. :-)

Wei.

Quoted 2 lines

What about this?

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xen.org/xen-devel

#33 lore raw
Quoted 28 lines · Quan
Quoted 28 lines

-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Wei Liu
Sent: Friday, January 30, 2015 8:26 PM
To: Chen, Tiejun
Cc: Wei Liu; [email protected]; [email protected]; Ian Jackson; [email protected]; [email protected]; Gerd Hoffmann
Subject: Re: [Xen-devel] [Qemu-devel] [RFC][PATCH 1/1] libxl: add one machine property to support IGD GFX passthrough

On Fri, Jan 30, 2015 at 08:56:48AM +0800, Chen, Tiejun wrote:
[...]

Quoted 13 lines
Quoted 10 lines
Quoted 7 lines
Quoted 3 lines

Just remember to handle old option in libxl if your old option is already released by some older version of QEMUs.

I just drop that old option, -gfx_passthru, if we're under qemu upstream circumstance, like this,

The question is, is there any version of qemu upstream that has been released that has the old option (-gfx-passthru)?

No. Just now we're starting to support IGD passthrough in qemu upstream.

Quoted 7 lines
Quoted 3 lines

Right, as of QEMU 2.2.0 there's no support of IGD passthrough in QMEU upstream.

Just a question:
Now what features do vt-d support? Thanks.

I don't know whether vt-d is supported in qemu upstream.

But if there is support in upstream and you want to change some options, the same principle in my previous email still applies.

Wei.

#34 lore raw
In reply to Xu, Quan
Quoted 28 lines · Quan
Quoted 28 lines

-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Wei Liu
Sent: Friday, January 30, 2015 8:26 PM
To: Chen, Tiejun
Cc: Wei Liu; [email protected]; [email protected]; Ian Jackson; [email protected]; [email protected]; Gerd Hoffmann
Subject: Re: [Xen-devel] [Qemu-devel] [RFC][PATCH 1/1] libxl: add one machine property to support IGD GFX passthrough

On Fri, Jan 30, 2015 at 08:56:48AM +0800, Chen, Tiejun wrote:
[...]

Quoted 13 lines
Quoted 10 lines
Quoted 7 lines
Quoted 3 lines

Just remember to handle old option in libxl if your old option is already released by some older version of QEMUs.

I just drop that old option, -gfx_passthru, if we're under qemu upstream circumstance, like this,

The question is, is there any version of qemu upstream that has been released that has the old option (-gfx-passthru)?

No. Just now we're starting to support IGD passthrough in qemu upstream.

Quoted 7 lines
Quoted 3 lines

Right, as of QEMU 2.2.0 there's no support of IGD passthrough in QMEU upstream.

Just a question:
Now what features do vt-d support? Thanks.

I don't know whether vt-d is supported in qemu upstream.

But if there is support in upstream and you want to change some options, the same principle in my previous email still applies.

Wei.

#35 lore raw
Quoted 48 lines

-----Original Message-----
From: Wei Liu [mailto:[email protected]]
Sent: Saturday, January 31, 2015 10:33 PM
To: Xu, Quan
Cc: Wei Liu; Chen, Tiejun; [email protected]; [email protected]; Ian Jackson; [email protected]; [email protected]; Gerd Hoffmann
Subject: Re: [Xen-devel] [Qemu-devel] [RFC][PATCH 1/1] libxl: add one machine property to support IGD GFX passthrough

Quoted 28 lines · Quan
Quoted 28 lines

-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Wei Liu
Sent: Friday, January 30, 2015 8:26 PM
To: Chen, Tiejun
Cc: Wei Liu; [email protected]; [email protected]; Ian Jackson; [email protected]; [email protected]; Gerd Hoffmann
Subject: Re: [Xen-devel] [Qemu-devel] [RFC][PATCH 1/1] libxl: add one machine property to support IGD GFX passthrough

On Fri, Jan 30, 2015 at 08:56:48AM +0800, Chen, Tiejun wrote:
[...]

Quoted 13 lines
Quoted 10 lines
Quoted 7 lines
Quoted 3 lines

Just remember to handle old option in libxl if your old option is already released by some older version of QEMUs.

I just drop that old option, -gfx_passthru, if we're under qemu upstream circumstance, like this,

The question is, is there any version of qemu upstream that has been released that has the old option (-gfx-passthru)?

No. Just now we're starting to support IGD passthrough in qemu upstream.

Quoted 7 lines
Quoted 3 lines

Right, as of QEMU 2.2.0 there's no support of IGD passthrough in QMEU upstream.

Just a question:
Now what features do vt-d support? Thanks.

Quoted 6 lines

I don't know whether vt-d is supported in qemu upstream.

But if there is support in upstream and you want to change some options, the same principle in my previous email still applies.

Wei.

Thanks. -Quan

#36 lore raw
In reply to Wei Liu
Quoted 48 lines

-----Original Message-----
From: Wei Liu [mailto:[email protected]]
Sent: Saturday, January 31, 2015 10:33 PM
To: Xu, Quan
Cc: Wei Liu; Chen, Tiejun; [email protected]; [email protected]; Ian Jackson; [email protected]; [email protected]; Gerd Hoffmann
Subject: Re: [Xen-devel] [Qemu-devel] [RFC][PATCH 1/1] libxl: add one machine property to support IGD GFX passthrough

Quoted 28 lines · Quan
Quoted 28 lines

-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Wei Liu
Sent: Friday, January 30, 2015 8:26 PM
To: Chen, Tiejun
Cc: Wei Liu; [email protected]; [email protected]; Ian Jackson; [email protected]; [email protected]; Gerd Hoffmann
Subject: Re: [Xen-devel] [Qemu-devel] [RFC][PATCH 1/1] libxl: add one machine property to support IGD GFX passthrough

On Fri, Jan 30, 2015 at 08:56:48AM +0800, Chen, Tiejun wrote:
[...]

Quoted 13 lines
Quoted 10 lines
Quoted 7 lines
Quoted 3 lines

Just remember to handle old option in libxl if your old option is already released by some older version of QEMUs.

I just drop that old option, -gfx_passthru, if we're under qemu upstream circumstance, like this,

The question is, is there any version of qemu upstream that has been released that has the old option (-gfx-passthru)?

No. Just now we're starting to support IGD passthrough in qemu upstream.

Quoted 7 lines
Quoted 3 lines

Right, as of QEMU 2.2.0 there's no support of IGD passthrough in QMEU upstream.

Just a question:
Now what features do vt-d support? Thanks.

Quoted 6 lines

I don't know whether vt-d is supported in qemu upstream.

But if there is support in upstream and you want to change some options, the same principle in my previous email still applies.

Wei.

Thanks. -Quan

#37 lore raw
In reply to Wei Liu
Quoted 44 lines · Wei Liu

On Fri, Jan 30, 2015 at 08:56:48AM +0800, Chen, Tiejun wrote:
[...]

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 3 lines

Just remember to handle old option in libxl if your old option is already released by some older version of QEMUs.

Quoted 9 lines
Quoted 6 lines
Quoted 3 lines

I just drop that old option, -gfx_passthru, if we're under qemu upstream circumstance, like this,

The question is, is there any version of qemu upstream that has been released that has the old option (-gfx-passthru)?

No. Just now we're starting to support IGD passthrough in qemu upstream.

Right, as of QEMU 2.2.0 there's no support of IGD passthrough in QMEU upstream.

Quoted 16 lines
Quoted 7 lines

This gives us a situation that we need to support both the old (-gfx-passthru) and new (-igd-passthru) options. Presumably we (libxl) would need to fork a qemu process to determine which option it has and pass the right one.

Or you can try to keep both old and new option at the same time but

Yeah, actually I also have considered to keep both two options at the same time. Its really friendly to any qemu version.

Quoted 1 line

deprecate the old one. Then in a few qemu release cycles later (or

This should be like 'accel=kvm' versus 'enable-kvm' in qemu upstream. They're coexisted now but just the former is a modern option.

Quoted 8 lines
Quoted 3 lines

probably one year or two?) you can finally remove the old one. The point is that to give downstream (in this case, Xen) time to cope with the change.

Here I'm fine to this way.

So Gerd,

Quoted 7 lines

So you don't actually need to ask Gerd this question because there is no old option to keep in qemu upstream.

Libxl (or any sensible toolstack) will just do the right thing to either pass -igd-passthru (or whatever you guys agree upon) to qemu upstream or pass -gfx-passthru to qemu traditional. :-)

Okay let me try do this.

Thanks
Tiejun

#38 lore raw
In reply to Wei Liu
Quoted 44 lines · Wei Liu

On Fri, Jan 30, 2015 at 08:56:48AM +0800, Chen, Tiejun wrote:
[...]

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 3 lines

Just remember to handle old option in libxl if your old option is already released by some older version of QEMUs.

Quoted 9 lines
Quoted 6 lines
Quoted 3 lines

I just drop that old option, -gfx_passthru, if we're under qemu upstream circumstance, like this,

The question is, is there any version of qemu upstream that has been released that has the old option (-gfx-passthru)?

No. Just now we're starting to support IGD passthrough in qemu upstream.

Right, as of QEMU 2.2.0 there's no support of IGD passthrough in QMEU upstream.

Quoted 16 lines
Quoted 7 lines

This gives us a situation that we need to support both the old (-gfx-passthru) and new (-igd-passthru) options. Presumably we (libxl) would need to fork a qemu process to determine which option it has and pass the right one.

Or you can try to keep both old and new option at the same time but

Yeah, actually I also have considered to keep both two options at the same time. Its really friendly to any qemu version.

Quoted 1 line

deprecate the old one. Then in a few qemu release cycles later (or

This should be like 'accel=kvm' versus 'enable-kvm' in qemu upstream. They're coexisted now but just the former is a modern option.

Quoted 8 lines
Quoted 3 lines

probably one year or two?) you can finally remove the old one. The point is that to give downstream (in this case, Xen) time to cope with the change.

Here I'm fine to this way.

So Gerd,

Quoted 7 lines

So you don't actually need to ask Gerd this question because there is no old option to keep in qemu upstream.

Libxl (or any sensible toolstack) will just do the right thing to either pass -igd-passthru (or whatever you guys agree upon) to qemu upstream or pass -gfx-passthru to qemu traditional. :-)

Okay let me try do this.

Thanks
Tiejun