lib/oe/package: Ensure strip breaks hardlinks

PATCH New Richard Purdie 1 participant 1 message Jan 21, 2015

Share & tools

Richard Purdie

author

2015-01-21 11:35 UTC #0 lore raw

PATCH 1/1 lib/oe/package: Ensure strip breaks hardlinks

Normally, strip preserves hardlinks which in the case of the way our hardlink rather than copy functionality works, is a disadvantage and leads to non-deterministic builds. This adds a move into place after the strip operation to ensure hardlinks are broken and we bring back build determinism.

Signed-off-by Richard Purdie <[email protected]>

meta/lib/oe/package.py +2 -1

index ea6feaa..7c728fc 100644
@@ -30,7 +30,8 @@ def runstrip(arg):
     elif elftype & 8 or elftype & 4:
         extraflags = "--remove-section=.comment --remove-section=.note"
 
-    stripcmd = "'%s' %s '%s'" % (strip, extraflags, file)
+    # Use mv to break hardlinks
+    stripcmd = "'%s' %s '%s' -o '%s.tmp' && mv '%s.tmp' '%s'" % (strip, extraflags, file, file, file, file)
     bb.debug(1, "runstrip: %s" % stripcmd)
 
     ret = subprocess.call(stripcmd, shell=True)