ia64: implicit declaration of functions since change on <linux/dmar.h>
Hi,
While trying to conduct some regression testing, I've hit the following build issue for ia64:
CC arch/ia64/kernel/pci-dma.o../arch/ia64/kernel/pci-dma.c: In function 'pci_iommu_init':../arch/ia64/kernel/pci-dma.c:41:3: error: implicit declaration of function 'intel_iommu_init' [-Werror=implicit-function-declaration]
intel_iommu_init();
^../arch/ia64/kernel/pci-dma.c: In function 'pci_iommu_alloc':../arch/ia64/kernel/pci-dma.c:103:2: error: implicit declaration of function 'detect_intel_iommu' [-Werror=implicit-function-declaration]
detect_intel_iommu();
^
It should be noted Kconfig complain with the following:
warning: (IA64) selects PM which has unmet direct dependencies (PM_SLEEP || PM_RUNTIME)
warning: (IA64_DIG_VTD) selects INTEL_IOMMU which has unmet direct dependencies (IOMMU_SUPPORT && PCI_MSI && ACPI && (X86 || IA64_GENERIC))
warning: (IA64) selects PM which has unmet direct dependencies (PM_SLEEP || PM_RUNTIME)
warning: (IA64_DIG_VTD) selects INTEL_IOMMU which has unmet direct dependencies (IOMMU_SUPPORT && PCI_MSI && ACPI && (X86 || IA64_GENERIC))
Bissection report the following commit as the root cause of the broken build:
8594d83261d14754288ef00993f0971131ff08eb is the first bad commit commit 8594d83261d14754288ef00993f0971131ff08eb
Author: Jiang Liu <[email protected]> Date: Fri Jul 11 14:19:32 2014 +0800
iommu/vt-d: Simplify include/linux/dmar.h
Simplify include/linux/dmar.h a bit based on the fact that both CONFIG_INTEL_IOMMU and CONFIG_IRQ_REMAP select CONFIG_DMAR_TABLE.
Regards.
Signature · 2 lines
Yann Droneaud OPTEYA
RFC PATCH 1/1 iommu/vt-d: Fix build failure caused by incorrect Kconfig
Yann Droneaud <[email protected]> reported one build failure as
below, which should be caused by incorrect Kconfig.
CC arch/ia64/kernel/pci-dma.o../arch/ia64/kernel/pci-dma.c: In function 'pci_iommu_init':../arch/ia64/kernel/pci-dma.c:41:3: error: implicit declaration of function 'intel_iommu_init' [-Werror=implicit-function-declaration]
intel_iommu_init();
^../arch/ia64/kernel/pci-dma.c: In function 'pci_iommu_alloc':../arch/ia64/kernel/pci-dma.c:103:2: error: implicit declaration of function 'detect_intel_iommu' [-Werror=implicit-function-declaration]
detect_intel_iommu();
^
It should be noted Kconfig complain with the following:
warning: (IA64) selects PM which has unmet direct dependencies (PM_SLEEP || PM_RUNTIME)
warning: (IA64_DIG_VTD) selects INTEL_IOMMU which has unmet direct dependencies (IOMMU_SUPPORT && PCI_MSI && ACPI && (X86 || IA64_GENERIC))
warning: (IA64) selects PM which has unmet direct dependencies (PM_SLEEP || PM_RUNTIME)
warning: (IA64_DIG_VTD) selects INTEL_IOMMU which has unmet direct dependencies (IOMMU_SUPPORT && PCI_MSI && ACPI && (X86 || IA64_GENERIC))
---
Hi Yann,
Could you please help to test whether this patch fix the build
failure and the Kconfig warnings?
Thanks!
Gerry
--- drivers/iommu/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iommu/Kconfig +1 -1
@@ -89,7 +89,7 @@ config DMAR_TABLE config INTEL_IOMMU bool "Support for Intel IOMMU using DMA Remapping Devices" - depends on PCI_MSI && ACPI && (X86 || IA64_GENERIC) + depends on PCI_MSI && ACPI && (X86 || IA64_DIG_VTD) select IOMMU_API select DMAR_TABLE help
Signature · 1 line
1.7.10.4