Skip to contentSkip to conversation

bootstage: Fix typos in the comment

PATCH New Bin Meng 2 participants 7 messages Feb 2, 2015 – Feb 6, 2015 x86

lore
Share & tools
lore

Bin Meng

author
#0 lore raw

PATCH 1/2 bootstage: Fix typos in the comment

There are two typos in the comment block in bootstage.h, fix them.

---

 include/bootstage.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
include/bootstage.h +2 -2
index 6b7588d..0276cb3 100644
@@ -86,9 +86,9 @@ enum bootstage_id {
 	BOOTSTAGE_ID_POST_FAIL_R,	/* Post failure reported after reloc */
 
 	/*
-	 * This set is reported ony by x86, and the meaning is different. In
+	 * This set is reported only by x86, and the meaning is different. In
 	 * this case we are reporting completion of a particular stage.
-	 * This should probably change in he x86 code (which doesn't report
+	 * This should probably change in the x86 code (which doesn't report
 	 * errors in any case), but discussion this can perhaps wait until we
 	 * have a generic board implementation.
 	 */
Signature · 1 line
1.8.2.1
author
#1 lore raw

PATCH 2/2 x86: Use tab instead of space to indent in PCIE_ECAM_BASE

Space is used before 'default' in PCIE_ECAM_BASE in arch/x86/Kconfig so it looks misaligned. Replace the space with tab to indent.

---

 arch/x86/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/Kconfig +1 -1
index 2370c32..fef11f3 100644
@@ -428,7 +428,7 @@ source "board/intel/galileo/Kconfig"
 
 config PCIE_ECAM_BASE
 	hex
-    default 0xe0000000
+	default 0xe0000000
 	help
 	  This is the memory-mapped address of PCI configuration space, which
 	  is only available through the Enhanced Configuration Access
Signature · 1 line
1.8.2.1
author
#2 lore raw

PATCH 2/2 x86: Use tab instead of space to indent in PCIE_ECAM_BASE

Hi Simon,

arch/x86/Kconfig source "board/intel/galileo/Kconfig"

Quoted 14 lines · Bin Meng

Space is used before 'default' in PCIE_ECAM_BASE in arch/x86/Kconfig so it looks misaligned. Replace the space with tab to indent.

---

 arch/x86/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/Kconfig +0 -0
index 2370c32..fef11f3 100644
@@ -428,7 +428,7 @@ source "board/intel/galileo/Kconfig"

Ah, looks this patch depends on
http://patchwork.ozlabs.org/patch/434403/. Let me know if you need me respin, or just have this patch applied after that one.

arch/x86/Kconfig source "board/intel/galileo/Kconfig"

Quoted 8 lines
arch/x86/Kconfig +1 -2
 config PCIE_ECAM_BASE
        hex
-    default 0xe0000000
+       default 0xe0000000
        help
          This is the memory-mapped address of PCI configuration space, which
          is only available through the Enhanced Configuration Access
--

Regards,
Bin

#3 lore raw

PATCH 2/2 x86: Use tab instead of space to indent in PCIE_ECAM_BASE

Quoted 12 lines · Bin Meng

Hi Simon,

Quoted 9 lines · Bin Meng

Space is used before 'default' in PCIE_ECAM_BASE in arch/x86/Kconfig so it looks misaligned. Replace the space with tab to indent.

---

 arch/x86/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 10 lines

arch/x86/Kconfig source "board/intel/galileo/Kconfig"

Quoted 5 lines
arch/x86/Kconfig +0 -0
index 2370c32..fef11f3 100644
@@ -428,7 +428,7 @@ source "board/intel/galileo/Kconfig"

Ah, looks this patch depends on
http://patchwork.ozlabs.org/patch/434403/. Let me know if you need me respin, or just have this patch applied after that one.

It's fine.

#4 lore raw

PATCH 2/2 x86: Use tab instead of space to indent in PCIE_ECAM_BASE

Quoted 24 lines · Simon Glass
Quoted 12 lines · Bin Meng

Hi Simon,

Quoted 9 lines · Bin Meng

Space is used before 'default' in PCIE_ECAM_BASE in arch/x86/Kconfig so it looks misaligned. Replace the space with tab to indent.

---

 arch/x86/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 10 lines

arch/x86/Kconfig source "board/intel/galileo/Kconfig"

Quoted 5 lines
arch/x86/Kconfig +0 -0
index 2370c32..fef11f3 100644
@@ -428,7 +428,7 @@ source "board/intel/galileo/Kconfig"

Ah, looks this patch depends on
http://patchwork.ozlabs.org/patch/434403/. Let me know if you need me respin, or just have this patch applied after that one.

Quoted 3 lines

It's fine.

Applied to u-boot-x86, thanks!

#6 lore raw

PATCH 1/2 bootstage: Fix typos in the comment

Quoted 10 lines · Simon Glass
Quoted 7 lines · Bin Meng

There are two typos in the comment block in bootstage.h, fix them.

---

 include/bootstage.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Applied to u-boot-x86, thanks!