Skip to contentSkip to conversation

media:dvb-frontends:Change setting of dtv_frontend_properties modulation to the correct value in the function,hd29l2_get_frontend

PATCH Antti Palosaari 1 participant 1 message Feb 2, 2015 1 message not in the archive Media (V4L/DVB)

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

Moikka!
That patch is not correct and will not even compile. Problem is that QAM_4NR and QAM_4 are not defined (OK, QPSK is QAM-4).

regards
Antti

Quoted 29 lines · Nicholas Krause

Changes the values in the switch statement of the function,d29l2_get_frontend to use the proper value for the dtv_frontend_properties modulation value. Further more this changes the values of case 0 and case 1 to use the correct values of QAM_4NR and QAM_4 respectfully.

---
  drivers/media/dvb-frontends/hd29l2.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/media/dvb-frontends/hd29l2.c +2 -2
index d7b9d54..48cafc9 100644
@@ -579,11 +579,11 @@ static int hd29l2_get_frontend(struct dvb_frontend *fe)
  	switch ((buf[0] >> 0) & 0x07) {
  	case 0: /* QAM4NR */
  		str_constellation = "QAM4NR";
-		c->modulation = QAM_AUTO; /* FIXME */
+		c->modulation = QAM_4NR;
  		break;
  	case 1: /* QAM4 */
  		str_constellation = "QAM4";
-		c->modulation = QPSK; /* FIXME */
+		c->modulation = QAM_4;
  		break;
  	case 2:
  		str_constellation = "QAM16";
Signature · 1 line
http://palosaari.fi/