cfg80211: Add API to change the indoor regulatory setting
PATCH v4 1/2 cfg80211: Add API to change the indoor regulatory setting
As the operating environment of a device can change, add API for user space to indicate a change of indoor settings. In addition modify the handling of the indoor processing as follows:
1. Directly update the indoor setting without wrapping it as a regulatory request.
2. Track the socket on which the indoor hint is issued, and reset indoor setting if the socket was released. The motivation here is to force a user space process that sets the indoor setting to constantly monitor this setting, and be responsible to correctly toggling it, so indoor operation will not be enabled uncontrolled.
3. Do not reset the indoor setting when restoring the regulatory settings as it has nothing to do with CRDA or interface disconnection.
--- include/uapi/linux/nl80211.h | 5 +++ net/wireless/nl80211.c | 10 +++++- net/wireless/reg.c | 80 +++++++++++++++++++++++++------------------- net/wireless/reg.h | 15 ++++++++- 4 files changed, 73 insertions(+), 37 deletions(-)
include/uapi/linux/nl80211.h +5 -0
@@ -1739,6 +1739,9 @@ enum nl80211_commands {* * @NL80211_ATTR_SCHED_SCAN_DELAY: delay before a scheduled scan (or a * WoWLAN net-detect scan) is started, u32 in seconds. + +* @NL80211_ATTR_REG_INDOOR: flag attribute, if set indicates that the device +* is operating in an indoor environment. * * @NUM_NL80211_ATTR: total number of nl80211_attrs available * @NL80211_ATTR_MAX: highest attribute number currently defined
@@ -2107,6 +2110,8 @@ enum nl80211_attrs {NL80211_ATTR_SCHED_SCAN_DELAY , +NL80211_ATTR_REG_INDOOR , +/* add attributes here, update the policy in nl80211.c */ __NL80211_ATTR_AFTER_LAST,
net/wireless/nl80211.c +9 -1
@@ -399,6 +399,7 @@ static const struct nla_policy nl80211_policy[NUM_NL80211_ATTR] = { [NL80211_ATTR_WIPHY_SELF_MANAGED_REG] = { .type = NLA_FLAG }, [NL80211_ATTR_NETNS_FD] = { .type = NLA_U32 }, [NL80211_ATTR_SCHED_SCAN_DELAY] = { .type = NLA_U32 }, + [NL80211_ATTR_REG_INDOOR] = { .type = NLA_FLAG }, };/* policy for the key attributes */
@@ -4955,6 +4956,7 @@ static int parse_reg_rule(struct nlattr *tb[],static int nl80211_req_set_reg (struct sk_buff *skb,struct genl_info *info) {char *data =NULL ; +bool is_indoor;enum nl80211_user_reg_hint_type user_reg_hint_type;/*
@@ -4981,7 +4983,8 @@ static int nl80211_req_set_reg(struct sk_buff *skb, struct genl_info *info) data =nla_data (info->attrs[NL80211_ATTR_REG_ALPHA2 ]);return regulatory_hint_user (data, user_reg_hint_type);case NL80211_USER_REG_HINT_INDOOR : -return regulatory_hint_indoor_user (); + is_indoor = !!info->attrs[NL80211_ATTR_REG_INDOOR ]; +return regulatory_hint_indoor (is_indoor, info->snd_portid);default :return -EINVAL ; }
@@ -12759,6 +12762,11 @@ static int nl80211_netlink_notify(struct notifier_block * nb,rcu_read_unlock (); +/* +* It is possible that the user space process that is controlling the +* indoor setting disappeared, so notify the regulatory core. +*/ +regulatory_netlink_notify (notify->portid);return NOTIFY_OK ; }
net/wireless/reg.c +45 -35
161 lines not on this page · raw message
net/wireless/reg.h +14 -1
@@ -25,7 +25,20 @@ enum nl80211_dfs_regions reg_get_dfs_region(struct wiphy *wiphy);int regulatory_hint_user (const char *alpha2,enum nl80211_user_reg_hint_type user_reg_hint_type); -int regulatory_hint_indoor_user (void ); + +/** +* regulatory_hint_indoor - hint operation in indoor env. or not +* @is_indoor: if true indicates that user space thinks that the +* device is operating in an indoor environment. +* @portid: the netlink port ID on which the hint was given. +*/ +int regulatory_hint_indoor (bool is_indoor,u32 portid); + +/** +* regulatory_netlink_notify - notify on released netlink socket +* @portid: the netlink socket port ID +*/ +void regulatory_netlink_notify (u32 portid);void wiphy_regulatory_register (struct wiphy *wiphy);void wiphy_regulatory_deregister (struct wiphy *wiphy);
Signature · 1 line
1.8.3.2
PATCH v4 2/2 cfg80211: Schedule timeout for all CRDA calls
Timeout was scheduled only in case CRDA was called due to user hints, but was not scheduled for other cases. This can result in regulatory hint processing getting stuck in case that there is no CRDA configured.
Change this by scheduling a timeout every time CRDA is called. In addition, in restore_regulatory_settings() all pending requests are restored (and not only the user ones).
--- net/wireless/reg.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-)
net/wireless/reg.c +5 -10
@@ -552,6 +552,9 @@ reg_call_crda(struct regulatory_request *request) {if (call_crda (request->alpha2))return REG_REQ_IGNORE ; + +queue_delayed_work (system_power_efficient_wq, + ®_timeout,msecs_to_jiffies (3142 ));return REG_REQ_OK ; }
@@ -1779,8 +1782,7 @@ static void reg_set_request_processed(void) need_more_processing = true;spin_unlock (®_requests_lock); -if (lr->initiator ==NL80211_REGDOM_SET_BY_USER ) -cancel_delayed_work (®_timeout); +cancel_delayed_work (®_timeout);if (need_more_processing)schedule_work (®_work);
@@ -2059,8 +2061,6 @@ static void reg_process_hint(struct regulatory_request *reg_request)if (treatment ==REG_REQ_IGNORE || treatment ==REG_REQ_ALREADY_SET )return ; -queue_delayed_work (system_power_efficient_wq, - ®_timeout,msecs_to_jiffies (3142 ));return ;case NL80211_REGDOM_SET_BY_DRIVER :if (!wiphy)
@@ -2485,7 +2485,6 @@ static void restore_regulatory_settings(bool reset_user)char alpha2[2 ];char world_alpha2[2 ];struct reg_beacon *reg_beacon, *btmp; -struct regulatory_request *reg_request, *tmp;LIST_HEAD (tmp_reg_req_list);struct cfg80211_registered_device *rdev;
@@ -2501,11 +2500,7 @@ static void restore_regulatory_settings(bool reset_user)* settings. */ spin_lock (®_requests_lock); -list_for_each_entry_safe (reg_request, tmp, ®_requests_list, list) { -if (reg_request->initiator !=NL80211_REGDOM_SET_BY_USER ) -continue ; -list_move_tail (®_request->list, &tmp_reg_req_list); - } +list_splice_tail_init (®_requests_list, &tmp_reg_req_list);spin_unlock (®_requests_lock);/* Clear beacon hints */
Signature · 1 line
1.8.3.2
Quoted 7 lines · Ilan Peer
As the operating environment of a device can change, add API for user space to indicate a change of indoor settings. In addition modify the handling of the indoor processing as follows:
1. Directly update the indoor setting without wrapping it as a regulatory request.
Why? We have this present as part of the request as it was part of the country IE, that's all. I can see for instance then that it is wise to require the supplicant for instance to be still connected to the AP and the socket tracking as solution to the problem. Does that summarize the logic ?
Quoted 5 lines
2. Track the socket on which the indoor hint is issued, and reset indoor setting if the socket was released. The motivation here is to force a user space process that sets the indoor setting to constantly monitor this setting, and be responsible to correctly toggling it, so indoor operation will not be enabled uncontrolled.
That seems to imply a new requirement for something that used to work, what having an option to set this requirement?
Quoted 3 lines
3. Do not reset the indoor setting when restoring the regulatory settings as it has nothing to do with CRDA or interface disconnection.
I disagree, if we disconnect we want the more restrictive setting and if we put the indoor setting out of general regulatory requests then we do want to reset this no?
Quoted 53 lines
Signed-off-by Ilan Peer <[email protected]>Signed-off-by ArikX Nemtsov <[email protected]>--- include/uapi/linux/nl80211.h | 5 +++ net/wireless/nl80211.c | 10 +++++- net/wireless/reg.c | 80 +++++++++++++++++++++++++------------------- net/wireless/reg.h | 15 ++++++++- 4 files changed, 73 insertions(+), 37 deletions(-)include/uapi/linux/nl80211.h +5
-0@@ -1739,6 +1739,9 @@ enum nl80211_commands {* * @NL80211_ATTR_SCHED_SCAN_DELAY: delay before a scheduled scan (or a * WoWLAN net-detect scan) is started, u32 in seconds. + +* @NL80211_ATTR_REG_INDOOR: flag attribute, if set indicates that the device +* is operating in an indoor environment. * * @NUM_NL80211_ATTR: total number of nl80211_attrs available * @NL80211_ATTR_MAX: highest attribute number currently defined @@ -2107,6 +2110,8 @@ enum nl80211_attrs {NL80211_ATTR_SCHED_SCAN_DELAY , +NL80211_ATTR_REG_INDOOR , +/* add attributes here, update the policy in nl80211.c */ __NL80211_ATTR_AFTER_LAST,net/wireless/nl80211.c +2
-0@@ -399,6 +399,7 @@ static const struct nla_policy nl80211_policy[NUM_NL80211_ATTR] = { [NL80211_ATTR_WIPHY_SELF_MANAGED_REG] = { .type = NLA_FLAG }, [NL80211_ATTR_NETNS_FD] = { .type = NLA_U32 }, [NL80211_ATTR_SCHED_SCAN_DELAY] = { .type = NLA_U32 }, + [NL80211_ATTR_REG_INDOOR] = { .type = NLA_FLAG }, };/* policy for the key attributes */ @@ -4955,6 +4956,7 @@ static int parse_reg_rule(struct nlattr *tb[],static int nl80211_req_set_reg (struct sk_buff *skb,struct genl_info *info) {char *data =NULL ; +bool is_indoor;enum nl80211_user_reg_hint_type user_reg_hint_type;/*
net/wireless/nl80211.c static int nl80211_req_set_reg(struct sk_buff *skb, struct genl_info *info) · line 4987
Quoted 6 lines
net/wireless/nl80211.c +2
-1@@ -4981,7 +4983,8 @@ static int nl80211_req_set_reg(struct sk_buff *skb, struct genl_info *info) data =nla_data (info->attrs[NL80211_ATTR_REG_ALPHA2 ]);return regulatory_hint_user (data, user_reg_hint_type);case NL80211_USER_REG_HINT_INDOOR : -return regulatory_hint_indoor_user (); + is_indoor = !!info->attrs[NL80211_ATTR_REG_INDOOR ]; +return regulatory_hint_indoor (is_indoor, info->snd_portid);
So we break old functionality ? No bueno.
Luis
Re: [PATCH v4 2/2] cfg80211: Schedule timeout for all CRDA calls
In reply to Ilan PeerQuoted 9 lines · Ilan Peer
Timeout was scheduled only in case CRDA was called due to user hints, but was not scheduled for other cases. This can result in regulatory hint processing getting stuck in case that there is no CRDA configured.
Change this by scheduling a timeout every time CRDA is called. In addition, in
restore_regulatory_settings()all pending requests are restored (and not only the user ones).Signed-off-by Ilan Peer <[email protected]>
Luis
Hi Luis,
Quoted 14 lines
-----Original Message-----
From: Luis R. Rodriguez [mailto:[email protected]]
Sent: Saturday, February 07, 2015 01:58
To: Peer, Ilan
Cc: [email protected]; ArikX Nemtsov
Subject: Re: [PATCH v4 1/2] cfg80211: Add API to change the indoor regulatory settingQuoted 5 lines · Ilan Peer
As the operating environment of a device can change, add API for user space to indicate a change of indoor settings.
In addition modify the handling of the indoor processing as follows:
Quoted 8 lines
Quoted 2 lines
1. Directly update the indoor setting without wrapping it as a regulatory request.
Why? We have this present as part of the request as it was part of the country IE, that's all. I can see for instance then that it is wise to require the supplicant for instance to be still connected to the AP and the socket tracking as solution to the problem. Does that summarize the logic ?
This differs from the country setting that would potentially require user space interaction and might invoke more complex flows. The flow in this case is immediate, and does not require the somewhat complex handling of country settings (it even complicates the flow unnecessarily, with the REG_REQ_USER_HINT_HANDLED etc.).
Quoted 8 lines
Quoted 5 lines
2. Track the socket on which the indoor hint is issued, and reset indoor setting if the socket was released. The motivation here is to force a user space process that sets the indoor setting to constantly monitor this setting, and be responsible to correctly toggling it, so indoor operation will not be enabled uncontrolled.
That seems to imply a new requirement for something that used to work, what having an option to set this requirement?
(Sadly) I would not consider the previous implementation as working as it would leave the regulatory core in a state that it considers to be indoor although it is no longer true.
Quoted 9 lines
Quoted 4 lines
3. Do not reset the indoor setting when restoring the regulatory settings as it has nothing to do with CRDA or interface disconnection.
I disagree, if we disconnect we want the more restrictive setting and if we put the indoor setting out of general regulatory requests then we do want to reset this no?
I do not think so. This setting is in the responsibility of the user space daemon, so it should be the one controlling it. A disconnection of the station interface does not imply that we are no longer operating in an indoor environment. This also related to #2 above that tightens the responsibility of the user space daemon controlling this setting.
Quoted 59 lines
Quoted 6 lines
Signed-off-by Ilan Peer <[email protected]>Signed-off-by ArikX Nemtsov <[email protected]>--- include/uapi/linux/nl80211.h | 5 +++ net/wireless/nl80211.c | 10 +++++- net/wireless/reg.c | 80 +++++++++++++++++++++++++-------------------
include/uapi/linux/nl80211.h enum nl80211_commands { · line 1740
Quoted 10 lines
net/wireless/reg.h | 15 ++++++++- 4 files changed, 73 insertions(+), 37 deletions(-)(quoted diff) +0
-0
b/include/uapi/linux/nl80211.hindex 68b294e..d80edcc 100644include/uapi/linux/nl80211.h +0
-0@@ -1739,6 +1739,9 @@ enum nl80211_commands {* * @NL80211_ATTR_SCHED_SCAN_DELAY: delay before a scheduled scan (or a
include/uapi/linux/nl80211.h enum nl80211_commands {
Quoted 3 lines
include/uapi/linux/nl80211.h +2
-0* WoWLAN net-detect scan) is started, u32 in seconds. + +* @NL80211_ATTR_REG_INDOOR: flag attribute, if set indicates that the device
net/wireless/nl80211.c static const struct nla_policy
Quoted 18 lines
include/uapi/linux/nl80211.h +3
-1+* is operating in an indoor environment. * * @NUM_NL80211_ATTR: total number of nl80211_attrs available * @NL80211_ATTR_MAX: highest attribute number currently defined @@ -2107,6 +2110,8 @@ enum nl80211_attrs { NL80211_ATTR_SCHED_SCAN_DELAY, +NL80211_ATTR_REG_INDOOR, +/* add attributes here, update the policy in nl80211.c */ __NL80211_ATTR_AFTER_LAST,net/wireless/nl80211.c index renamed from net/wireless/nl80211.c +0
-0454d7a0..e78b096 100644
net/wireless/nl80211.c +0
-0@@ -399,6 +399,7 @@ static const struct nla_policynl80211_policy[NUM_NL80211_ATTR] = {
net/wireless/nl80211.c static const struct nla_policy · line 399
Quoted 1 line
net/wireless/nl80211.c +0
-0[NL80211_ATTR_WIPHY_SELF_MANAGED_REG] = { .type =
NLA_FLAG},net/wireless/nl80211.c static int nl80211_req_set_reg(struct sk_buff
Quoted 15 lines
net/wireless/nl80211.c +1
-0[NL80211_ATTR_NETNS_FD] = { .type = NLA_U32 }, [NL80211_ATTR_SCHED_SCAN_DELAY] = { .type = NLA_U32 }, + [NL80211_ATTR_REG_INDOOR] = { .type = NLA_FLAG }, };/* policy for the key attributes */ @@ -4955,6 +4956,7 @@ static int parse_reg_rule(struct nlattr *tb[],static int
nl80211_req_set_reg(struct sk_buff *skb, struct genl_info *info){net/wireless/nl80211.c +1
-0char *data =NULL ; +bool is_indoor;enum nl80211_user_reg_hint_type user_reg_hint_type;/* @@ -4981,7 +4983,8 @@ static int nl80211_req_set_reg(struct sk_buff*skb, struct
genl_info*info)
Quoted 9 lines
net/wireless/nl80211.c static int nl80211_req_set_reg(struct sk_buff *skb, struct genl_info *info) · line 4987
Quoted 6 lines
net/wireless/nl80211.c +2
-1data =nla_data (info->attrs[NL80211_ATTR_REG_ALPHA2 ]);return regulatory_hint_user (data, user_reg_hint_type);case NL80211_USER_REG_HINT_INDOOR : -return regulatory_hint_indoor_user (); + is_indoor = !!info->attrs[NL80211_ATTR_REG_INDOOR ]; +return regulatory_hint_indoor (is_indoor, info->snd_portid);So we break old functionality ? No bueno.
no bueno, pero necesario.
Previous functionality was not good in terms of regulatory compliance (once indoor was set there was no way to undo it ...), and lacked proper tracking of this setting by user space.
Regards,
Ilan.
Quoted 25 lines · Ilan
Hi Luis,
Quoted 14 lines
-----Original Message-----
From: Luis R. Rodriguez [mailto:[email protected]]
Sent: Saturday, February 07, 2015 01:58
To: Peer, Ilan
Cc: [email protected]; ArikX Nemtsov
Subject: Re: [PATCH v4 1/2] cfg80211: Add API to change the indoor regulatory settingQuoted 5 lines · Ilan Peer
As the operating environment of a device can change, add API for user space to indicate a change of indoor settings.
In addition modify the handling of the indoor processing as follows:Quoted 8 lines
Quoted 2 lines
1. Directly update the indoor setting without wrapping it as a regulatory request.
Why? We have this present as part of the request as it was part of the country IE, that's all. I can see for instance then that it is wise to require the supplicant for instance to be still connected to the AP and the socket tracking as solution to the problem. Does that summarize the logic ?
Quoted 5 lines
This differs from the country setting that would potentially require user space interaction and might invoke more complex flows. The flow in this case is immediate, and does not require the somewhat complex handling of country settings (it even complicates the flow unnecessarily, with the
REG_REQ_USER_HINT_HANDLEDetc.).
There's two things you should address then:
0) Try to mitigate the issue with the old userspace API if possible. This will enable old userspace to continue to work with the old API but also mitigate the issue you have described for which you are providing a new optimized solution for but that requires a new API.
1) With the new API have userspace be able to send to the kernel that userspace will do socket monitoring and because of this and the reasons you mentioned it will have more control over the environment boolean.
Quoted 6 lines
Quoted 6 lines
Quoted 5 lines
2. Track the socket on which the indoor hint is issued, and reset indoor setting if the socket was released. The motivation here is to force a user space process that sets the indoor setting to constantly monitor this setting, and be responsible to correctly toggling it, so indoor operation will not be enabled uncontrolled.
Quoted 6 lines
Quoted 2 lines
That seems to imply a new requirement for something that used to work, what having an option to set this requirement?
(Sadly) I would not consider the previous implementation as working as it would leave the regulatory core in a state that it considers to be indoor although it is no longer true.
Let's review the current implementation for indoor thing.
We assume we're not indoor unless userspace sends a regulatory_hint_indoor_user(), this is with the user reg hint type set to NL80211_USER_REG_HINT_INDOOR. For country IEs we never trust the country IE data since it may contain bogus data, but we also end up ignoring the environment aspect too.
If we disconnect we should be reseting the indoor setting to false. I just checked and restore_regulatory_settings() does set reg_is_indoor = false so if we are keeping the indoor setting I am missing something here, and it does indeed rather an issue that should be fixed. Where is the indoor setting being upkept?
Quoted 11 lines
Quoted 8 lines
Quoted 3 lines
3. Do not reset the indoor setting when restoring the regulatory settings as it has nothing to do with CRDA or interface disconnection.
I disagree, if we disconnect we want the more restrictive setting and if we put the indoor setting out of general regulatory requests then we do want to reset this no?
I do not think so. This setting is in the responsibility of the user space daemon, so it should be the one controlling it.
Right now the API requires sending the userspace regulatory hint and the kenrel should indeed reset to non-indoor upon disconnect, the later is an issue which should be fixed and what you introduce seems rather complex for something that should be fixed within the existing API.
Quoted 3 lines
A disconnection of the
station interface does not imply that we are no longer operating in an indoor environment.
I am confused you seem to be disagreeing with your above statement that says otherwise where you said that we leave the indoor setting in place if we disconnect. Can you clarify what you mean?
Do you mean that you don't wish to fix it so that upon disconnect we never get an indoor setting and instead prefer this to be a matter of socket monitoring?
Quoted 2 lines
This also related to #2 above that tightens the responsibility of the user space daemon controlling this setting.
This smells like an optimization feature.
Quoted 12 lines
Quoted 11 lines
Review static int nl80211_req_set_reg(struct sk_buff
Quoted 1 line
(quoted diff) +0
-0@@ -4981,7 +4983,8 @@ static int nl80211_req_set_reg(struct sk_buff*skb, struct
genl_info*info)net/wireless/nl80211.c static int nl80211_req_set_reg(struct sk_buff *skb, struct genl_info *info) · line 4987
Quoted 6 lines
net/wireless/nl80211.c +2
-1data =nla_data (info->attrs[NL80211_ATTR_REG_ALPHA2 ]);return regulatory_hint_user (data, user_reg_hint_type);case NL80211_USER_REG_HINT_INDOOR : -return regulatory_hint_indoor_user (); + is_indoor = !!info->attrs[NL80211_ATTR_REG_INDOOR ]; +return regulatory_hint_indoor (is_indoor, info->snd_portid);So we break old functionality ? No bueno.
Quoted 4 lines
no bueno, pero necesario.
Previous functionality was not good in terms of regulatory compliance (once indoor was set there was no way to undo it ...),
As I noted restore_regulatory_settings() does set reg_is_indoor = false so what is missing?
Quoted 1 line
and lacked proper tracking of this setting by user space.
This seems like an optimization that you want and if you do wish to add that I'd recommend NL80211_USER_REG_HINT_INDOOR_SOCK_MONITOR and document as a feature which allows the interpretation you noted but you must first address the issue with the existing API as I'm failing to see where we fail to reset the regulatory setting for indoor.
Luis
Hi Luis,
Quoted 7 lines
Quoted 6 lines
This differs from the country setting that would potentially require user space interaction and might invoke more complex flows. The flow in this case is immediate, and does not require the somewhat complex handling of country settings (it even complicates the flow unnecessarily, with the
REG_REQ_USER_HINT_HANDLEDetc.).
Quoted 8 lines
There's two things you should address then:
0) Try to mitigate the issue with the old userspace API if possible. This will enable old userspace to continue to work with the old API but also mitigate the issue you have described for which you are providing a new optimized solution for but that requires a new API.
Not sure I have a good solution for this. The problem here is that with the current API, the indoor setting will stick as long as a station interface is connected, although the indoor setting might no longer be true. For example when a station interface is connected to P2P GO (or a soft AP) and both devices are moving out of the indoor environment. The motivation for this patch was to move the full control of this setting to user space.
Any suggestion are welcomed.
Quoted 5 lines
1) With the new API have userspace be able to send to the kernel that userspace will do socket monitoring and because of this and the reasons you mentioned it will have more control over the environment boolean.
Ok. Will add such an API.
Quoted 21 lines
Quoted 6 lines
Quoted 6 lines
Quoted 5 lines
2. Track the socket on which the indoor hint is issued, and reset indoor setting if the socket was released. The motivation here is to force a user space process that sets the indoor setting to constantly monitor this setting, and be responsible to correctly toggling it, so indoor operation will not be enabled uncontrolled.
Quoted 6 lines
Quoted 2 lines
That seems to imply a new requirement for something that used to work, what having an option to set this requirement?
(Sadly) I would not consider the previous implementation as working as it would leave the regulatory core in a state that it considers to be indoor although it is no longer true.
Let's review the current implementation for indoor thing.
We assume we're not indoor unless userspace sends a
regulatory_hint_indoor_user(), this is with the user reg hint type set toNL80211_USER_REG_HINT_INDOOR.
For country IEs we never trust the country IE data since it may contain bogus data, but we also end up ignoring the environment aspect too.
Quoted 6 lines
If we disconnect we should be reseting the indoor setting to false. I just checked and
restore_regulatory_settings()does setreg_is_indoor= false so if we are keeping the indoor setting I am missing something here, and it does indeed rather an issue that should be fixed. Where is the indoor setting being upkept?
This is generally true, but is not fully compatible with moving APs/P2P GOs, where you can be indoor, connect to an AP/P2P GO, and then move out of the indoor environment, while connected. Point is the being connected does not guarantee that the indoor setting is kept.
Quoted 9 lines
Quoted 9 lines
Quoted 8 lines
Quoted 3 lines
3. Do not reset the indoor setting when restoring the regulatory settings as it has nothing to do with CRDA or interface disconnection.
I disagree, if we disconnect we want the more restrictive setting and if we put the indoor setting out of general regulatory requests then we do want to reset this no?
Quoted 8 lines
Quoted 2 lines
I do not think so. This setting is in the responsibility of the user space daemon, so it should be the one controlling it.
Right now the API requires sending the userspace regulatory hint and the kenrel should indeed reset to non-indoor upon disconnect, the later is an issue which should be fixed and what you introduce seems rather complex for something that should be fixed within the existing API.
The kernel does not have enough information to deduce indoor environment or not (as pointed above), only user space has the full information in this case, and should be responsible for controlling the setting.
Quoted 8 lines
Quoted 3 lines
A disconnection of the
station interface does not imply that we are no longer operating in an indoor environment.I am confused you seem to be disagreeing with your above statement that says otherwise where you said that we leave the indoor setting in place if we disconnect. Can you clarify what you mean?
What I meant is that a disconnection of the station interface does not imply that we are no longer operating in an indoor environment. For example, in an enterprise environment, disconnections/reconnection would happen all the time due to roaming etc., but in all this cases that device indoor setting would continue to be true.
Quoted 4 lines
Do you mean that you don't wish to fix it so that upon disconnect we never get an indoor setting and instead prefer this to be a matter of socket monitoring?
What I mean is that I want to make it the responsibility of the user space and not be depended on kernel wifi flows.
Quoted 18 lines
Quoted 2 lines
This also related to #2 above that tightens the responsibility of the user space daemon controlling this setting.
This smells like an optimization feature.
Quoted 13 lines
Quoted 12 lines
Quoted 2 lines
(quoted diff) +0
-0@@ -4981,7 +4983,8 @@ static int nl80211_req_set_reg(struct
sk_buff*skb, struct
genl_info*info)net/wireless/nl80211.c static int nl80211_req_set_reg(struct sk_buff *skb, struct genl_info *info) · line 4987
Quoted 6 lines
net/wireless/nl80211.c +2
-1data =nla_data (info->attrs[NL80211_ATTR_REG_ALPHA2 ]);return regulatory_hint_user (data, user_reg_hint_type);case NL80211_USER_REG_HINT_INDOOR : -return regulatory_hint_indoor_user (); + is_indoor = !!info->attrs[NL80211_ATTR_REG_INDOOR ]; +return regulatory_hint_indoor (is_indoor, info->snd_portid);So we break old functionality ? No bueno.
Quoted 8 lines
Quoted 4 lines
no bueno, pero necesario.
Previous functionality was not good in terms of regulatory compliance (once indoor was set there was no way to undo it ...),
As I noted
restore_regulatory_settings()does setreg_is_indoor= false so what is missing?
Hope I clarified this above.
Quoted 8 lines
Quoted 1 line
and lacked proper tracking of this setting by user space.
This seems like an optimization that you want and if you do wish to add that I'd recommend
NL80211_USER_REG_HINT_INDOOR_SOCK_MONITOR
and document as a feature which allows the interpretation you noted but you must first address the issue with the existing API as I'm failing to see where we fail to reset the regulatory setting for indoor.
Sure. I'll extend this with requested flag or similar.
Thanks again Luis (and sorry for the delayed response).
Ilan.
Wider community:
anyone aware of any *need* in the kernel to know whether one is indoor or not on a device running Linux other than wifi? Clearly it should be something that might be of interest to at least other RF devices, so that is at least one possibilty to consider already, but what else?
Quoted 18 lines · Ilan
Hi Luis,
Quoted 7 lines
Quoted 6 lines
This differs from the country setting that would potentially require user space interaction and might invoke more complex flows. The flow in this case is immediate, and does not require the somewhat complex handling of country settings (it even complicates the flow unnecessarily, with the
REG_REQ_USER_HINT_HANDLEDetc.).Quoted 8 lines
There's two things you should address then:
0) Try to mitigate the issue with the old userspace API if possible. This will enable old userspace to continue to work with the old API but also mitigate the issue you have described for which you are providing a new optimized solution for but that requires a new API.
Quoted 8 lines
Not sure I have a good solution for this. The problem here is that with the current API, the indoor setting will stick as long as a station interface is connected, although the indoor setting might no longer be true. For example when a station interface is connected to P2P GO (or a soft AP) and both devices are moving out of the indoor environment. The motivation for this patch was to move the full control of this setting to user space.
Any suggestion are welcomed.
Why not just clear it upon disconnect for the old case? It seems that would be better if that is better regulatory wise.
Quoted 8 lines
Quoted 6 lines
1) With the new API have userspace be able to send to the kernel that userspace will do socket monitoring and because of this and the reasons you mentioned it will have more control over the environment boolean.
Ok. Will add such an API.
Great.
Quoted 28 lines
Quoted 21 lines
Quoted 6 lines
Quoted 6 lines
Quoted 5 lines
2. Track the socket on which the indoor hint is issued, and reset indoor setting if the socket was released. The motivation here is to force a user space process that sets the indoor setting to constantly monitor this setting, and be responsible to correctly toggling it, so indoor operation will not be enabled uncontrolled.
Quoted 6 lines
Quoted 2 lines
That seems to imply a new requirement for something that used to work, what having an option to set this requirement?
(Sadly) I would not consider the previous implementation as working as it would leave the regulatory core in a state that it considers to be indoor although it is no longer true.
Let's review the current implementation for indoor thing.
We assume we're not indoor unless userspace sends a
regulatory_hint_indoor_user(), this is with the user reg hint type set toNL80211_USER_REG_HINT_INDOOR.
For country IEs we never trust the country IE data since it may contain bogus data, but we also end up ignoring the environment aspect too.Quoted 6 lines
If we disconnect we should be reseting the indoor setting to false. I just checked and
restore_regulatory_settings()does setreg_is_indoor= false so if we are keeping the indoor setting I am missing something here, and it does indeed rather an issue that should be fixed. Where is the indoor setting being upkept?
Quoted 4 lines
This is generally true, but is not fully compatible with moving APs/P2P GOs, where you can be indoor, connect to an AP/P2P GO, and then move out of the indoor environment, while connected. Point is the being connected does not guarantee that the indoor setting is kept.
Ah so then the above description does satisfy the concern you stated. What you are describing *now* is a dynamic environment new requirement.
That's a very different picture than what you originally stated and your commit message does not clarify what worked and what really are the issue well. As it stands your changes will be an ammendment to help with dynamic environment setting, and it will also enable environment options to remain post disconnect.
Quoted 18 lines
Quoted 9 lines
Quoted 9 lines
Quoted 8 lines
Quoted 3 lines
3. Do not reset the indoor setting when restoring the regulatory settings as it has nothing to do with CRDA or interface disconnection.
I disagree, if we disconnect we want the more restrictive setting and if we put the indoor setting out of general regulatory requests then we do want to reset this no?
Quoted 8 lines
Quoted 2 lines
I do not think so. This setting is in the responsibility of the user space daemon, so it should be the one controlling it.
Right now the API requires sending the userspace regulatory hint and the kenrel should indeed reset to non-indoor upon disconnect, the later is an issue which should be fixed and what you introduce seems rather complex for something that should be fixed within the existing API.
Quoted 3 lines
The kernel does not have enough information to deduce indoor environment or not (as pointed above), only user space has the full information in this case, and should be responsible for controlling the setting.
Do you forsee other sources to override the socket information? What about a disconnect, will that kill the socket setting too? What about a future feature, say something generic in the kernel?
Quoted 11 lines
Quoted 8 lines
Quoted 3 lines
A disconnection of the
station interface does not imply that we are no longer operating in an indoor environment.I am confused you seem to be disagreeing with your above statement that says otherwise where you said that we leave the indoor setting in place if we disconnect. Can you clarify what you mean?
What I meant is that a disconnection of the station interface does not imply that we are no longer operating in an indoor environment.
Sure.
Quoted 4 lines
For example, in an
enterprise environment, disconnections/reconnection would happen all the time due to roaming etc., but in all this cases that device indoor setting would continue to be true.
Sure.
Quoted 7 lines
Quoted 4 lines
Do you mean that you don't wish to fix it so that upon disconnect we never get an indoor setting and instead prefer this to be a matter of socket monitoring?
What I mean is that I want to make it the responsibility of the user space and not be depended on kernel wifi flows.
OK
Quoted 20 lines
Quoted 20 lines
Quoted 2 lines
This also related to #2 above that tightens the responsibility of the user space daemon controlling this setting.
This smells like an optimization feature.
Quoted 15 lines
Quoted 12 lines
Quoted 2 lines
(quoted diff) +0
-0@@ -4981,7 +4983,8 @@ static int nl80211_req_set_reg(struct
sk_buff*skb, struct
genl_info*info)net/wireless/nl80211.c static int nl80211_req_set_reg(struct sk_buff *skb, struct genl_info *info) · line 4987
Quoted 6 lines
net/wireless/nl80211.c +2
-1data =nla_data (info->attrs[NL80211_ATTR_REG_ALPHA2 ]);return regulatory_hint_user (data, user_reg_hint_type);case NL80211_USER_REG_HINT_INDOOR : -return regulatory_hint_indoor_user (); + is_indoor = !!info->attrs[NL80211_ATTR_REG_INDOOR ]; +return regulatory_hint_indoor (is_indoor, info->snd_portid);So we break old functionality ? No bueno.
no bueno, pero necesario.
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines
Previous functionality was not good in terms of regulatory compliance (once indoor was set there was no way to undo it ...),
As I noted
restore_regulatory_settings()does setreg_is_indoor= false so what is missing?Hope I clarified this above.
You did and it confirms my suspicion that this is an optimization. You need to sell it as such and most importantly document this very well.
Quoted 9 lines
Quoted 8 lines
Quoted 1 line
and lacked proper tracking of this setting by user space.
This seems like an optimization that you want and if you do wish to add that I'd recommend
NL80211_USER_REG_HINT_INDOOR_SOCK_MONITOR
and document as a feature which allows the interpretation you noted but you must first address the issue with the existing API as I'm failing to see where we fail to reset the regulatory setting for indoor.
Quoted 3 lines
Sure. I'll extend this with requested flag or similar.
Thanks again Luis (and sorry for the delayed response).
Likewise,
Luis
Quoted 6 lines · Luis R. Rodriguez
Wider community:
anyone aware of any *need* in the kernel to know whether one is indoor or not on a device running Linux other than wifi? Clearly it should be something that might be of interest to at least other RF devices, so that is at least one possibilty to consider already, but what else?
I can think of a lot of reasons for the kernel to make indoor/outdoor status available to userspace, but am coming up empty why the kernel itself should care....
Quoted 11 lines · On Thu, Feb 19, 2015 at 5:03 PM, <[email protected]> wrote:
Quoted 6 lines · Luis R. Rodriguez
Wider community:
anyone aware of any *need* in the kernel to know whether one is indoor or not on a device running Linux other than wifi? Clearly it should be something that might be of interest to at least other RF devices, so that is at least one possibilty to consider already, but what else?
I can think of a lot of reasons for the kernel to make indoor/outdoor status available to userspace, but am coming up empty why the kernel itself should care....
Some devices enable regulatory control through the kernel, in such cases the wireless-regdb is used and there is an INDOOR flag that enables / disables specific functionality.
Luis
Quoted 12 lines · On 02/19/2015 08:03 PM, [email protected] wrote:
Quoted 6 lines · Luis R. Rodriguez
Wider community:
anyone aware of any *need* in the kernel to know whether one is indoor or not on a device running Linux other than wifi? Clearly it should be something that might be of interest to at least other RF devices, so that is at least one possibilty to consider already, but what else?
I can think of a lot of reasons for the kernel to make indoor/outdoor status available to userspace, but am coming up empty why the kernel itself should care....
That made me try to think of the possible uses for such a variable but I imagine that they can all be handled by userspace as well.
Powering down GPS chips for energy consumption.
Applying filters to cameras for fluorescent lights.
Quoted 19 lines · Jonathan Bither
Quoted 13 lines · On 02/19/2015 08:03 PM, [email protected] wrote:
Quoted 9 lines · Luis R. Rodriguez
Wider community:
anyone aware of any *need* in the kernel to know whether one is indoor or not on a device running Linux other than wifi? Clearly it should be something
that might be of interest to at least other RF devices, so that is at least
one possibilty to consider already, but what else?Quoted 5 lines
I can think of a lot of reasons for the kernel to make indoor/outdoor status available to userspace, but am coming up empty why the kernel itself
should care....
Quoted 4 lines
That made me try to think of the possible uses for such a variable but I imagine that they can all be handled by userspace as well.
Powering down GPS chips for energy consumption. Applying filters to cameras for fluorescent lights.
These days such devices are bundled with all these devices typically aiming towards single-chip, ie one devices with multiple functions and sharing as much as possible, as such it should be possible architecturally to share this. So far then it seems this can just live under its hood under cfg80211 then.
Luis
Hi Luis,
Can you please have a look at version 5 of the patch? I think that I addressed some concerns there. Regardless, I'll send another version that clarifies the optimization in the commit message.
Thanks again,
Ilan.
Quoted 42 lines
-----Original Message-----
From: Luis R. Rodriguez [mailto:[email protected]]
Sent: Friday, February 20, 2015 02:54
To: Peer, Ilan
Cc: [email protected]; ArikX Nemtsov; linux- [email protected]
Subject: Re: [PATCH v4 1/2] cfg80211: Add API to change the indoor regulatory settingWider community:
anyone aware of any *need* in the kernel to know whether one is indoor or not on a device running Linux other than wifi? Clearly it should be something that might be of interest to at least other RF devices, so that is at least one possibilty to consider already, but what else?
Quoted 8 lines · Ilan
Hi Luis,
Quoted 6 lines
Quoted 6 lines
This differs from the country setting that would potentially require user space interaction and might invoke more complex flows. The flow in this case is immediate, and does not require the somewhat complex handling of country settings (it even complicates the flow unnecessarily, with the
REG_REQ_USER_HINT_HANDLEDetc.).Quoted 10 lines
Quoted 9 lines
There's two things you should address then:
0) Try to mitigate the issue with the old userspace API if possible. This will enable old userspace to continue to work with the old API but also mitigate the issue you have described for which you are providing a new optimized solution for but that requires a new API.
Quoted 6 lines
Not sure I have a good solution for this. The problem here is that with the current API, the indoor setting will stick as long as a station interface is connected, although the indoor setting might no longer be true. For example when a station interface is connected to P2P GO (or a soft AP) and both devices are moving out of the indoor environment. The motivation for this patch was to move the full control of
Quoted 7 lines
this setting to user space.
Quoted 2 lines
Any suggestion are welcomed.
Why not just clear it upon disconnect for the old case? It seems that would be better if that is better regulatory wise.
Yep. This is what I did in version 5. Did you get a chance to look at it?
Quoted 41 lines
Quoted 8 lines
Quoted 6 lines
1) With the new API have userspace be able to send to the kernel that userspace will do socket monitoring and because of this and the reasons you mentioned it will have more control over the environment boolean.
Ok. Will add such an API.
Great.
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
2. Track the socket on which the indoor hint is issued, and reset indoor setting if the socket was released. The motivation here is to force a user space process that sets the indoor setting to
constantly
Quoted 10 lines
Quoted 10 lines
Quoted 9 lines
Quoted 5 lines
Quoted 2 lines
monitor this setting, and be responsible to correctly toggling it, so indoor operation will not be enabled uncontrolled.
That seems to imply a new requirement for something that used to work, what having an option to set this requirement?
(Sadly) I would not consider the previous implementation as working as it would leave the regulatory core in a state that it considers to be indoor although it is no longer true.
Quoted 7 lines
Quoted 7 lines
Let's review the current implementation for indoor thing.
We assume we're not indoor unless userspace sends a
regulatory_hint_indoor_user(), this is with the user reg hint type set toNL80211_USER_REG_HINT_INDOOR.
For country IEs we never trust the country IE data since it may contain bogus data, but we also end up ignoring the environment aspecttoo.
Quoted 8 lines
Quoted 7 lines
If we disconnect we should be reseting the indoor setting to false. I just checked and
restore_regulatory_settings()does setreg_is_indoor= false so if we are keeping the indoor setting I am missing something here, and it does indeed rather an issue that should be fixed. Where is the indoor setting being upkept?
Quoted 8 lines
Quoted 4 lines
This is generally true, but is not fully compatible with moving APs/P2P GOs, where you can be indoor, connect to an AP/P2P GO, and then move out of the indoor environment, while connected. Point is the being connected does not guarantee that the indoor setting is kept.
Ah so then the above description does satisfy the concern you stated. What you are describing *now* is a dynamic environment new requirement.
Not really a new requirement, but one that I missed in the original patch. Sorry.
Quoted 6 lines
That's a very different picture than what you originally stated and your commit message does not clarify what worked and what really are the issue well. As it stands your changes will be an ammendment to help with dynamic environment setting, and it will also enable environment options to remain post disconnect.
I can clarify this in the commit message.
Quoted 18 lines
Quoted 18 lines
Quoted 17 lines
Quoted 11 lines
Quoted 8 lines
Quoted 3 lines
3. Do not reset the indoor setting when restoring the regulatory settings as it has nothing to do with CRDA or interface disconnection.
I disagree, if we disconnect we want the more restrictive setting and if we put the indoor setting out of general regulatory requests then we do want to reset this no?
I do not think so. This setting is in the responsibility of the user space daemon, so it should be the one controlling it.
Right now the API requires sending the userspace regulatory hint and the kenrel should indeed reset to non-indoor upon disconnect, the later is an issue which should be fixed and what you introduce seems rather complex for something that should be fixed within the existing API.
Quoted 9 lines
Quoted 3 lines
The kernel does not have enough information to deduce indoor environment or not (as pointed above), only user space has the full information in this case, and should be responsible for controlling the
setting.
Do you forsee other sources to override the socket information? What about a disconnect, will that kill the socket setting too? What about a future feature, say something generic in the kernel?
I modified this in version 5 of the patch, so unless user space clearly states that it owns the socket, the indoor setting would be cleared upon disconnection. Otherwise, as long as the socket is connected, the reg core assumes that the setting is controlled by user space and does not alter it.
Quoted 58 lines
Quoted 11 lines
Quoted 8 lines
Quoted 3 lines
A disconnection of the
station interface does not imply that we are no longer operating in an indoor environment.I am confused you seem to be disagreeing with your above statement that says otherwise where you said that we leave the indoor setting in place if we disconnect. Can you clarify what you mean?
What I meant is that a disconnection of the station interface does not imply that we are no longer operating in an indoor environment.
Sure.
Quoted 4 lines
For example, in an
enterprise environment, disconnections/reconnection would happen all the time due to roaming etc., but in all this cases that device indoor setting would continue to be true.Sure.
Quoted 7 lines
Quoted 4 lines
Do you mean that you don't wish to fix it so that upon disconnect we never get an indoor setting and instead prefer this to be a matter of socket monitoring?
What I mean is that I want to make it the responsibility of the user space and not be depended on kernel wifi flows.
OK
Quoted 11 lines
Quoted 9 lines
Quoted 2 lines
This also related to #2 above that tightens the responsibility of the user space daemon controlling this setting.
This smells like an optimization feature.
Quoted 4 lines
Quoted 4 lines
Quoted 2 lines
(quoted diff) +0
-0@@ -4981,7 +4983,8 @@ static int nl80211_req_set_reg(struct
sk_buff*skb, struct
genl_info*info)Quoted 1 line
data = nla_data(info-
attrs[NL80211_ATTR_REG_ALPHA2]);
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
return regulatory_hint_user(data,
user_reg_hint_type);Quoted 15 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
net/wireless/nl80211.c static int nl80211_req_set_reg(struct sk_buff *skb, struct genl_info *info)
Quoted 3 lines
net/wireless/nl80211.c +1
-1case NL80211_USER_REG_HINT_INDOOR : -return regulatory_hint_indoor_user (); + is_indoor = !!info-attrs[NL80211_ATTR_REG_INDOOR];
Quoted 1 line
Quoted 1 line
Quoted 1 line
Review
Quoted 1 line
(quoted diff) +1
-0+ return regulatory_hint_indoor(is_indoor, info-
snd_portid);Quoted 9 lines
Quoted 8 lines
Quoted 3 lines
So we break old functionality ? No bueno.
no bueno, pero necesario.
Previous functionality was not good in terms of regulatory compliance (once indoor was set there was no way to undo it ...),
Quoted 9 lines
Quoted 5 lines
Quoted 3 lines
As I noted
restore_regulatory_settings()does setreg_is_indoor= false so what is missing?Hope I clarified this above.
You did and it confirms my suspicion that this is an optimization. You need to sell it as such and most importantly document this very well.
Will do.
Quoted 10 lines
Quoted 4 lines
Quoted 4 lines
Quoted 1 line
and lacked proper tracking of this setting by user space.
This seems like an optimization that you want and if you do wish to add that I'd recommend
NL80211_USER_REG_HINT_INDOOR_SOCK_MONITORQuoted 5 lines
Quoted 4 lines
and document as a feature which allows the interpretation you noted but you must first address the issue with the existing API as I'm failing to see where we fail to reset the regulatory setting for indoor.
Quoted 5 lines
Quoted 3 lines
Sure. I'll extend this with requested flag or similar.
Thanks again Luis (and sorry for the delayed response).
Likewise,
:)
Quoted 2 lines
Luis