Skip to contentSkip to conversation

ARC: Fix earlycon build breakage

PATCH In review Peter Hurley 4 participants 5 messages Feb 4, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARC: Fix earlycon build breakage

Commit ffb7fcd66f14 ("ARC: Dynamically determine BASE_BAUD from DeviceTree") breaks arc:defconfig build:

       drivers/built-in.o: In function `of_setup_earlycon':
       (.init.text+0xb3e): undefined reference to `arc_early_base_baud'
       drivers/built-in.o: In function `setup_earlycon':
       (.init.text+0xcd0): undefined reference to `arc_early_base_baud'
       make: *** [vmlinux] Error 1

BASE_BAUD is only required for earlycon, which should depend on CONFIG_SERIAL_EARLYCON.

---
 arch/arc/kernel/devtree.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arc/kernel/devtree.c +1 -1
index 5036d4c..e32b54a 100644
@@ -17,7 +17,7 @@
 #include <asm/clk.h>
 #include <asm/mach_desc.h>
 
-#ifdef CONFIG_SERIAL_8250_CONSOLE
+#ifdef CONFIG_SERIAL_EARLYCON
 
 static unsigned int __initdata arc_base_baud;
 
Signature · 1 line
2.2.2
#1 lore raw
Quoted 2 lines · Peter Hurley

Commit ffb7fcd66f14 ("ARC: Dynamically determine BASE_BAUD from DeviceTree") breaks arc:defconfig build:

I don't see that commit id in my trees, so why send this to me? Where did you find it?

confused,

greg k-h

#2 lore raw
Quoted 5 lines · Greg Kroah-Hartman
Quoted 2 lines · Peter Hurley

Commit ffb7fcd66f14 ("ARC: Dynamically determine BASE_BAUD from DeviceTree") breaks arc:defconfig build:

I don't see that commit id in my trees, so why send this to me?

Sorry. The earlier version of this patch was originally submitted to you, but I forgot that since all the tty parts were cut out (at my urging :/), it went through Vineet's tree directly.

Regards,
Peter Hurley

#3 lore raw
In reply to Greg Kroah-Hartman

Hi Greg,

Quoted 7 lines · On Tue, 3 Feb 2015 17:16:35 -0800 Greg Kroah-Hartman…
Quoted 2 lines · Peter Hurley

Commit ffb7fcd66f14 ("ARC: Dynamically determine BASE_BAUD from DeviceTree") breaks arc:defconfig build:

I don't see that commit id in my trees, so why send this to me? Where did you find it?

It comes from the arc tree. So, yes, not your concern.

Signature · 2 lines
Cheers,
Stephen Rothwell                    [email protected]
#4 lore raw
In reply to Peter Hurley
Quoted 9 lines · Peter Hurley

Commit ffb7fcd66f14 ("ARC: Dynamically determine BASE_BAUD from DeviceTree") breaks arc:defconfig build:

       drivers/built-in.o: In function `of_setup_earlycon':
       (.init.text+0xb3e): undefined reference to `arc_early_base_baud'
       drivers/built-in.o: In function `setup_earlycon':
       (.init.text+0xcd0): undefined reference to `arc_early_base_baud'
       make: *** [vmlinux] Error 1
Quoted 6 lines

BASE_BAUD is only required for earlycon, which should depend on CONFIG_SERIAL_EARLYCON.

/Me slaps myself :-(
Thx for the quick fix Peter. Now applied to my for-next and also quickly tested on simulator.

FWIW, the issue came about because defconfig doesn't use the 8250 uart driver, rather the legacy arc uart which still uses earlycon - but I still can't fathom why i didn't see it earlier.

Thx,
-Vineet

Quoted 17 lines
---
 arch/arc/kernel/devtree.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arc/kernel/devtree.c +1 -1
index 5036d4c..e32b54a 100644
@@ -17,7 +17,7 @@
 #include <asm/clk.h>
 #include <asm/mach_desc.h>
 
-#ifdef CONFIG_SERIAL_8250_CONSOLE
+#ifdef CONFIG_SERIAL_EARLYCON
 
 static unsigned int __initdata arc_base_baud;