Skip to contentSkip to conversation

dma/edma.c: fix sparse warnings

PATCH Applied Lad Prabhakar 2 participants 2 messages Feb 4, 2015 – Feb 12, 2015 dmaengine

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dma/edma.c: fix sparse warnings

From: "Lad, Prabhakar" <[email protected]>

this patch fixes following sparse warnings:

edma.c:537:32: warning: symbol 'edma_prep_dma_memcpy' was not declared. Should it be static? edma.c:1070:6: warning: symbol 'edma_filter_fn' was not declared. Should it be static?

---
Found this issue on linux-next (arm-cortex-a8-gcc version 4.7.3, sparse version 0.4.5-rc1)and applies on top linux-next.

 drivers/dma/edma.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/dma/edma.c +2 -1
index e95fa7d..276157f 100644
@@ -15,6 +15,7 @@
 
 #include <linux/dmaengine.h>
 #include <linux/dma-mapping.h>
+#include <linux/edma.h>
 #include <linux/err.h>
 #include <linux/init.h>
 #include <linux/interrupt.h>
@@ -534,7 +535,7 @@ static struct dma_async_tx_descriptor *edma_prep_slave_sg(
 	return vchan_tx_prep(&echan->vchan, &edesc->vdesc, tx_flags);
 }
 
-struct dma_async_tx_descriptor *edma_prep_dma_memcpy(
+static struct dma_async_tx_descriptor *edma_prep_dma_memcpy(
 	struct dma_chan *chan, dma_addr_t dest, dma_addr_t src,
 	size_t len, unsigned long tx_flags)
 {
Signature · 1 line
1.9.1
Applied
#1 lore raw
Quoted 7 lines · Lad Prabhakar

From: "Lad, Prabhakar" <[email protected]>

this patch fixes following sparse warnings:

edma.c:537:32: warning: symbol 'edma_prep_dma_memcpy' was not declared. Should it be static? edma.c:1070:6: warning: symbol 'edma_filter_fn' was not declared. Should it be static?

Applied, thanks.

Please ensure you use the right subsystem name and format

Signature · 1 line
~Vinod
Quoted 36 lines

---
Found this issue on linux-next (arm-cortex-a8-gcc version 4.7.3, sparse version 0.4.5-rc1)and applies on top linux-next.

 drivers/dma/edma.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/dma/edma.c +2 -1
index e95fa7d..276157f 100644
@@ -15,6 +15,7 @@
 
 #include <linux/dmaengine.h>
 #include <linux/dma-mapping.h>
+#include <linux/edma.h>
 #include <linux/err.h>
 #include <linux/init.h>
 #include <linux/interrupt.h>
@@ -534,7 +535,7 @@ static struct dma_async_tx_descriptor *edma_prep_slave_sg(
 	return vchan_tx_prep(&echan->vchan, &edesc->vdesc, tx_flags);
 }
 
-struct dma_async_tx_descriptor *edma_prep_dma_memcpy(
+static struct dma_async_tx_descriptor *edma_prep_dma_memcpy(
 	struct dma_chan *chan, dma_addr_t dest, dma_addr_t src,
 	size_t len, unsigned long tx_flags)
 {
Signature · 6 lines
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html