Skip to contentSkip to conversation

tty/sysrq: fix sparse warnings

PATCH In review Lad Prabhakar 2 participants 4 messages Feb 4, 2015 TTY layer and serial drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tty/sysrq: fix sparse warnings

From: "Lad, Prabhakar" <[email protected]>

this patch fixes following sparse warnings:
sysrq.c:58:16: warning: symbol 'platform_sysrq_reset_seq' was not declared. Should it be static? sysrq.c:59:5: warning: symbol 'sysrq_reset_downtime_ms' was not declared. Should it be static?

---
Found this issue on linux-next (gcc version 4.8.2, sparse version 0.4.5-rc1)and applies on top linux-next.

 drivers/tty/sysrq.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/tty/sysrq.c +2 -2
index 259a4d5..d272a37 100644
@@ -55,8 +55,8 @@
 static int __read_mostly sysrq_enabled = CONFIG_MAGIC_SYSRQ_DEFAULT_ENABLE;
 static bool __read_mostly sysrq_always_enabled;
 
-unsigned short platform_sysrq_reset_seq[] __weak = { KEY_RESERVED };
-int sysrq_reset_downtime_ms __weak;
+static unsigned short platform_sysrq_reset_seq[] __weak = { KEY_RESERVED };
+static int sysrq_reset_downtime_ms __weak;
 
 static bool sysrq_on(void)
 {
Signature · 1 line
1.9.1
#1 lore raw
Quoted 1 line · Lad Prabhakar

From: "Lad, Prabhakar" <[email protected]>

Why put your name in a different order than is normally used? Please just switch it around, tools don't like ',' all that much.

thanks,

greg k-h

#2 lore raw

Hi Greg,

Quoted 6 lines · Greg Kroah-Hartman
Quoted 1 line · Lad Prabhakar

From: "Lad, Prabhakar" <[email protected]>

Why put your name in a different order than is normally used? Please just switch it around, tools don't like ',' all that much.

I usually follow the same way, but will take care of it next time.

Cheers,
--Prabhakar Lad

#3 lore raw
In reply to Lad Prabhakar
Quoted 6 lines · Lad Prabhakar

From: "Lad, Prabhakar" <[email protected]>

this patch fixes following sparse warnings:
sysrq.c:58:16: warning: symbol 'platform_sysrq_reset_seq' was not declared. Should it be static? sysrq.c:59:5: warning: symbol 'sysrq_reset_downtime_ms' was not declared. Should it be static?

Sorry for the nose please drop this patch, it causes build failure,

drivers/tty/sysrq.c:58:23: error: weak declaration of ‘platform_sysrq_reset_seq’ must be public

 static unsigned short platform_sysrq_reset_seq[] __weak = { KEY_RESERVED };
                       ^
drivers/tty/sysrq.c:59:12: error: weak declaration of
‘sysrq_reset_downtime_ms’ must be public
 static int sysrq_reset_downtime_ms __weak;
            ^

Cheers,
--Prabhakar Lad

Quoted 26 lines

---
Found this issue on linux-next (gcc version 4.8.2, sparse version 0.4.5-rc1)and applies on top linux-next.

 drivers/tty/sysrq.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/tty/sysrq.c +2 -3
index 259a4d5..d272a37 100644
@@ -55,8 +55,8 @@
 static int __read_mostly sysrq_enabled = CONFIG_MAGIC_SYSRQ_DEFAULT_ENABLE;
 static bool __read_mostly sysrq_always_enabled;
 
-unsigned short platform_sysrq_reset_seq[] __weak = { KEY_RESERVED };
-int sysrq_reset_downtime_ms __weak;
+static unsigned short platform_sysrq_reset_seq[] __weak = { KEY_RESERVED };
+static int sysrq_reset_downtime_ms __weak;
 
 static bool sysrq_on(void)
 {
--

1.9.1