Skip to contentSkip to conversation

Documentation: Fix the wrong command `echo -1 > set_ftrace_pid` for cleaning the filter.

PATCH In review Wang Long 3 participants 3 messages Feb 5, 2015 – Feb 9, 2015

Subsystems (3)
lore
Share & tools
lore

Wang Long

author
#0 lore raw

PATCH 1/1 Documentation: Fix the wrong command `echo -1 > set_ftrace_pid` for cleaning the filter.

The command echo > set_ftrace_pid should be used to clean the filter quietly. because the command echo -1 > set_ftrace_pid will output the following:
"bash: echo: write error: Invalid argument".

so update the file Documentation/trace/ftrace.txt.

---
 Documentation/trace/ftrace.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/trace/ftrace.txt +1 -1
index 8408e04..572ca92 100644
@@ -1740,7 +1740,7 @@ no pid
      yum-updatesd-3111  [003]  1637.254683: lock_hrtimer_base <-hrtimer_try_to_cancel
      yum-updatesd-3111  [003]  1637.254685: fget_light <-do_sys_poll
      yum-updatesd-3111  [003]  1637.254686: pipe_poll <-do_sys_poll
-# echo -1 > set_ftrace_pid
+# echo > set_ftrace_pid
 # cat trace |head
  # tracer: function
  #
Signature · 1 line
1.8.3.4
maintainer
#1 lore raw
Quoted 5 lines · On Thu, 5 Feb 2015 05:16:14 +0000 Wang Long <[email protected]> wrote:

The command echo > set_ftrace_pid should be used to clean the filter quietly. because the command echo -1 > set_ftrace_pid will output the following:
"bash: echo: write error: Invalid argument".

so update the file Documentation/trace/ftrace.txt.

So this is in my pile for the docs tree, but I was hoping to see an ack from Steve first...?

Thanks,

jon

maintainer Acked-by
#2 lore raw
Quoted 11 lines · On Mon, 9 Feb 2015 10:57:29 -0500 Jonathan Corbet <[email protected]> wrote:
Quoted 5 lines · On Thu, 5 Feb 2015 05:16:14 +0000 Wang Long <[email protected]> wrote:

The command echo > set_ftrace_pid should be used to clean the filter quietly. because the command echo -1 > set_ftrace_pid will output the following:
"bash: echo: write error: Invalid argument".

so update the file Documentation/trace/ftrace.txt.

So this is in my pile for the docs tree, but I was hoping to see an ack from Steve first...?

Yeah, I meant to reply but got distracted ;-)

-- Steve