Skip to contentSkip to conversation

lpfc: Fix the iteration count to match the 30 sec comment

PATCH In review James Smart 2 participants 4 messages Feb 5, 2015 – Mar 9, 2015

Subsystems (2)
SCSI Emulex/Broadcom lpfc FC/FCoE SCSI driver
lore
Share & tools
lore

James Smart

author
#0 lore raw

PATCH 1/21 lpfc: Fix the iteration count to match the 30 sec comment

---
 drivers/scsi/lpfc/lpfc_init.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/lpfc/lpfc_init.c +1 -1
index 0b2c53a..2b5b910 100644
@@ -7953,7 +7953,7 @@ wait:
 		 * up to 30 seconds. If the port doesn't respond, treat
 		 * it as an error.
 		 */
-		for (rdy_chk = 0; rdy_chk < 3000; rdy_chk++) {
+		for (rdy_chk = 0; rdy_chk < 1500; rdy_chk++) {
 			if (lpfc_readl(phba->sli4_hba.u.if_type2.
 				STATUSregaddr, &reg_data.word0)) {
 				rc = -ENODEV;
Signature · 4 lines
1.7.11.7

Signed-off-by: James Smart <[email protected]>
Signed-off-by: Dick Kennedy <[email protected]>
maintainer
#1 lore raw
Quoted 1 line · James Smart

---

Could you put the signoffs (and any changelog) above here, please. You seem to be using git to generate the patches, so if you just put them in the git change log the right thing will happen. If you don't do this, all your patches have to be hand edited to apply them, which is a royal pain for a maintainer.

Quoted 21 lines
 drivers/scsi/lpfc/lpfc_init.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/lpfc/lpfc_init.c +1 -1
index 0b2c53a..2b5b910 100644
@@ -7953,7 +7953,7 @@ wait:
 		 * up to 30 seconds. If the port doesn't respond, treat
 		 * it as an error.
 		 */
-		for (rdy_chk = 0; rdy_chk < 3000; rdy_chk++) {
+		for (rdy_chk = 0; rdy_chk < 1500; rdy_chk++) {
 			if (lpfc_readl(phba->sli4_hba.u.if_type2.
 				STATUSregaddr, &reg_data.word0)) {
 				rc = -ENODEV;
Signature · 4 lines
1.7.11.7

Signed-off-by: James Smart <[email protected]>
Signed-off-by: Dick Kennedy <[email protected]>

I'm not quite understanding this signoff chain. It reads like Dick Kennedy is the author, in which case the patch needs a From: <him> at the top to make this clear. If it's jointly authored, then traditionally he'd still be the first signoff because the series of signoffs represents the transmission chain and you send the patch, so you should be last signoff.

James

author
#2 lore raw

Yes, I'll correct this. Trying to make Christoph happy by using git to format all the patches.

-- james

Quoted 44 lines · James Bottomley
Quoted 1 line · James Smart

---

Could you put the signoffs (and any changelog) above here, please. You seem to be using git to generate the patches, so if you just put them in the git change log the right thing will happen. If you don't do this, all your patches have to be hand edited to apply them, which is a royal pain for a maintainer.

Quoted 21 lines
  drivers/scsi/lpfc/lpfc_init.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/lpfc/lpfc_init.c +1 -1
index 0b2c53a..2b5b910 100644
@@ -7953,7 +7953,7 @@ wait:
  		 * up to 30 seconds. If the port doesn't respond, treat
  		 * it as an error.
  		 */
-		for (rdy_chk = 0; rdy_chk < 3000; rdy_chk++) {
+		for (rdy_chk = 0; rdy_chk < 1500; rdy_chk++) {
  			if (lpfc_readl(phba->sli4_hba.u.if_type2.
  				STATUSregaddr, &reg_data.word0)) {
  				rc = -ENODEV;
Signature · 4 lines
1.7.11.7

Signed-off-by: James Smart <[email protected]>
Signed-off-by: Dick Kennedy <[email protected]>

I'm not quite understanding this signoff chain. It reads like Dick Kennedy is the author, in which case the patch needs a From: <him> at the top to make this clear. If it's jointly authored, then traditionally he'd still be the first signoff because the series of signoffs represents the transmission chain and you send the patch, so you should be last signoff.

James

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

maintainer
#3 lore raw
Quoted 1 line · James Smart

Yes, I'll correct this.

Great, thanks!

Quoted 2 lines

Trying to make Christoph happy by using git to
format all the patches.

We're all happy you're using git to format the patches ... it's just a minor addition to your commit log to give me the information in the form I need.

Thanks,

James

Quoted 55 lines

-- james

Quoted 36 lines · James Bottomley
Quoted 1 line · James Smart

---

Could you put the signoffs (and any changelog) above here, please. You seem to be using git to generate the patches, so if you just put them in the git change log the right thing will happen. If you don't do this, all your patches have to be hand edited to apply them, which is a royal pain for a maintainer.

Quoted 21 lines
  drivers/scsi/lpfc/lpfc_init.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/lpfc/lpfc_init.c +1 -1
index 0b2c53a..2b5b910 100644
@@ -7953,7 +7953,7 @@ wait:
  		 * up to 30 seconds. If the port doesn't respond, treat
  		 * it as an error.
  		 */
-		for (rdy_chk = 0; rdy_chk < 3000; rdy_chk++) {
+		for (rdy_chk = 0; rdy_chk < 1500; rdy_chk++) {
  			if (lpfc_readl(phba->sli4_hba.u.if_type2.
  				STATUSregaddr, &reg_data.word0)) {
  				rc = -ENODEV;
Signature · 4 lines
1.7.11.7

Signed-off-by: James Smart <[email protected]>
Signed-off-by: Dick Kennedy <[email protected]>

I'm not quite understanding this signoff chain. It reads like Dick Kennedy is the author, in which case the patch needs a From: <him> at the top to make this clear. If it's jointly authored, then traditionally he'd still be the first signoff because the series of signoffs represents the transmission chain and you send the patch, so you should be last signoff.

Quoted 8 lines

James

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html