Skip to contentSkip to conversation

media:firewire:Remove unneeded function definition,avc_tuner_host2ca in firedtv-avc.c

PATCH Stefan Richter 1 participant 2 messages Feb 8, 2015 – Feb 9, 2015 2 messages not in the archive Media (V4L/DVB)

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 7 lines · On Feb 08 Nicholas Krause wrote:

Removes the unneeded function defintion,avc_tuner_host2ca in the file, firedtv-avc. This function should have been removed during the refactoring of the firetv code base during commit id,154907957f939 due to us removing unneeded definitions of functions not called when moving private function defintions from firedtv-avc.h to the file,firedtv-avc.c for the driver supporting firedtv enabled hardware respectfully.

I still am missing research on the question whether or not the Common Interface serving part of the driver needs to send Host2CA commands. If yes, we implement it and use the function. If not, we remove the function. As long as we are not sure, I prefer to leave the #if-0'd code where it is. It documents how the command is formed, and we don't have any other documentation (except perhaps the git history).

On a more general note, as others told you before, please stop sending patches that were created without any research on your part. Thank you.

Quoted 46 lines
---
 drivers/media/firewire/firedtv-avc.c | 31 -------------------------------
 1 file changed, 31 deletions(-)
drivers/media/firewire/firedtv-avc.c +0 -31
index 251a556..a7f2617 100644
@@ -912,37 +912,6 @@ void avc_remote_ctrl_work(struct work_struct *work)
 	avc_register_remote_control(fdtv);
 }
 
-#if 0 /* FIXME: unused */
-int avc_tuner_host2ca(struct firedtv *fdtv)
-{
-	struct avc_command_frame *c = (void *)fdtv->avc_data;
-	int ret;
-
-	mutex_lock(&fdtv->avc_mutex);
-
-	c->ctype   = AVC_CTYPE_CONTROL;
-	c->subunit = AVC_SUBUNIT_TYPE_TUNER | fdtv->subunit;
-	c->opcode  = AVC_OPCODE_VENDOR;
-
-	c->operand[0] = SFE_VENDOR_DE_COMPANYID_0;
-	c->operand[1] = SFE_VENDOR_DE_COMPANYID_1;
-	c->operand[2] = SFE_VENDOR_DE_COMPANYID_2;
-	c->operand[3] = SFE_VENDOR_OPCODE_HOST2CA;
-	c->operand[4] = 0; /* slot */
-	c->operand[5] = SFE_VENDOR_TAG_CA_APPLICATION_INFO; /* ca tag */
-	clear_operands(c, 6, 8);
-
-	fdtv->avc_data_length = 12;
-	ret = avc_write(fdtv);
-
-	/* FIXME: check response code? */
-
-	mutex_unlock(&fdtv->avc_mutex);
-
-	return ret;
-}
-#endif
-
 static int get_ca_object_pos(struct avc_response_frame *r)
 {
 	int length = 1;
Signature · 3 lines
Stefan Richter
-=====-===== --=- -=--=
http://arcgraph.de/sr/

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw
Quoted 7 lines · On Feb 08 nick wrote:
Quoted 6 lines · Stefan Richter

I still am missing research on the question whether or not the Common Interface serving part of the driver needs to send Host2CA commands. If yes, we implement it and use the function. If not, we remove the function. As long as we are not sure, I prefer to leave the #if-0'd code where it is. It documents how the command is formed, and we don't have any other documentation (except perhaps the git history).

[...]

Quoted 8 lines

Stefan,
I looked in the history with git log -p 154907957f939 and all I got for this function was
Wed Feb 11 21:21:04 CET 2009
firedtv: avc: header file cleanup

Remove unused constants and declarations. Move privately used constants into .c files.

The function was added a few commits before this one, by "firesat: update isochronous interface, add CI support".

Quoted 3 lines

Clearly this states to remove unused declarations and avc_tuner_host2ca is unused. Can you explain to me then why it's still needed to be around if there no callers of it?

See above; in this instance

	#if 0
	dead code
	#endif

stands in for

	/*
	 * pseudo code
	 */
Signature · 3 lines
Stefan Richter
-=====-===== --=- -=--=
http://arcgraph.de/sr/